From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mx.groups.io with SMTP id smtpd.web10.7997.1688115925017133993 for ; Fri, 30 Jun 2023 02:05:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=CkKNQeZn; spf=pass (domain: gmail.com, ip: 209.85.219.173, mailfrom: mike.maslenkin@gmail.com) Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-bd744ffc263so1543539276.3 for ; Fri, 30 Jun 2023 02:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688115924; x=1690707924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CORtDoxeooS2l8jvllcmBGfPg6hRqmmwNZJm/7MUS24=; b=CkKNQeZnfmVTXIfjwfq551wNq6t4aVsND59ii0r8tPNWz62btwPj87fHHdYaL3xM0j SWKRkcnM1/YaE+YFKLZdqPZFLHcAj7yF8yffjkitDXUKUXmER9lqYcbL3ub4+nc1L3eN XEjSyTM5eP5zbm0UTJ6+msJ/0mELV+aO8UEcUN6PLdisbspA1K6pBsQsdnKUUAxyYJ0A 8fzlOvoUDK4mZ0eloJyBEdI+u1WUBz3RlOsiqxMCmFUPVj6iA9iS9QCIwyNL/zlOAyp6 saET1g+8Dq9+xlLPjlSZ/ZFjAAtsWyYEOQ8yObgaIqxbubb7eISnAhvUQardaoWne2RY 8rXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688115924; x=1690707924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CORtDoxeooS2l8jvllcmBGfPg6hRqmmwNZJm/7MUS24=; b=ZDYlR3ZPA/BjkXCWc3vcxL81LjX6Ul5facihxGA5cdfP5yTZrDgqcs/5xvtrEGDs6a BbQZk7MdXB5RUKI0bxN8PIEUHjfTWrZLTkFWNDYQLF24kp5B8tZZTWyObg4n2kaBcD51 TMoJLa23SXHJWP1E75YeN4As2hddhBtu9DggGo9qEYFumXECrcWhOmWd2dWrjpZt6C9j G+rpcqtEvsFFbiyfkqtRonBnk6UQCsr3U6ubcosemGyMpLD2AS9tQaVEYgiXq4QqnnrR t8HHoiTQdm4hFqDUzqMUZJp4YneGVgwmAvInf81vYnL8blt6sDbU19AyVGu8AcqgQyNz 5P/g== X-Gm-Message-State: ABy/qLYGSutC1H1IJ3dJRV+0khWmCoIjWcAodxDqBtK6CupgW6UAlvEz anbI7q4BM5zKx4mQ/DgSWtHkWRAHcx2vkKxavvM= X-Google-Smtp-Source: APBJJlHqOGb8JVDDOEy2d0v+/M5ZJNpOTdwp7SiNCYRAsWpDsXCaoe+MdSQ2z2+NamVHDlqun6zBMnnALNaBqjC125E= X-Received: by 2002:a5b:949:0:b0:ba8:60ab:a7d3 with SMTP id x9-20020a5b0949000000b00ba860aba7d3mr461929ybq.48.1688115924062; Fri, 30 Jun 2023 02:05:24 -0700 (PDT) MIME-Version: 1.0 References: <20230620212950.28118-1-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Fri, 30 Jun 2023 12:04:47 +0300 Message-ID: Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo. To: "Chang, Abner" Cc: "devel@edk2.groups.io" , "nicklew@nvidia.com" , "igork@ami.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I created a PR for the change to edk2-redfish-client but that depends on this change to edk2. I created a new PR to edk2 for this patch: https://github.com/tianocore/edk2/pull/4592 Thanks, Mike On Fri, Jun 30, 2023 at 5:13=E2=80=AFAM Chang, Abner = wrote: > > [AMD Official Use Only - General] > > Hi Mike, > I see there are CI errors for this PR, could you please check it? Thanks! > Abner > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Friday, June 30, 2023 6:44 AM > > To: Chang, Abner > > Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com > > Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > Sure! > > https://github.com/tianocore/edk2-redfish-client/pull/43 > > > > Thanks, > > Mike > > > > > > On Tue, Jun 27, 2023 at 3:05=E2=80=AFAM Chang, Abner > > wrote: > > > > > > [AMD Official Use Only - General] > > > > > > Hi Mike, could you please create a PR for this change? Then I can mer= ge it > > once the change passed CI. > > > > > > Thanks > > > Abner > > > > > > > -----Original Message----- > > > > From: Chang, Abner > > > > Sent: Wednesday, June 21, 2023 8:26 AM > > > > To: Mike Maslenkin ; devel@edk2.groups.io > > > > Cc: nicklew@nvidia.com; igork@ami.com > > > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typ= o. > > > > > > > > Reviewed-by: Abner Chang > > > > > > > > > -----Original Message----- > > > > > From: Mike Maslenkin > > > > > Sent: Wednesday, June 21, 2023 5:30 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Chang, Abner ; nicklew@nvidia.com; > > > > > igork@ami.com; Mike Maslenkin > > > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > > > > > > > Caution: This message originated from an External Source. Use pro= per > > > > caution > > > > > when opening attachments, clicking links, or responding. > > > > > > > > > > > > > > > BaseSortLib is the library instance name not the class name. > > > > > > > > > > Signed-off-by: Mike Maslenkin > > > > > Cc: Abner Chang > > > > > Cc: Nickle Wang > > > > > Cc: Igor Kulchytskyy > > > > > --- > > > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +- > > > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +- > > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLi= b.inf > > > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > > > index 5c1c7cffa650..6ff5dba75c30 100644 > > > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > > > @@ -25,7 +25,7 @@ > > > > > > > > > > > > > > > [LibraryClasses] > > > > > > > > > > BaseLib > > > > > > > > > > - BaseSortLib > > > > > > > > > > + SortLib > > > > > > > > > > DebugLib > > > > > > > > > > MemoryAllocationLib > > > > > > > > > > UefiRuntimeServicesTableLib > > > > > > > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc > > b/RedfishPkg/RedfishLibs.dsc.inc > > > > > index 6e497899b556..03b7ef6f3289 100644 > > > > > --- a/RedfishPkg/RedfishLibs.dsc.inc > > > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc > > > > > @@ -14,7 +14,7 @@ > > > > > !if $(REDFISH_ENABLE) =3D=3D TRUE > > > > > > > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf > > > > > > > > > > > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > > > > > > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > > > > > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf > > > > > > > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf > > > > > > > > > > -- > > > > > 2.32.0 (Apple Git-132) > > >