* [PATCH] RedfishPkg: Fix SortLib library class name typo.
@ 2023-06-20 21:29 Mike Maslenkin
2023-06-21 0:25 ` Chang, Abner
0 siblings, 1 reply; 8+ messages in thread
From: Mike Maslenkin @ 2023-06-20 21:29 UTC (permalink / raw)
To: devel; +Cc: abner.chang, nicklew, igork, Mike Maslenkin
BaseSortLib is the library instance name not the class name.
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
RedfishPkg/RedfishLibs.dsc.inc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
index 5c1c7cffa650..6ff5dba75c30 100644
--- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
+++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
@@ -25,7 +25,7 @@
[LibraryClasses]
BaseLib
- BaseSortLib
+ SortLib
DebugLib
MemoryAllocationLib
UefiRuntimeServicesTableLib
diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
index 6e497899b556..03b7ef6f3289 100644
--- a/RedfishPkg/RedfishLibs.dsc.inc
+++ b/RedfishPkg/RedfishLibs.dsc.inc
@@ -14,7 +14,7 @@
!if $(REDFISH_ENABLE) == TRUE
RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
- BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
+ SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-20 21:29 [PATCH] RedfishPkg: Fix SortLib library class name typo Mike Maslenkin
@ 2023-06-21 0:25 ` Chang, Abner
2023-06-27 0:05 ` Chang, Abner
0 siblings, 1 reply; 8+ messages in thread
From: Chang, Abner @ 2023-06-21 0:25 UTC (permalink / raw)
To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Wednesday, June 21, 2023 5:30 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> BaseSortLib is the library instance name not the class name.
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
> RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> index 5c1c7cffa650..6ff5dba75c30 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> @@ -25,7 +25,7 @@
>
>
> [LibraryClasses]
>
> BaseLib
>
> - BaseSortLib
>
> + SortLib
>
> DebugLib
>
> MemoryAllocationLib
>
> UefiRuntimeServicesTableLib
>
> diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
> index 6e497899b556..03b7ef6f3289 100644
> --- a/RedfishPkg/RedfishLibs.dsc.inc
> +++ b/RedfishPkg/RedfishLibs.dsc.inc
> @@ -14,7 +14,7 @@
> !if $(REDFISH_ENABLE) == TRUE
>
> RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
>
> Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
>
> - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>
> + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>
> RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
>
> JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
>
> RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
>
> --
> 2.32.0 (Apple Git-132)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-21 0:25 ` Chang, Abner
@ 2023-06-27 0:05 ` Chang, Abner
2023-06-29 22:43 ` Mike Maslenkin
2023-07-01 3:22 ` Chang, Abner
0 siblings, 2 replies; 8+ messages in thread
From: Chang, Abner @ 2023-06-27 0:05 UTC (permalink / raw)
To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com
[AMD Official Use Only - General]
Hi Mike, could you please create a PR for this change? Then I can merge it once the change passed CI.
Thanks
Abner
> -----Original Message-----
> From: Chang, Abner
> Sent: Wednesday, June 21, 2023 8:26 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: nicklew@nvidia.com; igork@ami.com
> Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Wednesday, June 21, 2023 5:30 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> >
> > Caution: This message originated from an External Source. Use proper
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > BaseSortLib is the library instance name not the class name.
> >
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > ---
> > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > index 5c1c7cffa650..6ff5dba75c30 100644
> > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > @@ -25,7 +25,7 @@
> >
> >
> > [LibraryClasses]
> >
> > BaseLib
> >
> > - BaseSortLib
> >
> > + SortLib
> >
> > DebugLib
> >
> > MemoryAllocationLib
> >
> > UefiRuntimeServicesTableLib
> >
> > diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
> > index 6e497899b556..03b7ef6f3289 100644
> > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > @@ -14,7 +14,7 @@
> > !if $(REDFISH_ENABLE) == TRUE
> >
> > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> >
> > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> >
> > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> >
> > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> >
> > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> >
> > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> >
> > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> >
> > --
> > 2.32.0 (Apple Git-132)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-27 0:05 ` Chang, Abner
@ 2023-06-29 22:43 ` Mike Maslenkin
2023-06-30 2:13 ` Chang, Abner
2023-07-01 3:22 ` Chang, Abner
1 sibling, 1 reply; 8+ messages in thread
From: Mike Maslenkin @ 2023-06-29 22:43 UTC (permalink / raw)
To: Chang, Abner; +Cc: devel@edk2.groups.io, nicklew@nvidia.com, igork@ami.com
Sure!
https://github.com/tianocore/edk2-redfish-client/pull/43
Thanks,
Mike
On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike, could you please create a PR for this change? Then I can merge it once the change passed CI.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Chang, Abner
> > Sent: Wednesday, June 21, 2023 8:26 AM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: nicklew@nvidia.com; igork@ami.com
> > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > BaseSortLib is the library instance name not the class name.
> > >
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > ---
> > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > @@ -25,7 +25,7 @@
> > >
> > >
> > > [LibraryClasses]
> > >
> > > BaseLib
> > >
> > > - BaseSortLib
> > >
> > > + SortLib
> > >
> > > DebugLib
> > >
> > > MemoryAllocationLib
> > >
> > > UefiRuntimeServicesTableLib
> > >
> > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc.inc
> > > index 6e497899b556..03b7ef6f3289 100644
> > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > @@ -14,7 +14,7 @@
> > > !if $(REDFISH_ENABLE) == TRUE
> > >
> > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > >
> > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > >
> > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > >
> > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > >
> > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > >
> > > --
> > > 2.32.0 (Apple Git-132)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-29 22:43 ` Mike Maslenkin
@ 2023-06-30 2:13 ` Chang, Abner
2023-06-30 9:04 ` Mike Maslenkin
0 siblings, 1 reply; 8+ messages in thread
From: Chang, Abner @ 2023-06-30 2:13 UTC (permalink / raw)
To: Mike Maslenkin; +Cc: devel@edk2.groups.io, nicklew@nvidia.com, igork@ami.com
[AMD Official Use Only - General]
Hi Mike,
I see there are CI errors for this PR, could you please check it? Thanks!
Abner
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, June 30, 2023 6:44 AM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Sure!
> https://github.com/tianocore/edk2-redfish-client/pull/43
>
> Thanks,
> Mike
>
>
> On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike, could you please create a PR for this change? Then I can merge it
> once the change passed CI.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Chang, Abner
> > > Sent: Wednesday, June 21, 2023 8:26 AM
> > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > Cc: nicklew@nvidia.com; igork@ami.com
> > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Reviewed-by: Abner Chang <abner.chang@amd.com>
> > >
> > > > -----Original Message-----
> > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > >
> > > > Caution: This message originated from an External Source. Use proper
> > > caution
> > > > when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > BaseSortLib is the library instance name not the class name.
> > > >
> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > ---
> > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > @@ -25,7 +25,7 @@
> > > >
> > > >
> > > > [LibraryClasses]
> > > >
> > > > BaseLib
> > > >
> > > > - BaseSortLib
> > > >
> > > > + SortLib
> > > >
> > > > DebugLib
> > > >
> > > > MemoryAllocationLib
> > > >
> > > > UefiRuntimeServicesTableLib
> > > >
> > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> b/RedfishPkg/RedfishLibs.dsc.inc
> > > > index 6e497899b556..03b7ef6f3289 100644
> > > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > > @@ -14,7 +14,7 @@
> > > > !if $(REDFISH_ENABLE) == TRUE
> > > >
> > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > > >
> > > >
> Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > > >
> > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > >
> > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > >
> > > >
> RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > >
> > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > > >
> > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > > >
> > > > --
> > > > 2.32.0 (Apple Git-132)
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-30 2:13 ` Chang, Abner
@ 2023-06-30 9:04 ` Mike Maslenkin
2023-06-30 16:15 ` Chang, Abner
0 siblings, 1 reply; 8+ messages in thread
From: Mike Maslenkin @ 2023-06-30 9:04 UTC (permalink / raw)
To: Chang, Abner; +Cc: devel@edk2.groups.io, nicklew@nvidia.com, igork@ami.com
Sorry, I created a PR for the change to edk2-redfish-client but that
depends on this change to edk2.
I created a new PR to edk2 for this patch:
https://github.com/tianocore/edk2/pull/4592
Thanks,
Mike
On Fri, Jun 30, 2023 at 5:13 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> I see there are CI errors for this PR, could you please check it? Thanks!
> Abner
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Friday, June 30, 2023 6:44 AM
> > To: Chang, Abner <Abner.Chang@amd.com>
> > Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> > Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Sure!
> > https://github.com/tianocore/edk2-redfish-client/pull/43
> >
> > Thanks,
> > Mike
> >
> >
> > On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner <Abner.Chang@amd.com>
> > wrote:
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Hi Mike, could you please create a PR for this change? Then I can merge it
> > once the change passed CI.
> > >
> > > Thanks
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: Chang, Abner
> > > > Sent: Wednesday, June 21, 2023 8:26 AM
> > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > > Cc: nicklew@nvidia.com; igork@ami.com
> > > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > >
> > > > Reviewed-by: Abner Chang <abner.chang@amd.com>
> > > >
> > > > > -----Original Message-----
> > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > > >
> > > > > Caution: This message originated from an External Source. Use proper
> > > > caution
> > > > > when opening attachments, clicking links, or responding.
> > > > >
> > > > >
> > > > > BaseSortLib is the library instance name not the class name.
> > > > >
> > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > ---
> > > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > > > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > @@ -25,7 +25,7 @@
> > > > >
> > > > >
> > > > > [LibraryClasses]
> > > > >
> > > > > BaseLib
> > > > >
> > > > > - BaseSortLib
> > > > >
> > > > > + SortLib
> > > > >
> > > > > DebugLib
> > > > >
> > > > > MemoryAllocationLib
> > > > >
> > > > > UefiRuntimeServicesTableLib
> > > > >
> > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> > b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > index 6e497899b556..03b7ef6f3289 100644
> > > > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > @@ -14,7 +14,7 @@
> > > > > !if $(REDFISH_ENABLE) == TRUE
> > > > >
> > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > > > >
> > > > >
> > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > > > >
> > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > >
> > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > >
> > > > >
> > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > >
> > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > > > >
> > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > > > >
> > > > > --
> > > > > 2.32.0 (Apple Git-132)
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-30 9:04 ` Mike Maslenkin
@ 2023-06-30 16:15 ` Chang, Abner
0 siblings, 0 replies; 8+ messages in thread
From: Chang, Abner @ 2023-06-30 16:15 UTC (permalink / raw)
To: Mike Maslenkin; +Cc: devel@edk2.groups.io, nicklew@nvidia.com, igork@ami.com
[AMD Official Use Only - General]
Thanks Mike. CI is running now, I will push it once it passes CI.
Abner
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Friday, June 30, 2023 5:05 PM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Sorry, I created a PR for the change to edk2-redfish-client but that
> depends on this change to edk2.
>
> I created a new PR to edk2 for this patch:
> https://github.com/tianocore/edk2/pull/4592
>
> Thanks,
> Mike
>
> On Fri, Jun 30, 2023 at 5:13 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike,
> > I see there are CI errors for this PR, could you please check it? Thanks!
> > Abner
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Friday, June 30, 2023 6:44 AM
> > > To: Chang, Abner <Abner.Chang@amd.com>
> > > Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> > > Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Sure!
> > > https://github.com/tianocore/edk2-redfish-client/pull/43
> > >
> > > Thanks,
> > > Mike
> > >
> > >
> > > On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner <Abner.Chang@amd.com>
> > > wrote:
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > > Hi Mike, could you please create a PR for this change? Then I can merge it
> > > once the change passed CI.
> > > >
> > > > Thanks
> > > > Abner
> > > >
> > > > > -----Original Message-----
> > > > > From: Chang, Abner
> > > > > Sent: Wednesday, June 21, 2023 8:26 AM
> > > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>;
> devel@edk2.groups.io
> > > > > Cc: nicklew@nvidia.com; igork@ami.com
> > > > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > > >
> > > > > Reviewed-by: Abner Chang <abner.chang@amd.com>
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > > > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > > > > >
> > > > > > Caution: This message originated from an External Source. Use proper
> > > > > caution
> > > > > > when opening attachments, clicking links, or responding.
> > > > > >
> > > > > >
> > > > > > BaseSortLib is the library instance name not the class name.
> > > > > >
> > > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > > ---
> > > > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > > > > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > > @@ -25,7 +25,7 @@
> > > > > >
> > > > > >
> > > > > > [LibraryClasses]
> > > > > >
> > > > > > BaseLib
> > > > > >
> > > > > > - BaseSortLib
> > > > > >
> > > > > > + SortLib
> > > > > >
> > > > > > DebugLib
> > > > > >
> > > > > > MemoryAllocationLib
> > > > > >
> > > > > > UefiRuntimeServicesTableLib
> > > > > >
> > > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> > > b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > index 6e497899b556..03b7ef6f3289 100644
> > > > > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > > > > @@ -14,7 +14,7 @@
> > > > > > !if $(REDFISH_ENABLE) == TRUE
> > > > > >
> > > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > > > > >
> > > > > >
> > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > > > > >
> > > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > > >
> > > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > > > > >
> > > > > >
> > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > > > >
> > > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > > > > >
> > > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > > > > >
> > > > > > --
> > > > > > 2.32.0 (Apple Git-132)
> > > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
2023-06-27 0:05 ` Chang, Abner
2023-06-29 22:43 ` Mike Maslenkin
@ 2023-07-01 3:22 ` Chang, Abner
1 sibling, 0 replies; 8+ messages in thread
From: Chang, Abner @ 2023-07-01 3:22 UTC (permalink / raw)
To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com
[AMD Official Use Only - General]
Hi Mike,
The changes for both RedfishPkg and RedfishClinetPkg were merged. Thanks to your contribution.
Abner
> -----Original Message-----
> From: Chang, Abner
> Sent: Tuesday, June 27, 2023 8:05 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: nicklew@nvidia.com; igork@ami.com
> Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Hi Mike, could you please create a PR for this change? Then I can merge it once
> the change passed CI.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Chang, Abner
> > Sent: Wednesday, June 21, 2023 8:26 AM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: nicklew@nvidia.com; igork@ami.com
> > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > BaseSortLib is the library instance name not the class name.
> > >
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > ---
> > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > > RedfishPkg/RedfishLibs.dsc.inc | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > @@ -25,7 +25,7 @@
> > >
> > >
> > > [LibraryClasses]
> > >
> > > BaseLib
> > >
> > > - BaseSortLib
> > >
> > > + SortLib
> > >
> > > DebugLib
> > >
> > > MemoryAllocationLib
> > >
> > > UefiRuntimeServicesTableLib
> > >
> > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> b/RedfishPkg/RedfishLibs.dsc.inc
> > > index 6e497899b556..03b7ef6f3289 100644
> > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > @@ -14,7 +14,7 @@
> > > !if $(REDFISH_ENABLE) == TRUE
> > >
> > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > >
> > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > >
> > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > >
> > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > >
> > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > >
> > > --
> > > 2.32.0 (Apple Git-132)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-07-01 3:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 21:29 [PATCH] RedfishPkg: Fix SortLib library class name typo Mike Maslenkin
2023-06-21 0:25 ` Chang, Abner
2023-06-27 0:05 ` Chang, Abner
2023-06-29 22:43 ` Mike Maslenkin
2023-06-30 2:13 ` Chang, Abner
2023-06-30 9:04 ` Mike Maslenkin
2023-06-30 16:15 ` Chang, Abner
2023-07-01 3:22 ` Chang, Abner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox