From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by mx.groups.io with SMTP id smtpd.web11.10716.1688078676078062596 for ; Thu, 29 Jun 2023 15:44:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=Uk3XqL6R; spf=pass (domain: gmail.com, ip: 209.85.219.171, mailfrom: mike.maslenkin@gmail.com) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-bd744ffc263so1144567276.3 for ; Thu, 29 Jun 2023 15:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688078675; x=1690670675; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CA5H40tpfqvTZnZGXxTBwnCQBEigPc2YjGBN8QgakR0=; b=Uk3XqL6RZZAdHSP12NVRnaXUlMXXUYFZ94kpHJk2OoCM8w/jhgFDbK2qwjPW/ga693 QTl1l3FuiQTEXF2Q7gjto72VWpma0BIh7UDkZ/lMxZIOhh5J3rEbcEg2iY9ygsTFQmQ3 3h76YlLOlukitIq5bvnpaFru99OXpVgLO6tS3KepLpuS3GPD2KDe0c2t5KfoEQf6OCID JC3CXS3m/qyXxHPIZ6g9VKrSQ9elmrYtxGz6dlAe4sVZR5nxJNUexgs5fk+oqOJMFCiA vBq3VOBOcOWJmk+M5VP3CDW22Zr21XnTcqMc+G7mUpyIyOxAWhec6hklRIk2/TfAzgXV UzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688078675; x=1690670675; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CA5H40tpfqvTZnZGXxTBwnCQBEigPc2YjGBN8QgakR0=; b=BU6GJVpVkHoZWV4CjBpm63yY1gkXOjeMEgOPrIdcAPhy0FrPbdoh0CkaLWFHWHEV6q u9U8wRJeqV8j/ejy0ytzXqHpdGeLOBM574BMb5qfUAKUisQWmKMeLbC8rYwsGBSXZE6l 1iAW7wKH30JBnfOk7whiuXLfEKwVpyaPSQJ9ox3RgawqgFCoQb9m4wEvA+qcx5WzvK60 Ge0wknOuKTqucd+NbEHg57XyMToy5g5q6YL3i9Mv0P0trq2bE3kzi1o14ioB2oT+PdAm Kl8fESifJqYfbnR/7wV4nxSAd2tDNuo8EJQCLR6eTC5L+nPZRs9v2Mt2Tt4+1z2+Ku/l Oqtg== X-Gm-Message-State: ABy/qLYCOcSRsF4LxvgJyEgcnZPooYQKiDJ+keGWrIJDhBqnG9l1M5so R+ICE3CBou1xL+yThNzhAjgO2rSx1EY/4BWB2NI= X-Google-Smtp-Source: APBJJlEy8AC3gJmFy588wIpABWfy471rLN04B8Oo8GwTTm2ZC5tW1DEMoEPRnkR+5wYtpEwdawxhFlvnDCHNU+9FJPE= X-Received: by 2002:a25:b009:0:b0:c41:3f7d:ea8e with SMTP id q9-20020a25b009000000b00c413f7dea8emr178017ybf.56.1688078675197; Thu, 29 Jun 2023 15:44:35 -0700 (PDT) MIME-Version: 1.0 References: <20230620212950.28118-1-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Fri, 30 Jun 2023 01:43:59 +0300 Message-ID: Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo. To: "Chang, Abner" Cc: "devel@edk2.groups.io" , "nicklew@nvidia.com" , "igork@ami.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sure! https://github.com/tianocore/edk2-redfish-client/pull/43 Thanks, Mike On Tue, Jun 27, 2023 at 3:05=E2=80=AFAM Chang, Abner = wrote: > > [AMD Official Use Only - General] > > Hi Mike, could you please create a PR for this change? Then I can merge i= t once the change passed CI. > > Thanks > Abner > > > -----Original Message----- > > From: Chang, Abner > > Sent: Wednesday, June 21, 2023 8:26 AM > > To: Mike Maslenkin ; devel@edk2.groups.io > > Cc: nicklew@nvidia.com; igork@ami.com > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > Reviewed-by: Abner Chang > > > > > -----Original Message----- > > > From: Mike Maslenkin > > > Sent: Wednesday, June 21, 2023 5:30 AM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner ; nicklew@nvidia.com; > > > igork@ami.com; Mike Maslenkin > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > > > Caution: This message originated from an External Source. Use proper > > caution > > > when opening attachments, clicking links, or responding. > > > > > > > > > BaseSortLib is the library instance name not the class name. > > > > > > Signed-off-by: Mike Maslenkin > > > Cc: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > --- > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +- > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.in= f > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > index 5c1c7cffa650..6ff5dba75c30 100644 > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > @@ -25,7 +25,7 @@ > > > > > > > > > [LibraryClasses] > > > > > > BaseLib > > > > > > - BaseSortLib > > > > > > + SortLib > > > > > > DebugLib > > > > > > MemoryAllocationLib > > > > > > UefiRuntimeServicesTableLib > > > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.= dsc.inc > > > index 6e497899b556..03b7ef6f3289 100644 > > > --- a/RedfishPkg/RedfishLibs.dsc.inc > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc > > > @@ -14,7 +14,7 @@ > > > !if $(REDFISH_ENABLE) =3D=3D TRUE > > > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf > > > > > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLi= b.inf > > > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf > > > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf > > > > > > -- > > > 2.32.0 (Apple Git-132) >