From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83761D8042B for ; Sun, 29 Oct 2023 13:58:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BeezBERV+BYY/KYUy1sKPLKj5DCf1zEgIaxQKoVmQwg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698587888; v=1; b=tJt9/9CjaOBeR/zKSXPHOPOjAcAUHr3m1NfrDJG8C54ZyGT9uGXkn1yPiX3z6MQw1A8QI0Uq 6lN8Nuiq7ubVqZYZIGe5pH/0tNSHnKLE7OdRbNJV8mPO2UO4FbdHXx8L+zrkc52j6aDgj0ZKYfy BaMgrHG5qmHo+niH8Brnm0TU= X-Received: by 127.0.0.2 with SMTP id ZtTLYY7687511xdR12nmzgBO; Sun, 29 Oct 2023 06:58:08 -0700 X-Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by mx.groups.io with SMTP id smtpd.web10.72499.1698587887357181811 for ; Sun, 29 Oct 2023 06:58:07 -0700 X-Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-579de633419so31536937b3.3 for ; Sun, 29 Oct 2023 06:58:07 -0700 (PDT) X-Gm-Message-State: YDfvzXWVvZDqAm02ZHSGbrtDx7686176AA= X-Google-Smtp-Source: AGHT+IEV70sf47QBuE6uyL2Wt10kILWcWvU/zn+8UVCDkzzIDR+HFfA3IE5i4nWOT5AxVwPt4AihKfkSxCuiZX7VjUc= X-Received: by 2002:a81:a941:0:b0:5a7:ba17:584b with SMTP id g62-20020a81a941000000b005a7ba17584bmr7077417ywh.1.1698587886363; Sun, 29 Oct 2023 06:58:06 -0700 (PDT) MIME-Version: 1.0 References: <20231023141732.152-1-nicklew@nvidia.com> In-Reply-To: From: "Mike Maslenkin" Date: Sun, 29 Oct 2023 16:57:30 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions. To: Nickle Wang Cc: "devel@edk2.groups.io" , Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="tJt9/9Cj"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Wed, Oct 25, 2023 at 3:40=E2=80=AFPM Nickle Wang wr= ote: > > > double declaration of 'strcpy' is still there. > > Thanks for catching this, Mike. Version 2 patch file was sent. > > Regards, > Nickle Hello, Nickle v2 is good enough, but it can be improved a bit. Since the definitions in this header file have become clearer and simpler, It now appears that memcmp and memmove declarations can also be removed. The logic is that we don't need to declare function prototypes for those that are overridden at the bottom of this header file. If there were such functions in the code, the linking process would fail, but there should not be such functions, since their names are replaced by the preprocessor according to the definitions. Regards, Mike. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110260): https://edk2.groups.io/g/devel/message/110260 Mute This Topic: https://groups.io/mt/102136148/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-