From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 119F0AC0D5E for ; Mon, 4 Dec 2023 07:18:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZqYLe78ISAzfrAjuAK9qfRk/TzfK5GIOaB/Vx78a1FU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701674327; v=1; b=lY16jKz/vgHZ107MD+cr+4ENl3OaaXbRjddc7M6YQk6yGlWjWQ3IQKdNf+z6U8YWs+tDTOiY YiLxpZ1sZ8fnjdE7GMGReasLXqBO55aZ7KujEsbuwllYU+DOwCLZr3z0afiBF9IqXLawbrUSrec nzm8jfK9dLs9rUP/812N2IGE= X-Received: by 127.0.0.2 with SMTP id 4UqwYY7687511xObMIYxLtpi; Sun, 03 Dec 2023 23:18:47 -0800 X-Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by mx.groups.io with SMTP id smtpd.web10.64283.1701674327164542124 for ; Sun, 03 Dec 2023 23:18:47 -0800 X-Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5d3644ca426so37379797b3.1 for ; Sun, 03 Dec 2023 23:18:47 -0800 (PST) X-Gm-Message-State: ewL2e3Hp2JAxD8uO7YocNVPsx7686176AA= X-Google-Smtp-Source: AGHT+IG5b1G+Ls3YvHUf+7mKZx3fS0joYotH+Q4GQ3mswgWEO9ZyVStajgk7c/D9UaYMG4VhTT3wkGsvQOihvaJYZb4= X-Received: by 2002:a81:ad53:0:b0:5d6:d25b:6dc9 with SMTP id l19-20020a81ad53000000b005d6d25b6dc9mr2089764ywk.25.1701674326360; Sun, 03 Dec 2023 23:18:46 -0800 (PST) MIME-Version: 1.0 References: <20231127053107.1686-1-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-1-abner.chang@amd.com> From: "Mike Maslenkin" Date: Mon, 4 Dec 2023 10:18:10 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement To: abner.chang@amd.com Cc: devel@edk2.groups.io, Nickle Wang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="lY16jKz/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Nov 27, 2023 at 8:31=E2=80=AFAM wrote: > > From: Abner Chang > > In V3: Address Mike's comments to V2. > > In V2: Send additional two patches those are missed > in V1. > > This patch set updates the algorithm of BMC USB > NIC discovery and fixes some bugs. > > - Add a new protocol to trigger the notification > of Redfish Host Interface readiness. > This fixes the issue Redfish config handler driver > acquires Redfish service before Redfish Host > Interface is published. > - Add more error debug messages. > - Address some minor issues > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > > Abner Chang (9): > RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm > RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness > notification > RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification > RedfishPkg/RedfishConfigHandler: Correct the prototype of callback > function > RedfishPkg/RedfishDiscovery: Add more debug message > RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC > address pointer > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record > size > RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption > issue > > RedfishPkg/RedfishPkg.dec | 3 + > .../RedfishConfigHandlerDriver.inf | 9 +- > .../RedfishHostInterfaceDxe.inf | 3 +- > .../RedfishDiscoverInternal.h | 2 + > .../PlatformHostInterfaceBmcUsbNicLib.c | 196 ++++++++++++------ > .../RedfishConfigHandlerDriver.c | 170 +++++++++------ > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 ++ > .../RedfishSmbiosHostInterface.c | 20 +- > .../RedfishHostInterfaceDxe.c | 18 ++ > 9 files changed, 315 insertions(+), 129 deletions(-) > > -- > 2.37.1.windows.1 > Looks good to me. Thank you. Regards, Mike -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112012): https://edk2.groups.io/g/devel/message/112012 Mute This Topic: https://groups.io/mt/102824306/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-