From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DAAE274003B for ; Mon, 28 Aug 2023 23:19:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=a/KtO3qYajyfY3BWlhsZXzMy5xoMdid0kiCu9ZcpJKk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693264753; v=1; b=EJGQV8wnk2D7YNBdcvsiVvv4p5l9WxZuONIgHoeVf4/BirWNRyFDFg37HPITRTOHMo4krkc0 X6QT1+iiDGyoko7bv7RxDuyc7f17oHLdJZLX+ka1iME4pDV/2129jU5Y760N3d9DwZ5MOpAqQK6 qjeleOPy1+T9sx+wGZj8gmrA= X-Received: by 127.0.0.2 with SMTP id 0GbLYY7687511xXOw1HrShmA; Mon, 28 Aug 2023 16:19:13 -0700 X-Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by mx.groups.io with SMTP id smtpd.web11.5957.1693264752835354086 for ; Mon, 28 Aug 2023 16:19:13 -0700 X-Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-48d0dbd62fbso1009642e0c.0 for ; Mon, 28 Aug 2023 16:19:12 -0700 (PDT) X-Gm-Message-State: h3sSAGDQBhbou3nfMUBC7gVRx7686176AA= X-Google-Smtp-Source: AGHT+IF3c7fa3u2FTOu+oRH6/nlz5TF9pbhETgmZpviUvi/JFUZ88sEmeI8cL8lcshAhDSmi8zVu3+Z4tlkq7NPbwS4= X-Received: by 2002:a1f:ed43:0:b0:48f:895f:45da with SMTP id l64-20020a1fed43000000b0048f895f45damr18108029vkh.14.1693264751745; Mon, 28 Aug 2023 16:19:11 -0700 (PDT) MIME-Version: 1.0 References: <20230827105640.94731-1-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Tue, 29 Aug 2023 02:18:35 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables. To: devel@edk2.groups.io, nicklew@nvidia.com Cc: "abner.chang@amd.com" , "igork@ami.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EJGQV8wn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Nickle, I incorporated changes required for uncrustify check. Also I added additional patch with trivial spelling fixes. Do I need to resend v.2 to the list? Regards, Mike. On Mon, Aug 28, 2023 at 12:03=E2=80=AFPM Nickle Wang via groups.io wrote: > > Hi Mike, > > > I didn't find any codyng-style issues in uncrustify output. > > I fetch your branch and run uncrustify tool to fix error in vs code edito= r. I push the fix to your branch at this commit for your reference: https:/= /github.com/ghbaccount/edk2-redfish-client/commit/f22209f7bd5946168326a3197= 006d92856247d35 The uncrustify check on PR is now passed successfully. My c= ommit breaks patch check as expected, please incorporate my changes with yo= urs and do a force push to this PR again. > > For the way of fixing uncrustify error, I am using the instructions here:= https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatti= ng#recommended-usage-visual-studio-vs-code-plugin > > Thanks, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Sunday, August 27, 2023 6:57 PM > > To: devel@edk2.groups.io > > Cc: abner.chang@amd.com; Nickle Wang ; > > igork@ami.com; Mike Maslenkin > > Subject: [PATCH 0/5] RedfishClientPkg: fix issues with local variables. > > > > External email: Use caution opening links or attachments > > > > > > This patchset contains fixes that resolve crashes while working with un= initialized > > variables and a number of fixes for of leaked memory. > > Note: looks like uncrustify check is broken at tianocore/edk2-redfish-c= lient repo, > > the corresponding PR failed: > > https://github.co/ > > m%2Ftianocore%2Fedk2-redfish- > > client%2Fpull%2F46&data=3D05%7C01%7Cnicklew%40nvidia.com%7C7cf336153fb > > f4e2e821008dba6ec62e0%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > > %7C638287306436105158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C > > &sdata=3DVUxJA017msZzRYd%2FAxi0KeZvLi2s0QI6uKgHsOuDdws%3D&reserved=3D0 > > > > I didn't find any codyng-style issues in uncrustify output. > > > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > Signed-off-by: Mike Maslenkin > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108071): https://edk2.groups.io/g/devel/message/108071 Mute This Topic: https://groups.io/mt/100988470/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-