From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2CB5FD8027A for ; Tue, 26 Mar 2024 21:19:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/8U4yk+FMbns2Okh6dC3alkGe1zOBfdg2jZ/aGucb2o=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711487951; v=1; b=do4G8NrOHIdgW7D6ks7+pI9zgCCgtp3Y1VOuVWoO/eWByiOQC4bNDl3sRpsxkK+5v+hoo9+Z YN6gKbmni4U4mLGtAnZexBTi6hviziuJa8s/qzSoJPm0pjqiXZtLYOgWVWNODQ6xV4MbrzlvC6H 9f2Y1noZjlhhF3dnpKOVBTgZl8ahAZT9LoZ+XpKChs3OA6WyUI00fFjKVTYshYkRbMBWgRhil8Y oe6TChrmN7bdIRmAB6Y+kSGMTdO9A9+cTDaPNu5EpjtY6GY/ohZ8FfoZ5hj/oTMHmWCPbXt4cMd U7wyIDjeNgKzySMDQ00MTKF6kuq2QAqo1aB7MMmzxpD1A== X-Received: by 127.0.0.2 with SMTP id KDcVYY7687511xxNH0vzVmhm; Tue, 26 Mar 2024 14:19:11 -0700 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.22449.1711487950733816226 for ; Tue, 26 Mar 2024 14:19:11 -0700 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-513ccc70a6dso10500519e87.1 for ; Tue, 26 Mar 2024 14:19:10 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXqeCj96i9SVQhlf8Ja2uClIXjmcTth9mS3Os/ooEQuj8uxBEyGjBd6ahst8hReZoOevozOJrPttDY5fiMeYXLP8cWxLQ== X-Gm-Message-State: e48gppACZ8IJCioQAXBFyKHox7686176AA= X-Google-Smtp-Source: AGHT+IHf8oydCz3ZZpdvBAuk1xSYtW7uLiDMZrjdNy0XvvWrJkkeHSx+IRH8cyQGbOiR3LvlJAujKmOwusAfC9nxsTs= X-Received: by 2002:ac2:4990:0:b0:513:dc7c:4956 with SMTP id f16-20020ac24990000000b00513dc7c4956mr655761lfl.48.1711487948564; Tue, 26 Mar 2024 14:19:08 -0700 (PDT) MIME-Version: 1.0 References: <20240323120050.53834-1-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Wed, 27 Mar 2024 00:18:32 +0300 Message-ID: Subject: Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex() To: Nickle Wang Cc: "Chang, Abner" , "devel@edk2.groups.io" , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 14:19:11 -0700 Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=do4G8NrO; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Hi, I have updated patches with R-b and pushed it to PR https://github.com/tianocore/edk2-redfish-client/pull/85 Thank you for the review! Regards, Mike On Tue, Mar 26, 2024 at 4:41=E2=80=AFPM Nickle Wang wr= ote: > > Thanks for your reminder, Abner. I verify this patch series on my system,= and I don't see any issue. > > > > Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit mes= sages. And we can merge the pull request. > > > > Thanks, > > Nickle > > > > > -----Original Message----- > > > From: Chang, Abner > > > Sent: Monday, March 25, 2024 10:13 AM > > > To: Mike Maslenkin ; devel@edk2.groups.io > > > Cc: Igor Kulchytskyy ; Nickle Wang > > > Subject: RE: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix > > > GetRedpathNodeByIndex() > > > > > > External email: Use caution opening links or attachments > > > > > > > > > [AMD Official Use Only - General] > > > > > > For this patch set, Reviewed-by: Abner Chang > > > > > > Hi Nickle, please also take a look at this change. Thanks Abner > > > > > > > -----Original Message----- > > > > From: Mike Maslenkin > > > > Sent: Saturday, March 23, 2024 8:01 PM > > > > To: devel@edk2.groups.io > > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > > ; Nickle Wang ; Mike Maslenkin > > > > > > > > Subject: [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix > > > > GetRedpathNodeByIndex() > > > > > > > > Caution: This message originated from an External Source. Use proper > > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > > > > This set contains fixes for proper nodes handling in GetRedpathNodeBy= Index(). > > > > It fixes handling of nodes with Index different from 0, it removes > > > > leading '/' returned for section with Index =3D 0, also it fixes retu= rn > > > > of the last section. > > > > > > This set does not have any impact to > > > > existing code, > > > > because in all places this function is used to obtain the end of the = first section. > > > > And actually returned pointer to the requested section is not used. > > > > The current usages is: > > > > GetRedpathNodeByIndex (ConfigLangList.List[0].ConfigureLang, 0, > > > > &EndOfChar); > > > > > > > > and return of EndOfChar value is not affected by this set. > > > > > > > > Cc: Abner Chang > > > > Cc: Igor Kulchytskyy > > > > Cc: Nickle Wang > > > > Signed-off-by: Mike Maslenkin > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117141): https://edk2.groups.io/g/devel/message/117141 Mute This Topic: https://groups.io/mt/105101990/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-