From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F105A941A24 for ; Wed, 28 Feb 2024 17:56:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=k25hQVtqlfZwZJLtNztreSiQLozBMMdxPbymMHVLwwY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709143005; v=1; b=vzDKNuB+LzuObuSnE793zKeMoX7xkQEJPsgG7AMbqmGvEv1fDb71vhaZX86aZcKk/INDwlDZ +v4Pfr5dsl86aHqp6TRdM/r+t9pLAYGBogQyObzy8gqcu7qq3hJ+GQwJOZWE9GXmlLK7pjhA8Io OsEMIkMyOsE7DOCjoiB2PzOw= X-Received: by 127.0.0.2 with SMTP id tFigYY7687511x4lDsCzV2hX; Wed, 28 Feb 2024 09:56:45 -0800 X-Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by mx.groups.io with SMTP id smtpd.web10.3572.1709143004831345452 for ; Wed, 28 Feb 2024 09:56:44 -0800 X-Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-dcc6fc978ddso27775276.0 for ; Wed, 28 Feb 2024 09:56:44 -0800 (PST) X-Gm-Message-State: CxAK3HOfSx3UkRjgtC200EOux7686176AA= X-Google-Smtp-Source: AGHT+IEWXCZXuobomHy2dAOZOK2jYSYBdcZjjT1nF5B4QvfSatbvOvF+IB43WCr1CpqiKml6NhXsB1O6VIv//42vO3c= X-Received: by 2002:a25:3587:0:b0:dcf:299e:559e with SMTP id c129-20020a253587000000b00dcf299e559emr2447917yba.4.1709143003947; Wed, 28 Feb 2024 09:56:43 -0800 (PST) MIME-Version: 1.0 References: <20240222091122.644-1-nicklew@nvidia.com> <9A76E719-1472-4E4C-A480-B38C7D305AAF@gmail.com> <17B791D5F1D9AF42.14830@groups.io> In-Reply-To: From: "Mike Maslenkin" Date: Wed, 28 Feb 2024 20:56:07 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol To: Nickle Wang Cc: "devel@edk2.groups.io" , Igor Kulchytskyy , Abner Chang , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vzDKNuB+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Feb 28, 2024 at 2:47=E2=80=AFPM Nickle Wang wr= ote: > > Hi @Mike Maslenkin, > > > > May I have your reviewed-by if version 3 patch set look good to you? > Sure! Reviewed-by: Mike Maslenkin BTW I'm just curious, there is a mention in patch 2 "We currently only support gzip Content-Encoding." But I didn't see any implementation of gzip coding/encoding for edk2. Do you know of any? I hope you know that patch 5 breaks edk2-redfish-client compilation (Instance of library class [RedfishHttpLib] is not found) But I understand these changes are not atomic for edk2 and edk2-redfish-cli= ent. Regards, Mike. > > > Thanks, > > Nickle > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Nickle W= ang > > > via groups.io > > > Sent: Tuesday, February 27, 2024 8:49 AM > > > To: Mike Maslenkin > > > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Abner Chang > > > ; Nick Ramirez > > > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish = HTTP > > > protocol > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Thanks for your confirmation, Mike! > > > > > > Version 3 patch set is here: https://edk2.groups.io/g/devel/message/115= 985 > > > > > > Regards, > > > Nickle > > > > > > > -----Original Message----- > > > > From: Mike Maslenkin > > > > Sent: Tuesday, February 27, 2024 8:13 AM > > > > To: Nickle Wang > > > > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Abner > > > > Chang ; Nick Ramirez > > > > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfis= h > > > > HTTP protocol > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > Hii Nickle, > > > > > > > > > > > > On Mon, Feb 26, 2024 at 4:44=E2=80=AFPM Nickle Wang wrote: > > > > > > > > > > Hi Mike, > > > > > > > > > > > So finally we have > > > > > > HttpFreeHeaderFields (Response->Headers, Response->HeaderCount); > > > > > > but > > > > > > Response->HeaderCount does not count partially allocated elements= . Right? > > > > > > > > > > > > To fix this, it is required to set *DstHeaderCount =3D > > > > > > SrcHeaderCount unconditionally right after DstHeaders allocation= , > > > > > > and HttpFreeHeaderFields() will do the work then. > > > > > > > > > > I follow your suggestion to update DstHeaderCount right after > > > > > DstHeaders is > > > > allocated. So, HttpFreeHeaderFields can release headers correctly. I > > > > also create a macro to implemented AsciiStrCpy. Please check below li= nk to see > > > my changes: > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fgi > > > > > th > > > > > > > > > > > > ub.com%2Ftianocore%2Fedk2%2Fcompare%2F0f391b1c2f988d90a3ac723b314a > > > > c28b > > > > > > > > > > > > a7b0b8df..f0fa1b8fdcd933beb52fd3127c2476443c00ef8d&data=3D05%7C02%7Cnic > > > > k > > > > > > > > > > > > lew%40nvidia.com%7Cf3870f71360e44f3b4e208dc3728ff87%7C43083d1572734 > > > > 0c1 > > > > > > > > > > > > b7db39efd9ccc17a%7C0%7C0%7C638445896465360452%7CUnknown%7CTWFp > > > > bGZsb3d8 > > > > > > > > > > > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D% > > > > 7C0 > > > > > > > > > > > > %7C%7C%7C&sdata=3DK%2FEA2QWpk%2F8NHQ1QhzqkvQqao4db%2BILn1Jt%2BB > > > > qQ5n1E%3D > > > > > &reserved=3D0 > > > > > > > > These changes looks good. Internal strings > > > > initialization/deinitialization code much cleaner now and possible le= ak seems to > > > have been fixed. > > > > > > > > Thank you! > > > > > > > > Regards, > > > > Mike. > > > > > > > > >=20 > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116126): https://edk2.groups.io/g/devel/message/116126 Mute This Topic: https://groups.io/mt/104505404/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-