Re: [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename RedfishResourceIdentifyLibComuterSystem

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

Pull request is ready: https://github.com/tianocore/edk2-redfish-client/pull/44

Regards,
Mike.


On Wed, Jul 5, 2023 at 5:46 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
>
> Thanks for catching this, all good except the [RFC] tag in the subject. 😊
> Abner
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Tuesday, July 4, 2023 6:36 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > Subject: [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename
> > RedfishResourceIdentifyLibComuterSystem
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > This patch fixes misprint in name of a directory and its files.
> > The name of these files should be
> > RedfishResourceIdentifyLibComputerSystem
> > as well as implemented library instance.
> >
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > ---
> >
> > There is no history for this library in the new repo, so this misprint can
> > be easily fixed. I found this issue during RedfishClientPkg investigation.
> > I missed this library while I was grepping sources.
> > Here is a PR https://github.com/tianocore/edk2-redfish-client/pull/44
> > All checks have passed.
> >
> > ---
> >  .../v1_5_0/RedfishResourceIdentifyLibComputerSystem.c}      | 2 +-
> >  .../v1_5_0/RedfishResourceIdentifyLibComputerSystem.inf}    | 6 +++---
> >  RedfishClientPkg/RedfishClientComponents.dsc.inc            | 2 +-
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> >  rename
> > RedfishClientPkg/Library/{RedfishResourceIdentifyLibComuterSystem/v1_5_
> > 0/RedfishResourceIdentifyLibComuterSystem.c =>
> > RedfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentif
> > yLibComputerSystem.c} (95%)
> >  rename
> > RedfishClientPkg/Library/{RedfishResourceIdentifyLibComuterSystem/v1_5_
> > 0/RedfishResourceIdentifyLibComuterSystem.inf =>
> > RedfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentif
> > yLibComputerSystem.inf} (82%)
> >
> > diff --git
> > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5
> > _0/RedfishResourceIdentifyLibComuterSystem.c
> > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_
> > 5_0/RedfishResourceIdentifyLibComputerSystem.c
> > similarity index 95%
> > rename from
> > RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5_0
> > /RedfishResourceIdentifyLibComuterSystem.c
> > rename to
> > RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_5_
> > 0/RedfishResourceIdentifyLibComputerSystem.c
> > index 1e9c181aa61a..29b4f525d5ff 100644
> > ---
> > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5
> > _0/RedfishResourceIdentifyLibComuterSystem.c
> > +++
> > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_
> > 5_0/RedfishResourceIdentifyLibComputerSystem.c
> > @@ -144,7 +144,7 @@ RestJasonStructureProtocolIsReady (
> >  **/
> >
> >  EFI_STATUS
> >
> >  EFIAPI
> >
> > -RedfishResourceIdentifyComuterSystemConstructor (
> >
> > +RedfishResourceIdentifyComputerSystemConstructor (
> >
> >    IN EFI_HANDLE        ImageHandle,
> >
> >    IN EFI_SYSTEM_TABLE  *SystemTable
> >
> >    )
> >
> > diff --git
> > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5
> > _0/RedfishResourceIdentifyLibComuterSystem.inf
> > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_
> > 5_0/RedfishResourceIdentifyLibComputerSystem.inf
> > similarity index 82%
> > rename from
> > RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5_0
> > /RedfishResourceIdentifyLibComuterSystem.inf
> > rename to
> > RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_5_
> > 0/RedfishResourceIdentifyLibComputerSystem.inf
> > index ae269b58496e..2bbe20c3c51f 100644
> > ---
> > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5
> > _0/RedfishResourceIdentifyLibComuterSystem.inf
> > +++
> > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_
> > 5_0/RedfishResourceIdentifyLibComputerSystem.inf
> > @@ -8,19 +8,19 @@
> >
> >
> >  [Defines]
> >
> >    INF_VERSION                    = 0x00010006
> >
> > -  BASE_NAME                      = RedfishResourceIdentifyLibComuterSystem
> >
> > +  BASE_NAME                      = RedfishResourceIdentifyLibComputerSystem
> >
> >    FILE_GUID                      = 2AEE2C80-126A-44A6-877E-642F20510D13
> >
> >    MODULE_TYPE                    = DXE_DRIVER
> >
> >    VERSION_STRING                 = 1.0
> >
> >    LIBRARY_CLASS                  = RedfishResourceIdentifyLib| DXE_DRIVER
> >
> > -  CONSTRUCTOR                    =
> > RedfishResourceIdentifyComuterSystemConstructor
> >
> > +  CONSTRUCTOR                    =
> > RedfishResourceIdentifyComputerSystemConstructor
> >
> >
> >
> >  #
> >
> >  #  VALID_ARCHITECTURES           = IA32 X64 EBC
> >
> >  #
> >
> >
> >
> >  [Sources]
> >
> > -  RedfishResourceIdentifyLibComuterSystem.c
> >
> > +  RedfishResourceIdentifyLibComputerSystem.c
> >
> >
> >
> >  [Packages]
> >
> >    MdePkg/MdePkg.dec
> >
> > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc
> > b/RedfishClientPkg/RedfishClientComponents.dsc.inc
> > index fc54787dbdbc..0e27198afbb4 100644
> > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc
> > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc
> > @@ -28,7 +28,7 @@
> >    RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf
> >
> >
> > RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemD
> > xe.inf {
> >
> >      <LibraryClasses>
> >
> > -
> > RedfishResourceIdentifyLib|RedfishClientPkg/Library/RedfishResourceIdentif
> > yLibComuterSystem/v1_5_0/RedfishResourceIdentifyLibComuterSystem.inf
> >
> > +
> > RedfishResourceIdentifyLib|RedfishClientPkg/Library/RedfishResourceIdentif
> > yLibComputerSystem/v1_5_0/RedfishResourceIdentifyLibComputerSystem.in
> > f
> >
> >    }
> >
> >
> > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystem
> > CollectionDxe.inf
> >
> >    RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.inf
> >
> > --
> > 2.32.0 (Apple Git-132)
>