From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by mx.groups.io with SMTP id smtpd.web11.8555.1688720885815103109 for ; Fri, 07 Jul 2023 02:08:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=A+CoZb4L; spf=pass (domain: gmail.com, ip: 209.85.128.172, mailfrom: mike.maslenkin@gmail.com) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-577412111f0so21601987b3.0 for ; Fri, 07 Jul 2023 02:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688720885; x=1691312885; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SK97jQr9pkVWpu9zZ0MhEldyB/azfe/rHFprN9ZEVXc=; b=A+CoZb4LdMzCSGN1dpG+uTGL49h8tJdAL55Qf0FgILb7cXxQDhVHM8U42Ixl4/1krz vnVT4fRkRw2QQK9TVrXzKdHNYYH0FPNoR3qCLjRT5lteIhnX0Ezl5dv+eXLZdw9Qr4OS eigdO7mnn17PmLdcP9gUX1m47N8OMelHHbRTKaYPijCUs8rWCj/wea1fFiSV399O/Uza uOnkaJq1tDGKAC1c/f8O17PTZIPg9h7kh7OPlN7vl/AKKpWv1QfKu5nm/J7jbLWqXGRs fueCZ2JYG9wkd5Aph/O3hs3sPLzHsRGyLmfNDUQ1Ld0CT4IQUvWhJOs6wVMHrWxy71Ao VUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688720885; x=1691312885; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SK97jQr9pkVWpu9zZ0MhEldyB/azfe/rHFprN9ZEVXc=; b=VL6s/UpctcAytnRZzYr3Jtot2nZ2D1+mDTYj73v8h3KkntcwtmQgHljkjjnzTTzHHu vNPYFrOTHzhVqvrNEtRNld15pJMBcyS+JrT82ASns/etNRgyjhwfvFoo3ewD5+p8TqZd 2bCWsDcQi/QOlKfOXhXo3Mq7mzWS5lO9YY5Y74NVFgaEuWtelLAjTW4GtADJMsRzkt7x m+KliC23xtoqeumUJCkw+elUIHKvPGsbDAx1+/+3bdEojabuF9p8Ux4ijAsu8/AxWhzA ucGnrkoVqKpUdR0OvhVC4y7Lq87GkjDJhYWeQgx4PafkK+faDQ3wGTcLCsU6M6oZ3V8X F4aQ== X-Gm-Message-State: ABy/qLagiMcnokIOMn8N8q7eVlIfAxKYeQjfHf5ngCpLQenDv3hgjkyg TushYvIrYA9ZNw9oXOGHzK05Z4ZKOeCcQTDgFtg= X-Google-Smtp-Source: APBJJlGFzJXe0YhZQRNd+Otza+Ta/cWk4G814PtZXY5GHAtHtE8kI9O6DBX29e1dRYFCgDAPaMnlOzuu7cDtJlDR8Zg= X-Received: by 2002:a81:6184:0:b0:570:6fbd:2daf with SMTP id v126-20020a816184000000b005706fbd2dafmr6122206ywb.37.1688720884874; Fri, 07 Jul 2023 02:08:04 -0700 (PDT) MIME-Version: 1.0 References: <20230703223624.63853-1-mike.maslenkin@gmail.com> In-Reply-To: From: "Mike Maslenkin" Date: Fri, 7 Jul 2023 12:07:28 +0300 Message-ID: Subject: Re: [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename RedfishResourceIdentifyLibComuterSystem To: "Chang, Abner" Cc: "devel@edk2.groups.io" , "nicklew@nvidia.com" , "igork@ami.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pull request is ready: https://github.com/tianocore/edk2-redfish-client/pul= l/44 Regards, Mike. On Wed, Jul 5, 2023 at 5:46=E2=80=AFAM Chang, Abner w= rote: > > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang > > Thanks for catching this, all good except the [RFC] tag in the subject. = =F0=9F=98=8A > Abner > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Tuesday, July 4, 2023 6:36 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nicklew@nvidia.com; > > igork@ami.com; Mike Maslenkin > > Subject: [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename > > RedfishResourceIdentifyLibComuterSystem > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > This patch fixes misprint in name of a directory and its files. > > The name of these files should be > > RedfishResourceIdentifyLibComputerSystem > > as well as implemented library instance. > > > > Signed-off-by: Mike Maslenkin > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > --- > > > > There is no history for this library in the new repo, so this misprint = can > > be easily fixed. I found this issue during RedfishClientPkg investigati= on. > > I missed this library while I was grepping sources. > > Here is a PR https://github.com/tianocore/edk2-redfish-client/pull/44 > > All checks have passed. > > > > --- > > .../v1_5_0/RedfishResourceIdentifyLibComputerSystem.c} | 2 +- > > .../v1_5_0/RedfishResourceIdentifyLibComputerSystem.inf} | 6 +++--- > > RedfishClientPkg/RedfishClientComponents.dsc.inc | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > rename > > RedfishClientPkg/Library/{RedfishResourceIdentifyLibComuterSystem/v1_5_ > > 0/RedfishResourceIdentifyLibComuterSystem.c =3D> > > RedfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentif > > yLibComputerSystem.c} (95%) > > rename > > RedfishClientPkg/Library/{RedfishResourceIdentifyLibComuterSystem/v1_5_ > > 0/RedfishResourceIdentifyLibComuterSystem.inf =3D> > > RedfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentif > > yLibComputerSystem.inf} (82%) > > > > diff --git > > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5 > > _0/RedfishResourceIdentifyLibComuterSystem.c > > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_ > > 5_0/RedfishResourceIdentifyLibComputerSystem.c > > similarity index 95% > > rename from > > RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5_0 > > /RedfishResourceIdentifyLibComuterSystem.c > > rename to > > RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_5_ > > 0/RedfishResourceIdentifyLibComputerSystem.c > > index 1e9c181aa61a..29b4f525d5ff 100644 > > --- > > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5 > > _0/RedfishResourceIdentifyLibComuterSystem.c > > +++ > > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_ > > 5_0/RedfishResourceIdentifyLibComputerSystem.c > > @@ -144,7 +144,7 @@ RestJasonStructureProtocolIsReady ( > > **/ > > > > EFI_STATUS > > > > EFIAPI > > > > -RedfishResourceIdentifyComuterSystemConstructor ( > > > > +RedfishResourceIdentifyComputerSystemConstructor ( > > > > IN EFI_HANDLE ImageHandle, > > > > IN EFI_SYSTEM_TABLE *SystemTable > > > > ) > > > > diff --git > > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5 > > _0/RedfishResourceIdentifyLibComuterSystem.inf > > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_ > > 5_0/RedfishResourceIdentifyLibComputerSystem.inf > > similarity index 82% > > rename from > > RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5_0 > > /RedfishResourceIdentifyLibComuterSystem.inf > > rename to > > RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_5_ > > 0/RedfishResourceIdentifyLibComputerSystem.inf > > index ae269b58496e..2bbe20c3c51f 100644 > > --- > > a/RedfishClientPkg/Library/RedfishResourceIdentifyLibComuterSystem/v1_5 > > _0/RedfishResourceIdentifyLibComuterSystem.inf > > +++ > > b/RedfishClientPkg/Library/RedfishResourceIdentifyLibComputerSystem/v1_ > > 5_0/RedfishResourceIdentifyLibComputerSystem.inf > > @@ -8,19 +8,19 @@ > > > > > > [Defines] > > > > INF_VERSION =3D 0x00010006 > > > > - BASE_NAME =3D RedfishResourceIdentifyLibComuter= System > > > > + BASE_NAME =3D RedfishResourceIdentifyLibCompute= rSystem > > > > FILE_GUID =3D 2AEE2C80-126A-44A6-877E-642F20510= D13 > > > > MODULE_TYPE =3D DXE_DRIVER > > > > VERSION_STRING =3D 1.0 > > > > LIBRARY_CLASS =3D RedfishResourceIdentifyLib| DXE_D= RIVER > > > > - CONSTRUCTOR =3D > > RedfishResourceIdentifyComuterSystemConstructor > > > > + CONSTRUCTOR =3D > > RedfishResourceIdentifyComputerSystemConstructor > > > > > > > > # > > > > # VALID_ARCHITECTURES =3D IA32 X64 EBC > > > > # > > > > > > > > [Sources] > > > > - RedfishResourceIdentifyLibComuterSystem.c > > > > + RedfishResourceIdentifyLibComputerSystem.c > > > > > > > > [Packages] > > > > MdePkg/MdePkg.dec > > > > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > index fc54787dbdbc..0e27198afbb4 100644 > > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > @@ -28,7 +28,7 @@ > > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.in= f > > > > > > RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemD > > xe.inf { > > > > > > > > - > > RedfishResourceIdentifyLib|RedfishClientPkg/Library/RedfishResourceIden= tif > > yLibComuterSystem/v1_5_0/RedfishResourceIdentifyLibComuterSystem.inf > > > > + > > RedfishResourceIdentifyLib|RedfishClientPkg/Library/RedfishResourceIden= tif > > yLibComputerSystem/v1_5_0/RedfishResourceIdentifyLibComputerSystem.in > > f > > > > } > > > > > > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystem > > CollectionDxe.inf > > > > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.inf > > > > -- > > 2.32.0 (Apple Git-132) >