Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> There are two definitions for below functions in RedfishCrtLib.h. Create
> this change to remote duplicated functions.
> Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(),
> memcpy(), memchr(), memcmp() and memmove().
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
> ---
>  RedfishPkg/Include/Library/RedfishCrtLib.h | 105 ---------------------
>  1 file changed, 105 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
> index 23c6acfca33e..ac6c5162ad6a 100644
> --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -172,20 +172,6 @@ free        (
>    void *
>    );
>
> -void           *
> -memset     (
> -  void *,
> -  int,
> -  size_t
> -  );
> -
> -int
> -memcmp      (
> -  const void *,
> -  const void *,
> -  size_t
> -  );
> -
>  int
>  isdigit     (
>    int
> @@ -216,47 +202,6 @@ isalnum     (
>    int
>    );
>
> -void           *
> -memcpy     (
> -  void *,
> -  const void *,
> -  size_t
> -  );
> -
> -void           *
> -memset     (
> -  void *,
> -  int,
> -  size_t
> -  );
> -
> -void           *
> -memchr     (
> -  const void *,
> -  int,
> -  size_t
> -  );
> -
> -int
> -memcmp      (
> -  const void *,
> -  const void *,
> -  size_t
> -  );
> -
> -void           *
> -memmove    (
> -  void *,
> -  const void *,
> -  size_t
> -  );
> -
> -int
> -strcmp      (
> -  const char *,
> -  const char *
> -  );
> -
>  int
>  strncmp     (
>    const char *,
> @@ -264,35 +209,6 @@ strncmp     (
>    size_t
>    );
>
> -char           *
> -strcpy     (
> -  char *,
> -  const char *
> -  );
> -
> -size_t
> -strlen      (
> -  const char *
> -  );
> -
> -char           *
> -strcat     (
> -  char *,
> -  const char *
> -  );
> -
> -char           *
> -strchr     (
> -  const char *,
> -  int
> -  );
> -
> -int
> -strcasecmp  (
> -  const char *,
> -  const char *
> -  );
> -
>  int
>  strncasecmp (
>    const char *,
> @@ -300,21 +216,6 @@ strncasecmp (
>    size_t
>    );
>
> -char           *
> -strncpy    (
> -  char *,
> -  size_t,
> -  const char *,
> -  size_t
> -  );
> -
> -int
> -strncmp     (
> -  const char *,
> -  const char *,
> -  size_t
> -  );
> -
>  char           *
>  strrchr    (
>    const char *,
> @@ -328,12 +229,6 @@ strtoul     (
>    int
>    );
>
> -char *
> -strstr      (
> -  const char  *s1,
> -  const char  *s2
> -  );
> -
>  long
>  strtol      (
>    const char *,
> --
> 2.17.1

Ack.
Looks good to me.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110419): https://edk2.groups.io/g/devel/message/110419
Mute This Topic: https://groups.io/mt/102296237/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-