From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AAA36D801DB for ; Tue, 31 Oct 2023 15:14:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fOcv46TdwAoKoVj7WEnGFUBzc2cPLzZ2Yo69wbDMIb0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698765271; v=1; b=htdgIYqhB6oxK7YqRpa0ZI4Vm44NQXfzFNtMTkgnVqcaCl55HYXkKpu+TUDmg9YDCkWJsR3e QZGtR4JM2P5RF62HFdjXlWMwCqNUhnOw/YhLPYpm3ogDRHCPCOEGECiH5HNDRqgrFDszfhCUYyl 4c6jemOype+o9qnSWm8IUYA8= X-Received: by 127.0.0.2 with SMTP id zhyQYY7687511x6llXxMNkpt; Tue, 31 Oct 2023 08:14:31 -0700 X-Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by mx.groups.io with SMTP id smtpd.web10.1329.1698765270589835838 for ; Tue, 31 Oct 2023 08:14:30 -0700 X-Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-5a8ada42c2aso57126927b3.3 for ; Tue, 31 Oct 2023 08:14:30 -0700 (PDT) X-Gm-Message-State: cG4BEbIkvqmlz7dSAtEOIBx8x7686176AA= X-Google-Smtp-Source: AGHT+IHaqQ9otqfVK5MNd9/GNzU2Bn2kLeDUUka/HpON5VAy7/v1m8qk7WrLtYCDyJ+ZU8/Gr3dWBbLmtu6zn9Q5WiA= X-Received: by 2002:a81:af03:0:b0:5af:196c:dfcc with SMTP id n3-20020a81af03000000b005af196cdfccmr13648267ywh.8.1698765269656; Tue, 31 Oct 2023 08:14:29 -0700 (PDT) MIME-Version: 1.0 References: <20231031125622.9036-1-nicklew@nvidia.com> In-Reply-To: <20231031125622.9036-1-nicklew@nvidia.com> From: "Mike Maslenkin" Date: Tue, 31 Oct 2023 18:13:53 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions. To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=htdgIYqh; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Tue, Oct 31, 2023 at 3:56=E2=80=AFPM Nickle Wang via groups.io wrote: > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), > strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), > memcpy(), memchr(), memcmp() and memmove(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > Reviewed-by: Abner Chang > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 105 --------------------- > 1 file changed, 105 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Incl= ude/Library/RedfishCrtLib.h > index 23c6acfca33e..ac6c5162ad6a 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -172,20 +172,6 @@ free ( > void * > ); > > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -int > -memcmp ( > - const void *, > - const void *, > - size_t > - ); > - > int > isdigit ( > int > @@ -216,47 +202,6 @@ isalnum ( > int > ); > > -void * > -memcpy ( > - void *, > - const void *, > - size_t > - ); > - > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -void * > -memchr ( > - const void *, > - int, > - size_t > - ); > - > -int > -memcmp ( > - const void *, > - const void *, > - size_t > - ); > - > -void * > -memmove ( > - void *, > - const void *, > - size_t > - ); > - > -int > -strcmp ( > - const char *, > - const char * > - ); > - > int > strncmp ( > const char *, > @@ -264,35 +209,6 @@ strncmp ( > size_t > ); > > -char * > -strcpy ( > - char *, > - const char * > - ); > - > -size_t > -strlen ( > - const char * > - ); > - > -char * > -strcat ( > - char *, > - const char * > - ); > - > -char * > -strchr ( > - const char *, > - int > - ); > - > -int > -strcasecmp ( > - const char *, > - const char * > - ); > - > int > strncasecmp ( > const char *, > @@ -300,21 +216,6 @@ strncasecmp ( > size_t > ); > > -char * > -strncpy ( > - char *, > - size_t, > - const char *, > - size_t > - ); > - > -int > -strncmp ( > - const char *, > - const char *, > - size_t > - ); > - > char * > strrchr ( > const char *, > @@ -328,12 +229,6 @@ strtoul ( > int > ); > > -char * > -strstr ( > - const char *s1, > - const char *s2 > - ); > - > long > strtol ( > const char *, > -- > 2.17.1 Ack. Looks good to me. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110419): https://edk2.groups.io/g/devel/message/110419 Mute This Topic: https://groups.io/mt/102296237/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-