Re: [edk2-devel] [PATCH V2 0/8] Refine BMC USB NIC discovery and Redfish service enablement

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

On Thu, Nov 23, 2023 at 9:47 AM <abner.chang@amd.com> wrote:
>
> From: Abner Chang <abner.chang@amd.com>
>
> In V2: Send additional two patches those are missed
>        in V1.
>
> This patch set updates the algorithm of BMC USB
> NIC discovery and fixes some bugs.
>
> - Add a new protocol to trigger the notification
>   of Redfish Host Interface readiness.
>   This fixes the issue Redfish config handler driver
>   acquires Redfish service before Redfish Host
>   Interface is published.
> - Add more error debug messages.
> - Address some minor issues
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
>
> Abner Chang (8):
>   RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm
>   RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness
>     notification
>   RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification
>   RedfishPkg/RedfishConfigHandler: Correct the prototype of callback
>     function
>   RedfishPkg/RedfishDiscovery: Add more debug message
>   RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code
>   RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC
>     address pointer
>   RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record
>     size
>
>  RedfishPkg/RedfishPkg.dec                     |   3 +
>  .../RedfishConfigHandlerDriver.inf            |   9 +-
>  .../RedfishHostInterfaceDxe.inf               |   3 +-
>  .../RedfishDiscoverInternal.h                 |   2 +
>  .../PlatformHostInterfaceBmcUsbNicLib.c       | 194 ++++++++++++------
>  .../RedfishConfigHandlerDriver.c              | 170 +++++++++------
>  .../RedfishDiscoverDxe/RedfishDiscoverDxe.c   |  23 +++
>  .../RedfishSmbiosHostInterface.c              |  20 +-
>  .../RedfishHostInterfaceDxe.c                 |  16 ++
>  9 files changed, 312 insertions(+), 128 deletions(-)
>
> --
> 2.37.1.windows.1
>

 Hi Abner!

I've checked and tested this patch set and it works for me.
Thank you for these fixes!
I have some comments for patches 1 and 2. All others look good to me.

Regards,
Mike.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111707): https://edk2.groups.io/g/devel/message/111707
Mute This Topic: https://groups.io/mt/102763116/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-