From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A0B79D8030B for ; Sun, 26 Nov 2023 19:47:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ICMaTzVZUgx3/kntYMrta2TNhHLYNiZcMWf2KaOaYVY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701028034; v=1; b=HNgLXJDqeXDmee3TV0nykxzZF5T9mjOLvyJEWo5OQOBdU+oHVP9ZYgQZVluuagcThOMFl8Ba d5Fkr3WGalHphQgF/quCoIsSyNFC6YmKrNtsVSA0g3TvkxFaOGL+jsU6kzS0u4/BV+VNT+hGq0N Zbd5AehxtFmvdeeJBATKZD5M= X-Received: by 127.0.0.2 with SMTP id 92UyYY7687511xDEeKFwFide; Sun, 26 Nov 2023 11:47:14 -0800 X-Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by mx.groups.io with SMTP id smtpd.web10.64608.1701028033474785016 for ; Sun, 26 Nov 2023 11:47:13 -0800 X-Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-db4050e68f3so3192277276.0 for ; Sun, 26 Nov 2023 11:47:13 -0800 (PST) X-Gm-Message-State: V8f65vrt97xM01NvKZpgIPyEx7686176AA= X-Google-Smtp-Source: AGHT+IFLfEq2BVpp63OAYdZrEQcP6KY0OtYVJryxDxT/Tk0pnFahtx64Uq7MiLvvjgV21Vh2GZPJHFdUpTh/PKDBYHc= X-Received: by 2002:a0d:dbc8:0:b0:5c9:78af:c0b7 with SMTP id d191-20020a0ddbc8000000b005c978afc0b7mr7752804ywe.24.1701028032621; Sun, 26 Nov 2023 11:47:12 -0800 (PST) MIME-Version: 1.0 References: <20231123064719.1248-1-abner.chang@amd.com> In-Reply-To: <20231123064719.1248-1-abner.chang@amd.com> From: "Mike Maslenkin" Date: Sun, 26 Nov 2023 22:46:36 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH V2 0/8] Refine BMC USB NIC discovery and Redfish service enablement To: abner.chang@amd.com Cc: devel@edk2.groups.io, Nickle Wang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HNgLXJDq; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Thu, Nov 23, 2023 at 9:47=E2=80=AFAM wrote: > > From: Abner Chang > > In V2: Send additional two patches those are missed > in V1. > > This patch set updates the algorithm of BMC USB > NIC discovery and fixes some bugs. > > - Add a new protocol to trigger the notification > of Redfish Host Interface readiness. > This fixes the issue Redfish config handler driver > acquires Redfish service before Redfish Host > Interface is published. > - Add more error debug messages. > - Address some minor issues > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > > Abner Chang (8): > RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm > RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness > notification > RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification > RedfishPkg/RedfishConfigHandler: Correct the prototype of callback > function > RedfishPkg/RedfishDiscovery: Add more debug message > RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC > address pointer > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record > size > > RedfishPkg/RedfishPkg.dec | 3 + > .../RedfishConfigHandlerDriver.inf | 9 +- > .../RedfishHostInterfaceDxe.inf | 3 +- > .../RedfishDiscoverInternal.h | 2 + > .../PlatformHostInterfaceBmcUsbNicLib.c | 194 ++++++++++++------ > .../RedfishConfigHandlerDriver.c | 170 +++++++++------ > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 +++ > .../RedfishSmbiosHostInterface.c | 20 +- > .../RedfishHostInterfaceDxe.c | 16 ++ > 9 files changed, 312 insertions(+), 128 deletions(-) > > -- > 2.37.1.windows.1 > Hi Abner! I've checked and tested this patch set and it works for me. Thank you for these fixes! I have some comments for patches 1 and 2. All others look good to me. Regards, Mike. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111707): https://edk2.groups.io/g/devel/message/111707 Mute This Topic: https://groups.io/mt/102763116/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-