From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by mx.groups.io with SMTP id smtpd.web10.12423.1688546608051945133 for ; Wed, 05 Jul 2023 01:43:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=iH78KruW; spf=pass (domain: gmail.com, ip: 209.85.128.181, mailfrom: mike.maslenkin@gmail.com) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5703d12ab9aso78390527b3.2 for ; Wed, 05 Jul 2023 01:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688546607; x=1691138607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oi4Hf27klMD0ftCEh34gaxPUKYnkbg7xCFyV3OUSuAY=; b=iH78KruWIUK2PZ5XCI/5IzVKHTAaOPaA01H2T8NSfWwvfIHjdOwkEGVudbWV6l7FHo buMggW/N2F4hntmL8q276jGzeknQQazyOg6bSXcCPW1fgF5uQ5rkjzDr/DqxjWwBhkI8 ms8atm/GGrD5InBFHIlDnKh1q31tHE39+/ApZWq10JZEzJu5RRMB19OrBStZDb91ZDcs 0UooOLNJJJIvK+HqZcLK5qjTmewfiB/QFR2w3OxCEAnZ4di0Zb9ACCnWl4KEdGkhEOjr LaieP5DvqoM2hdyeG8SRDS0FWpyL9ftwHVCD4ao1slx8s7SAwV6JoIlWj6GVm9dFjHuf Fkdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546607; x=1691138607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oi4Hf27klMD0ftCEh34gaxPUKYnkbg7xCFyV3OUSuAY=; b=CljNs8Frks1hVVp9wXz5ixJ5n6uZxD13mw17WypcxcSfulsM2PskoxS1jgX/HbsknW uNEFRnHXTkeWHn9VT9dT0huH20W6wHCzTGltnVRGRCrplpi03yPcN/zzhMJRLY+DYKR2 8jsQ6p9WsBlo40d96TJod4yvuP8R7X2QAfKb08nqJNCtQ0NeFnfa4lGCKDqnR4MEjXzD Z8JlR6X/4HpkTk8ExQoS9aXPfhU6oDn6K53z8aN/+fvxdtI7UNzpev+8ZHMbV1yUa1Z/ WhvEXcO4pROb//mhiLfqy1QX36RgjhEx12SuGnkuM6l/B3CtrBYTZd1vovNa2sXJCegj ARDQ== X-Gm-Message-State: ABy/qLYj/kaguqQjfVmQi0r4vc+wHUEhEKPLDxxjJavXqmiXG24gW4Ym iohSxjNCBh+05ndrJDuJokzWChAHnMIkHKowxSh1QjdvI+o= X-Google-Smtp-Source: APBJJlEU1Cpuvl3Q5hf/BJcvhKB2xLLOO7Wtw4AiBWjt/7+tqydz4CoLmu1nWpyOfLE4fkUs8VVJnJpykhiMeL3nmuU= X-Received: by 2002:a81:ab52:0:b0:577:bc6:6f8c with SMTP id d18-20020a81ab52000000b005770bc66f8cmr15560273ywk.26.1688546607089; Wed, 05 Jul 2023 01:43:27 -0700 (PDT) MIME-Version: 1.0 References: <20230705065628.1329-1-nicklew@nvidia.com> In-Reply-To: <20230705065628.1329-1-nicklew@nvidia.com> From: "Mike Maslenkin" Date: Wed, 5 Jul 2023 11:42:51 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy , Nick Ramirez Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Just one note: All manipulations with this list are going in conjunction with RestExSb->RestExChildrenNum. At first glance it appears this field must be decremented also. But I see no usage for RestExChildrenNum at all, may be it can be eliminated? Regards, MIke. On Wed, Jul 5, 2023 at 9:56=E2=80=AFAM Nickle Wang via groups.io wrote: > > RedfishRestExDxe driver failed to uninstall service binding protocol > when driver binding stop is called. Application drivers may still > use RedfishRestExDxe after it is disconnected in system. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Reviewed-by: Abner Chang > --- > RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExDriver.c > index ad65ae213ae0..7036aed42683 100644 > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > @@ -3,6 +3,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -57,6 +58,7 @@ RestExDestroyChildEntryInHandleBuffer ( > ChildHandleBuffer =3D ((RESTEX_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)C= ontext)->ChildHandleBuffer; > > if (!NetIsInHandleBuffer (Instance->ChildHandle, NumberOfChildren, Chi= ldHandleBuffer)) { > + RemoveEntryList (&Instance->Link); > return EFI_SUCCESS; > } > > @@ -563,7 +565,7 @@ RedfishRestExDriverBindingStop ( > ); > } > > - if ((NumberOfChildren =3D=3D 0) && IsListEmpty (&RestExSb->RestExChild= renList)) { > + if (IsListEmpty (&RestExSb->RestExChildrenList)) { > gBS->UninstallProtocolInterface ( > NicHandle, > &gEfiRestExServiceBindingProtocolGuid, > -- > 2.17.1 > > > >=20 > >