Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

["Mike Maslenkin" <mike.maslenkin@gmail.com>]

There is no usage of strncpy with signature (char *, size_t, char *).
I would suggest to remove this declaration at all.
BTW there are duplicated declaration for memcmp, memset, strncmp.

On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> There are two definitions for strncpy() function in RedfishCrtLib.h
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  RedfishPkg/Include/Library/RedfishCrtLib.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
> index 23c6acfca33e..a2c17d1b03fc 100644
> --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -3,6 +3,7 @@
>
>    Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +  Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>
>      SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -304,8 +305,7 @@ char           *
>  strncpy    (
>    char *,
>    size_t,
> -  const char *,
> -  size_t
> +  const char *
>    );
>
>  int
> --
> 2.17.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107143): https://edk2.groups.io/g/devel/message/107143
Mute This Topic: https://groups.io/mt/100292360/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-