From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 45F85AC0FA5 for ; Sat, 22 Jul 2023 12:28:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oc3cGy+Ctzm60YKwLm1DtcHRkRMDRaIWnPlmdtx5Ajw=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690028902; v=1; b=SHculM1XelqiYLFNcHymSo7LOKXJvv15Zhwb0L6IE4EmxB3B3y4SwDc2uravta5jLzOU1H2G 12f7cJNdujuDCZsRNDGJ60g+9YozsVzS6l2eqXTsCnTlxphokqoTihPAoz4zsyoGzflZPhFP90y RIwiaH18z21hdB6iVAhvX2x4= X-Received: by 127.0.0.2 with SMTP id tR6AYY7687511xqUZ8B0JPOl; Sat, 22 Jul 2023 05:28:22 -0700 X-Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mx.groups.io with SMTP id smtpd.web10.4371.1690028902071772437 for ; Sat, 22 Jul 2023 05:28:22 -0700 X-Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-cab61f812efso2885512276.1 for ; Sat, 22 Jul 2023 05:28:21 -0700 (PDT) X-Gm-Message-State: 5TF5aXSxzdGpUNHQqlGX9XXxx7686176AA= X-Google-Smtp-Source: APBJJlEDANVU2pJ4cwMw1fNG2rrPfaCAUGZzd2AVNXjKSB9DR+SMOpshoSM653vHSCAxUUzLoWwKBDboG3uyX6eNvhs= X-Received: by 2002:a25:77cb:0:b0:d08:82a2:6a4f with SMTP id s194-20020a2577cb000000b00d0882a26a4fmr1287185ybc.42.1690028901196; Sat, 22 Jul 2023 05:28:21 -0700 (PDT) MIME-Version: 1.0 References: <20230722081802.123-1-nicklew@nvidia.com> In-Reply-To: <20230722081802.123-1-nicklew@nvidia.com> From: "Mike Maslenkin" Date: Sat, 22 Jul 2023 15:27:44 +0300 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy. To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy , Nick Ramirez Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SHculM1X; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io There is no usage of strncpy with signature (char *, size_t, char *). I would suggest to remove this declaration at all. BTW there are duplicated declaration for memcmp, memset, strncmp. On Sat, Jul 22, 2023 at 11:18=E2=80=AFAM Nickle Wang via groups.io wrote: > > There are two definitions for strncpy() function in RedfishCrtLib.h > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Incl= ude/Library/RedfishCrtLib.h > index 23c6acfca33e..a2c17d1b03fc 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -3,6 +3,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -304,8 +305,7 @@ char * > strncpy ( > char *, > size_t, > - const char *, > - size_t > + const char * > ); > > int > -- > 2.17.1 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107143): https://edk2.groups.io/g/devel/message/107143 Mute This Topic: https://groups.io/mt/100292360/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-