From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by mx.groups.io with SMTP id smtpd.web12.397.1602001780888920042 for ; Tue, 06 Oct 2020 09:29:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=GizADMZz; spf=pass (domain: nuviainc.com, ip: 209.85.219.195, mailfrom: leif@nuviainc.com) Received: by mail-yb1-f195.google.com with SMTP id 67so9430503ybt.6 for ; Tue, 06 Oct 2020 09:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JPqbJqkn68uToro2WvA59bQxGu8WEQPYtSu/KlZ0688=; b=GizADMZzcGmInSQ3PFu6Z5TlAH3J8B5GaszwxXkysdVQ13axf/D5vA9TgDDJhKTvbB dhtIIGBAD4+AMiSRB1uQi9Dp9Zpsjea7O7h89FHgDGZRIGdJ0Brneb7yqL5tDxNKz52s aPAMitN1s/hM/YT+dcJfRMmL7FUjdIrJeVmStg60Oh2opQv1reFRooKSN4mIe5EKBQ0h C4t9Fyt3O6klQTunKsvBWuvfTaUa7d42uWYLXlvNJz+T5ISgNls7MWniwOuo2HVQVZHC 0+qaF4OnBh45sDN9DK/dKb/CpT5evjipeLsWksmEBmtQcF2fmCAbm5HLgIlowFHkyQp3 6Y/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JPqbJqkn68uToro2WvA59bQxGu8WEQPYtSu/KlZ0688=; b=dvxZKmNjO8g/zICxlsYU8UMmiPLfFNxsMr6+iEng+M7c7zX8E4URL7JWWK8lT0kvOt YdlBjFSrPnsbWR/sk7bvA6ifaZXExyDqiQsVPvAB3E2RrixpfeE7YXZr/Ksc5MlXjQ26 7mkI5YdAHiu72A5yY3avu1BOkKodLAIWGLMx+JJoNPiLAef/ewZ1h4BVQaxAvneNebfw tEpFlgwHHLzdsOc7ePv8iqbUAn41xF+fyg1Hz/wdYBSxuwLZ47miHKyI9CrmM7Mu4Tbj d80ClerLLR2c3vZgeaxioe3HiXCJOuWGmBHvpYhSEd/Zb+i817dO3rlTRaakRvi0XZef wVLA== X-Gm-Message-State: AOAM532h0Lg8Tze2zpYnV2wEoN8b0M3MYO2GDcHfRoL1pLVkOSNf8bQm m8YTz1d0+Y85f20EgHje0rPvnowA6j7p2nkQ3VDffg== X-Google-Smtp-Source: ABdhPJwrjE03A9jeVQmUVzROB4xsvrFzIO05Ze3AlkwwZXpA3boNPV7ntiBi8mMwDaZyKJH+osRlAGnEbKnZId+cdxo= X-Received: by 2002:a25:c42:: with SMTP id 63mr7604021ybm.1.1602001780127; Tue, 06 Oct 2020 09:29:40 -0700 (PDT) MIME-Version: 1.0 References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-2-abner.chang@hpe.com> <20201006143659.GP5623@vanye> In-Reply-To: From: "Leif Lindholm" Date: Tue, 6 Oct 2020 17:29:28 +0100 Message-ID: Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg. To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" , "Wang, Nickle (HPS SW)" , Andrew Fish , Laszlo Ersek , Michael D Kinney Content-Type: multipart/alternative; boundary="00000000000008cb0305b1031b08" --00000000000008cb0305b1031b08 Content-Type: text/plain; charset="UTF-8" Hi Abner, On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) < abner.chang@hpe.com> wrote: > > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new > > > file mode 100644 index 0000000000..d5c65f68c3 > > > --- /dev/null > > > +++ b/RedfishPkg/RedfishPkg.dsc > > > @@ -0,0 +1,40 @@ > > > +## @file > > > +# Redfish Package > > > +# > > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# > > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP. > > > +# > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > +# > > > +## > > > + > > > +[Defines] > > > + PLATFORM_NAME = RedfishPkg > > > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008 > > > + PLATFORM_VERSION = 1.0 > > > + DSC_SPECIFICATION = 0x0001001c > > > + OUTPUT_DIRECTORY = Build/RedfishPkg > > > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64 > > > + BUILD_TARGETS = DEBUG|RELEASE > > > > v3 included NOOPT here. That was the version Laszlo gave his R-b for. > > > > v4 cover letter does mention NOOPT being removed, but I can see no > > conversation in which this is discussed. What have I missed? > > No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI. This should really be referenced in the cover letter. > We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have > the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg. Right, but dropping it from the .dsc BUILD_TARGETS is not required for that. And it's not clear to me that Laszlo noticed this change. / Leif --00000000000008cb0305b1031b08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abn= er (HPS SW/FW Technologist) <abne= r.chang@hpe.com> wrote:
> > > diff --git a/RedfishPkg/Re= dfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 10= 0644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> &= gt; > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@=
> > > +## @file
> > > +# Redfish Package
> &= gt; > +#
> > > +# Copyright (c) 2019, Intel Corporation. All= rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett= -Packard Enterprise Development LP.
> > > +#
> > > = +# =C2=A0 =C2=A0SPDX-License-Identifier: BSD-2-Clause-Patent
> > &= gt; +#
> > > +##
> > > +
> > > +[Define= s]
> > > + =C2=A0PLATFORM_NAME =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D RedfishPkg
> > > + =C2=A0PLA= TFORM_GUID =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =3D c4352870-5232-11e7-9522-005056c00008
> > > + =C2=A0PLATFORM= _VERSION =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 1.0
> &= gt; > + =C2=A0DSC_SPECIFICATION =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0=3D 0x0001001c
> > > + =C2=A0OUTPUT_DIRECTORY =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D Build/RedfishPkg
> >= > + =C2=A0SUPPORTED_ARCHITECTURES =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D IA32|X= 64|ARM|AARCH64|RISCV64
> > > + =C2=A0BUILD_TARGETS =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D DEBUG|RELEASE
&g= t; >
> > v3 included NOOPT here. That was the version Laszlo ga= ve his R-b for.
> >
> > v4 cover letter does mention NOOP= T being removed, but I can see no
> > conversation in which this i= s discussed. What have I missed?
>
> No Leif, y= ou did miss nothing. There was some Q/A conversations between Bret and me a= bout the build target of CI.

This should really be= referenced in the cover letter.

> We would= like to keep NO-TARGET for the non-build CI test but remove NOOPT for now = because we do not have
> the host-based unit test at the momen= t. We would like to add NOOPT back once we have the corresponding unit test= on RedfishPkg.

Right, but dropping it from the .d= sc BUILD_TARGETS is not required for that.
And it's not clear= to me that Laszlo noticed this change.

/
=C2=A0=C2=A0=C2=A0 Leif
--00000000000008cb0305b1031b08--