From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mx.groups.io with SMTP id smtpd.web11.6406.1622121002198743449 for ; Thu, 27 May 2021 06:10:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=skyykiw6; spf=pass (domain: nuviainc.com, ip: 209.85.219.174, mailfrom: leif@nuviainc.com) Received: by mail-yb1-f174.google.com with SMTP id b13so591160ybk.4 for ; Thu, 27 May 2021 06:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aebjCQUFefsDBKN4V9LG+oVWxNWtcJMFaAV4LzDeQfM=; b=skyykiw6iynM3kJipRetFz76+B55nqK1T2K/v1+S+9RHNQN7ZOiNbMqxSKiwxy9p0w YQvcebIajB3zwqKyRYGNZUwovaP3n6QbuMXK4Dg0LpkfLyWbuVYQo/L8yWqHqFEC1889 /AR6O8addieh8XmATIeCmV4B1fD/Iu9bYKbpZG9u6UVJTcPEw6AX+QsbUHSs9SfWzDDF im6brUP1HntoMvYOd/WCFgUu1eYNobtcbdF/UERQXZzhcAQE17yzAxGgCMJPW01gA24y bCmM1LryYo/oQ6MUH6LjuTAC5ey1VMMDaST+uVTJxEQ4xkVYYE2JGCRCubbQv0dntmPl LqqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aebjCQUFefsDBKN4V9LG+oVWxNWtcJMFaAV4LzDeQfM=; b=CXsszP+V8ZZGebJjZavOB10IkWUfjNP336NpZNhvmIDBiUvI0M3Z2XR0UK2vtUSfr6 4U0lXWqY/KUsqJjz4iQ5mI2CCUuOXFi6DMOmIAEJAI/OXuMQDz25ZTutK7VTip6gFrgE I1sgjR8RMuTbM8QDSp8fNs7M84POqO2poBoRjsrVFFMvCpWhpHrBeskeGpg/6joG6ai5 F1zcfISoXDi1+D3cEQks15QVgurhyndqzhDoo2c4pNRdGcBnNL+5izuT6+k0kFjAACld 4WOaPSIbdfZGJ0EQBK9QZ662s55tMozuO6X8SSYWSlWaKoEmajAiViGkWCvVdDc4FeBr QzWA== X-Gm-Message-State: AOAM532ZMIKlNP5wzHPf7WPJL2u5mcBLqdVjejUyInf17sVSlA+BihCq lXFqKQ3f+EGd0tbvTX3cmC/V+1yINGoTDN6F1opJsg== X-Google-Smtp-Source: ABdhPJxQuV/m+XZX9f87EIWg92H2CJnFHtfBH5YCi9wtv0j52hcXCHPcB74Ou+wZdlk9fl10mYX8r+aDZlqOD78OTek= X-Received: by 2002:a25:7b81:: with SMTP id w123mr4235010ybc.429.1622121001386; Thu, 27 May 2021 06:10:01 -0700 (PDT) MIME-Version: 1.0 References: <20210526201446.12554-1-lersek@redhat.com> <20210527130721.5dufj4gy2kyiw2o6@leviathan> In-Reply-To: <20210527130721.5dufj4gy2kyiw2o6@leviathan> From: "Leif Lindholm" Date: Thu, 27 May 2021 14:09:49 +0100 Message-ID: Subject: Re: [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc To: Laszlo Ersek Cc: edk2-devel-groups-io , Andrew Fish , Anthony Perard , Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Julien Grall , Michael D Kinney , Min Xu , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Rebecca Cran , Tom Lendacky Content-Type: multipart/alternative; boundary="000000000000121b2e05c34f7a22" --000000000000121b2e05c34f7a22 Content-Type: text/plain; charset="UTF-8" On Thu, May 27, 2021 at 2:07 PM Leif Lindholm wrote: > > On Wed, May 26, 2021 at 22:14:03 +0200, Laszlo Ersek wrote: > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > > Repo: https://pagure.io/lersek/edk2.git > > Branch: xen_split_bz_2122 > > > > This patch set removes dynamic Xen enlightenment from the following > > platforms: > > > > OvmfPkg/OvmfPkgIa32.dsc > > OvmfPkg/OvmfPkgIa32X64.dsc > > OvmfPkg/OvmfPkgX64.dsc > > > > In Xen guests, the following platform should be used: > > > > OvmfPkg/OvmfXen.dsc > > > > Please see more details / references in the bugzilla ticket. > > > > NOOPT build savings: > > > > - Ia32: PEIFV 1536 bytes, DXEFV 130288 bytes > > - Ia32X64: PEIFV 1536 bytes, DXEFV 140912 bytes > > - X64: PEIFV 1664 bytes, DXEFV 140912 bytes > > - Xen: PEIFV 256 bytes, DXEFV 69504 bytes > > > > Functional testing: > > > > - Booted a Fedora guest on OvmfPkgIa32X64 on QEMU/KVM, compared verbose > > logs before-after. Memory allocations were satisfied at different > > addresses, as expected, plus the Xen drivers were absent. No > > differences otherwise. > > > > - Booted a RHEL guest on ArmVirtQemu on AARCH64. Memory allocations were > > satisfied at different addresses, as expected. > > > > - Xen regression-testing was not done; I'm requesting feedback. > > > > Build testing / bisectability: at every stage, the series builds with > > the following script: > > > > > #!/bin/bash > > > set -e -u -C > > > > > > build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a AARCH64 > > > build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc -a ARM > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a AARCH64 > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc -a ARM > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a AARCH64 > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a ARM > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a AARCH64 > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc -a ARM > > > build -b NOOPT -t GCC5 -p OvmfPkg/AmdSev/AmdSevX64.dsc -a X64 > > > build -b NOOPT -t GCC5 -p OvmfPkg/Bhyve/BhyveX64.dsc -a X64 > > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32.dsc -a IA32 > > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32X64.dsc -a IA32 -a X64 > > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgX64.dsc -a X64 > > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfXen.dsc -a X64 > > > > The patches in the series were formatted with the following options, for > > posting: > > > > --stat=1000 --stat-graph-width=20 --find-copies-harder -U6 > > > > (The option "--find-copies-harder" is not the best for presenting every > > single patch in the series, in isolation, but taken globally for the > > entire series, it is the most helpful option.) > > > > Some patches advance with really small steps, in order to cut down on a > > subsequent "meaty" patch. Personally I don't like reviewing code > > movement patches, so I did my best to (a) keep that to a minimum, and > > (b) present it as unintrusively as possible. > > > > The CC list is a bit long; the reason is that I kept touching up > > "Maintainers.txt", and the "OvmfPkg/Bhyve" and "OvmfPkg/AmdSev" > > platforms as well (whenever it made sense). > > I presume I was primarily cc:d for the Maintainers.txt bit? > For that (patches 11, 12, 21): > Reviewed-by: Leif Lindholm Gah. Also for 32,39/43: Reviewed-by: Leif Lindholm Sorry, I think that's all of them. / Leif --000000000000121b2e05c34f7a22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 27, 2021 at 2:07 PM Leif Lindholm <= leif@nuviainc.com> wrote:
&g= t;
> On Wed, May 26, 2021 at 22:14:03 +0200, Laszlo Ersek wrote:
&= gt; > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2122
>= > Repo: =C2=A0 =C2=A0 htt= ps://pagure.io/lersek/edk2.git
> > Branch: =C2=A0 xen_split_bz= _2122
> >
> > This patch set removes dynamic Xen enlighte= nment from the following
> > platforms:
> >
> > = =C2=A0 OvmfPkg/OvmfPkgIa32.dsc
> > =C2=A0 OvmfPkg/OvmfPkgIa32X64.d= sc
> > =C2=A0 OvmfPkg/OvmfPkgX64.dsc
> >
> > In = Xen guests, the following platform should be used:
> >
> >= ; =C2=A0 OvmfPkg/OvmfXen.dsc
> >
> > Please see more deta= ils / references in the bugzilla ticket.
> >
> > NOOPT bu= ild savings:
> >
> > - Ia32: =C2=A0 =C2=A0PEIFV 1536 byte= s, DXEFV 130288 bytes
> > - Ia32X64: PEIFV 1536 bytes, DXEFV 14091= 2 bytes
> > - X64: =C2=A0 =C2=A0 PEIFV 1664 bytes, DXEFV 140912 by= tes
> > - Xen: =C2=A0 =C2=A0 PEIFV =C2=A0256 bytes, DXEFV =C2=A069= 504 bytes
> >
> > Functional testing:
> >
>= ; > - Booted a Fedora guest on OvmfPkgIa32X64 on QEMU/KVM, compared verb= ose
> > =C2=A0 logs before-after. Memory allocations were satisfie= d at different
> > =C2=A0 addresses, as expected, plus the Xen dri= vers were absent. No
> > =C2=A0 differences otherwise.
> >= ;
> > - Booted a RHEL guest on ArmVirtQemu on AARCH64. Memory allo= cations were
> > =C2=A0 satisfied at different addresses, as expec= ted.
> >
> > - Xen regression-testing was not done; I'= ;m requesting feedback.
> >
> > Build testing / bisectabi= lity: at every stage, the series builds with
> > the following scr= ipt:
> >
> > > #!/bin/bash
> > > set -e -u= -C
> > >
> > > build -b DEBUG -t GCC5 -p ArmVirtPk= g/ArmVirtKvmTool.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-a AARCH64> > > build -b DEBUG -t GCC5 -p ArmVirtPkg/ArmVirtKvmTool.dsc =C2= =A0 =C2=A0-a ARM
> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/Arm= VirtQemu.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -a AARCH64> > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemu.dsc =C2=A0= =C2=A0 =C2=A0 -a ARM
> > > build -b NOOPT -t GCC5 -p ArmVirtPk= g/ArmVirtQemuKernel.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 -a AARCH64
> >= > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtQemuKernel.dsc -a ARM
= > > > build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-a AARCH64
> > >= ; build -b NOOPT -t GCC5 -p ArmVirtPkg/ArmVirtXen.dsc =C2=A0 =C2=A0 =C2=A0 = =C2=A0-a ARM
> > > build -b NOOPT -t GCC5 -p OvmfPkg/AmdSev/Amd= SevX64.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -a X64
> > &g= t; build -b NOOPT -t GCC5 -p OvmfPkg/Bhyve/BhyveX64.dsc =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 -a X64
> > > build -b NOOPT -t = GCC5 -p OvmfPkg/OvmfPkgIa32.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-a IA32> > > build -b NOOPT -t GCC5 -p OvmfPkg/OvmfPkgIa32X64.dsc =C2= =A0 =C2=A0 =C2=A0 -a IA32 -a X64
> > > build -b NOOPT -t GCC5 -= p OvmfPkg/OvmfPkgX64.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 -a X64
> > > build -b NOOPT -t GCC5 -p OvmfPkg/Ov= mfXen.dsc =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0-a X64
> >
> > The patches in the series wer= e formatted with the following options, for
> > posting:
> &= gt;
> > =C2=A0 --stat=3D1000 --stat-graph-width=3D20 --find-copies= -harder -U6
> >
> > (The option "--find-copies-harde= r" is not the best for presenting every
> > single patch in t= he series, in isolation, but taken globally for the
> > entire ser= ies, it is the most helpful option.)
> >
> > Some patches= advance with really small steps, in order to cut down on a
> > su= bsequent "meaty" patch. Personally I don't like reviewing cod= e
> > movement patches, so I did my best to (a) keep that to a min= imum, and
> > (b) present it as unintrusively as possible.
>= >
> > The CC list is a bit long; the reason is that I kept tou= ching up
> > "Maintainers.txt", and the "OvmfPkg/Bh= yve" and "OvmfPkg/AmdSev"
> > platforms as well (wh= enever it made sense).
>
> I presume I was primarily cc:d for t= he Maintainers.txt bit?
> For that (patches 11, 12, 21):
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Gah. Also for 32,39= /43:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Sorry, I thi= nk that's all of them.

/
=C2=A0= =C2=A0=C2=A0 Leif
--000000000000121b2e05c34f7a22--