From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::22e; helo=mail-wr0-x22e.google.com; envelope-from=guyraviv8@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CB2CF21183EE9 for ; Mon, 11 Jun 2018 01:38:16 -0700 (PDT) Received: by mail-wr0-x22e.google.com with SMTP id e18-v6so11166605wrs.5 for ; Mon, 11 Jun 2018 01:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dXY/2hhOO9ZHrXJjH2694507a4etDqIghUSPb5V0Le8=; b=CUmerer251aDsWGwMsbkPmpNy30CapyyDwfDUQX4Yqd3cFGbQ8uSz+IzS1v5NzVcvv /SAsfDs0JKfPtAEqNz/j4klPu8MjUu6fnLolPDcDqnT6J2HGsPgh03JtwlI4CYGon22P Bvek3BFuAG0lcdniJm0nV+RtXMcJRrEWFug+Y+rsFFxRyKfpX0kQeOGVx1jjLHZmxpGK +E76uWaOpN2LRnT+ILeiRhOnintXMd3bm4pEja1tKzFFZseZddAexj37KgyMU06pg9Zh WYuSJ+4Fw3z5vJmHrp4P2i3owr67j4rcLZk3Hh5FZHcxNeTQ2YNqtfUt/EpiElxY7D7C 2kzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dXY/2hhOO9ZHrXJjH2694507a4etDqIghUSPb5V0Le8=; b=BXgT+hZbz2kKQCvxGsnHUO45nL0tovwCDJ3ev8q6A3erTFQ481enmgnsf9NlngcF4t R3yRc7OENA/phCsivTHIJzUYsvELRO1ljvzaHCpUD1BLlLePcgy8/FCLWWjmiq0betkY AUvYx6YTYwF3bScAbMoxLfg8k2+uS6hbQB7OCs4zUtiZjCUfrLvCiC/ojwYNKbGO9YA0 i7+6kblzaE+UV/lFEIRspF9XadykrSDC8U9I+JRrcjTC3UBcw2HeMAA0UaZ+rW0pGCwL YVhdX+W1SZ0e8IaAkMFDrAvnOMyZR7uEhcVRhx+7byYyaL6uoFNYYATLm+mX4WW3TL/7 7ruw== X-Gm-Message-State: APt69E1uQHOHTBe1AMjPcHCM6l52J7O7vm4+o3yHtoUAU57U7ia5FI7X wkfUTdeFnI9VYRTM7EO2Z0Jq2sHq9vhsuP3pkgk= X-Google-Smtp-Source: ADUXVKJTyWliCh/T+S6QRUdwt++LKYQSoxU6lWTPjqVuMhBdwceeK20VbEOtmFXHAbN9tMWVMWjK4LpfKxP1R+imF7s= X-Received: by 2002:adf:ae8b:: with SMTP id y11-v6mr13274145wrc.234.1528706295013; Mon, 11 Jun 2018 01:38:15 -0700 (PDT) MIME-Version: 1.0 References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2939F2@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2953D0@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2953D0@SHSMSX104.ccr.corp.intel.com> From: Guy Raviv Date: Mon, 11 Jun 2018 11:38:27 +0300 Message-ID: To: "Gao, Liming" Cc: edk2-devel@lists.01.org X-Content-Filtered-By: Mailman/MimeDel 2.1.26 Subject: Re: Crc32 Calculation Miss X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 08:38:17 -0000 Content-Type: text/plain; charset="UTF-8" EFI_CALCULATE_CRC32() just calculate the crc for the given address and size. my question is whether PEI *code *is loaded into the RAM or not. if it doesn't which seems reasonable, how can i reach it? some interface for accessing the whole flash data. Thanks, On Mon, Jun 11, 2018 at 5:34 AM Gao, Liming wrote: > Guy: > > Does EFI_CALCULATE_CRC32() cover the flash data that includes PEI > module? > > > > Thanks > > Liming > > *From:* Guy Raviv [mailto:guyraviv8@gmail.com] > *Sent:* Sunday, June 10, 2018 2:59 PM > *To:* Gao, Liming > *Cc:* edk2-devel@lists.01.org > *Subject:* Re: [edk2] Crc32 Calculation Miss > > > > Update - it seems that only in the Pei modules a code change doesn't > change the crc. > > Does it make sense? > > if so, is there any interface to calculate the flash data itself in the > Dxe phase? > > > > Thanks! > > Guy > > > > On Thu, Jun 7, 2018 at 9:34 AM Guy Raviv wrote: > > Hi Gao, > > > > I used the EFI_CALCULATE_CRC32 function from > edkCompatibilityPkg\Foundation. > > > > Thanks, > > > > Guy > > > > On Wed, Jun 6, 2018 at 6:00 PM, Gao, Liming wrote: > > Do you use CalculateCrc32() in BaseLib to calculate CRC32 value for the > different buffer? > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Guy Raviv > > Sent: Wednesday, June 6, 2018 10:18 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] Crc32 Calculation Miss > > > > Hi Everyone, > > > > I have an odd problem. > > In a specific module in my code (MRC training), code modification doesn't > > change the BIOS Crc calculation. > > 1. i checked in my project's fdf file if the FV base address and region > > size defined are the same as the parameters i'm putting in the > calculation. > > 2. i also compared two different binaries and found they are exactly the > > same. > > > > does anyone have any idea what can be wrong here or where should i check? > > > > Thanks, > > Guy > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > > >