From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49])
 by mx.groups.io with SMTP id smtpd.web12.30988.1612168364964613865
 for <devel@edk2.groups.io>;
 Mon, 01 Feb 2021 00:32:45 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@9elements.com header.s=google header.b=Qlp8CFS0;
 spf=pass (domain: 9elements.com, ip: 209.85.210.49, mailfrom: patrick.rudolph@9elements.com)
Received: by mail-ot1-f49.google.com with SMTP id k8so15477373otr.8
        for <devel@edk2.groups.io>; Mon, 01 Feb 2021 00:32:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=9elements.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=ZhB0VLMCWAKH3gtaJxA1vfnr6scwoALGhlr94MkCBoA=;
        b=Qlp8CFS08CoHWQ43BbS1rrcWKqAQOCZTiM/yUu5DRZ+SkkT/E9Lz/pNaCuxouyL0iH
         N43R7vTHXVk5m+unO4njHz2KRcfknmUQr6nNBLtYfVVpF4gTZLqinhfc2RoJ4ERh0SVo
         ubSBhil64sXtgnO/L9gILWne3aKuJuKAlXg0whdIyaOJsuyO1Aka6/1yFyvBk4fhnwTh
         c5lBjBXojN7vaSHJmBFzgG4T9D7Rk7cSZjBwzA6qjaHFX5bVMetCpAFsst7RCYr6ij/F
         ktbzSK/rQeLDrOjFvxmrHMvWZz66tkewwJQ6SaJJPi4dpUK1kjpJlQDdby7IF3W5nlAS
         o2IA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=ZhB0VLMCWAKH3gtaJxA1vfnr6scwoALGhlr94MkCBoA=;
        b=QTfrlWIFo2B+Xzzgj3Mjd2Xt7KV5oMZtv3W3wBpp0KSWAroh0g0ey0/1GIBcu6aNLu
         3QB9ZCsNwb04dT+AOLDben52pE+0CJL61ZG4HkPeyS4foxURqTGLBsc8u2u7QIgfQbdr
         nDJQOc6HZFNvV5EIb9Ua1jFmSoEF55tS6potrxzf3H/z6gt2V73+fQqLkezjd1I1EG9A
         eklNFXn1mQ6OGargZpoAlpV3ibo2L0onqhIkbuhRJXbuGOIEfxEgzTTrGnJ0XZ8yo1V7
         v0ydrA9pqMmLcrSkng4fjcRcvoCzGrrhwJT8myjk+JblAvcAUOO8HShoC4Q9U7oMnw5l
         PoJg==
X-Gm-Message-State: AOAM5310LT+qCp0ZG9R/TNIwTecLLPT6YuJHZWm0SQpV8sHpNHRfkwUx
	YawEjXpV4ab4I65BHOS3T/cfqHkjcYIlZiSWfu4JEbCT/M12SQ==
X-Google-Smtp-Source: ABdhPJygZiqQd+pz6Dt2s9k6SeFzGrqDtD6gC5/aLjLoOhXOMkCvgn0/Iro3582TM3GSAmz1kVC4OP0bmpEVRlgBqPU=
X-Received: by 2002:a9d:75d1:: with SMTP id c17mr11076726otl.78.1612168364324;
 Mon, 01 Feb 2021 00:32:44 -0800 (PST)
MIME-Version: 1.0
References: <20210113190114.19888-1-aiden.park@intel.com> <MW3PR11MB4570EC19F691B8F31511C4B28EB99@MW3PR11MB4570.namprd11.prod.outlook.com>
 <CO1PR11MB4930626F4999640DACA0D1638CB99@CO1PR11MB4930.namprd11.prod.outlook.com>
In-Reply-To: <CO1PR11MB4930626F4999640DACA0D1638CB99@CO1PR11MB4930.namprd11.prod.outlook.com>
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
Date: Mon, 1 Feb 2021 09:32:33 +0100
Message-ID: <CALNFmy0REf9=d6JfCVEohv1SxXkO1xfay3C3mAWMJXju9XwaqQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight
To: devel@edk2.groups.io, "Ni, Ray" <ray.ni@intel.com>
Cc: "Park, Aiden" <aiden.park@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>, 
	"Ma, Maurice" <maurice.ma@intel.com>, "Dong, Guo" <guo.dong@intel.com>
Content-Type: text/plain; charset="UTF-8"

I can confirm that it provides the same fix as my patch "MdeModulePkg:
Fix OptionROM scanning" sent earlier.
Tested on QEMU and Intel CFL board using coreboot as bootloader.

Kind Regards,
Patrick Rudolph

On Fri, Jan 29, 2021 at 10:00 AM Ni, Ray <ray.ni@intel.com> wrote:
>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>
> > -----Original Message-----
> > From: Park, Aiden <aiden.park@intel.com>
> > Sent: Friday, January 29, 2021 9:55 AM
> > To: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> > Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>
> > Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight
> >
> > Hello,
> >
> > Can you please review this?
> >
> > > -----Original Message-----
> > > From: Park, Aiden <aiden.park@intel.com>
> > > Sent: Wednesday, January 13, 2021 11:01 AM
> > > To: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > devel@edk2.groups.io
> > > Cc: Park, Aiden <aiden.park@intel.com>; Ma, Maurice
> > > <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>
> > > Subject: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in
> > > ProcessOptionRomLight
> > >
> > > From: Aiden Park <aiden.park@intel.com>
> > >
> > > The ProcessOptionRomLight() assumes that OpRom has already been processed
> > > in the previous full enumeration and updates AllOpRomProcessed flag to TRUE
> > > by default. However, this may not be applicable with other pre-stage boot
> > > firmwares.
> > >
> > > This will update AllOpRomProcessed flag properly by checking
> > > PciRomGetImageMapping().
> > >
> > > Signed-off-by: Aiden Park <aiden.park@intel.com>
> > > ---
> > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------
> > >  1 file changed, 1 insertion(+), 6 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > index 1b64924b7b..e8337e865e 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > @@ -1168,12 +1168,7 @@ ProcessOptionRomLight (
> > >        ProcessOptionRomLight (Temp);
> > >      }
> > >
> > > -    PciRomGetImageMapping (Temp);
> > > -
> > > -    //
> > > -    // The OpRom has already been processed in the first round
> > > -    //
> > > -    Temp->AllOpRomProcessed = TRUE;
> > > +    Temp->AllOpRomProcessed = PciRomGetImageMapping (Temp);
> > >
> > >      CurrentLink = CurrentLink->ForwardLink;
> > >    }
> > > --
> > > 2.20.1
> >
> > Best Regards,
> > Aiden
>
>
> 
>
>