public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
To: devel@edk2.groups.io, sean@starlabs.systems
Cc: guo.dong@intel.com, Matt DeVillier <matt.devillier@gmail.com>
Subject: Re: [edk2-devel] [PATCH 10/18] BlSupportSmm: fix definition of SetSmrr()
Date: Sun, 20 Feb 2022 19:09:23 +0100	[thread overview]
Message-ID: <CALNFmy0tWFg=6Y=-BCd+XffS7DK8_+UPO0Wncobskw7NGS7gsw@mail.gmail.com> (raw)
In-Reply-To: <b6f866213287160e179f1a7343c7ba722c1e1932.1644527848.git.sean@starlabs.systems>

Hi,
Can you please have a look at this patch?
The BlSupportSmm currently doesn't compile and this patch fixes the issue.
It would be very nice if you could add build tests for every option
defaulting to false to catch those issues in the future.

Regards,
Patrick Rudolph

On Thu, Feb 10, 2022 at 10:25 PM Sean Rhodes <sean@starlabs.systems> wrote:
>
> From: Matt DeVillier <matt.devillier@gmail.com>
>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Change-Id: Id5b077ad6c79717a9d97d4228145791ef062962c
> ---
>  UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> index dcc4d60bb2..0d16aec8ef 100644
> --- a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> +++ b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> @@ -191,6 +191,7 @@ SmmFeatureLockOnS3 (
>    @param[in] ProcedureArgument  Pointer to SMRR_BASE_MASK structure.
>  **/
>  VOID
> +EFIAPI
>  SetSmrr (
>    IN VOID  *ProcedureArgument
>    )
> --
> 2.32.0
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86581): https://edk2.groups.io/g/devel/message/86581
> Mute This Topic: https://groups.io/mt/89056100/2917327
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [patrick.rudolph@9elements.com]
> ------------
>
>

  reply	other threads:[~2022-02-20 18:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <df21ef7edddfef8074ba94514bf73d7a5d0d6046.1644527848.git.sean@starlabs.systems>
2022-02-10 21:20 ` [PATCH 02/18] UefiPayloadPkg: Provide option to use Boot Splash Sean Rhodes
2022-02-10 21:23 ` [PATCH 03/18] MdeModulePackage: Add option to follow BGRT spec Sean Rhodes
2022-02-10 21:23 ` [PATCH 04/18] UefiPayloadPkg: Hookup BGRT build option Sean Rhodes
2022-02-10 21:23 ` [PATCH 05/18] UefiPayloadPkg: Make Boot Manager Key configurable Sean Rhodes
2022-02-10 21:24 ` [PATCH 06/18] UefiPayloadPkg: Add build option for Above 4G Memory Sean Rhodes
2022-02-10 21:24 ` [PATCH 08/18] UefiPayloadPkg: Fix case of protocol Sean Rhodes
2022-02-20 18:11   ` [edk2-devel] " Patrick Rudolph
2022-02-10 21:25 ` [PATCH 09/18] SdMmcPciDxe: Reduce timeout for SD card reset Sean Rhodes
2022-02-11  3:15   ` Wu, Hao A
2022-02-10 21:25 ` [PATCH 10/18] BlSupportSmm: fix definition of SetSmrr() Sean Rhodes
2022-02-20 18:09   ` Patrick Rudolph [this message]
2022-02-10 21:25 ` [PATCH 11/18] UefiPayloadPkg: Make Boot Timeout configurable Sean Rhodes
2022-02-10 21:26 ` [PATCH 12/18] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal Sean Rhodes
2022-02-11  3:12   ` Wu, Hao A
2022-02-10 21:27 ` [PATCH 13/18] MdeModulePkg/Usb/Keyboard.c: don't request protocol before setting Sean Rhodes
2022-02-11  3:32   ` Wu, Hao A
2022-02-11 22:45     ` MrChromebox
2022-02-18  2:17       ` [edk2-devel] " Wu, Hao A
2022-02-10 21:27 ` [PATCH 14/18] UefiPayloadPkg: Add RNG support Sean Rhodes
2022-02-16 23:57   ` Guo Dong
2022-02-10 21:27 ` [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection Sean Rhodes
2022-02-16 23:51   ` Guo Dong
2022-03-21  9:48     ` [edk2-devel] " Sean Rhodes
2022-03-29 17:32       ` Guo Dong
2022-03-29 17:34         ` Sean Rhodes
2022-03-29 18:01           ` Guo Dong
2022-03-29 18:04             ` Sean Rhodes
2022-03-29 18:22               ` Guo Dong
2022-02-10 21:28 ` [PATCH 16/18] UefiCpuPkg: Disable MTRR programming for UefiPayloadPkg Sean Rhodes
2022-02-10 22:06   ` [edk2-devel] " Michael D Kinney
2022-02-11  7:12     ` Patrick Rudolph
2022-02-10 21:29 ` [PATCH 17/18] BmBoot: prioritize internal boot devices over external Sean Rhodes
2022-02-10 21:29 ` [PATCH 18/18] UefiPayloadPkg: Hookup Prioritise Internal build option Sean Rhodes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALNFmy0tWFg=6Y=-BCd+XffS7DK8_+UPO0Wncobskw7NGS7gsw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox