From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173])
 by mx.groups.io with SMTP id smtpd.web12.1195.1645380575469304656
 for <devel@edk2.groups.io>;
 Sun, 20 Feb 2022 10:09:35 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@9elements.com header.s=google header.b=KH+nRopU;
 spf=pass (domain: 9elements.com, ip: 209.85.214.173, mailfrom: patrick.rudolph@9elements.com)
Received: by mail-pl1-f173.google.com with SMTP id l17so1472191plg.0
        for <devel@edk2.groups.io>; Sun, 20 Feb 2022 10:09:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=9elements.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=MA2I4/E1SE76GaI2T+IWI215t9Na3eatCpHMlov7Qm8=;
        b=KH+nRopUdCPXFK8SGVt7RWEcH5faoP1/lP/k1O4DOUfErr1wjjKoNVSaxDZq34E3+t
         Sf1nApwbK/AYmsSZCD36QXzOz1SENU1/Xu9XiYxXsZM0p0+gubjZ+xBnZp8fXbjePuvu
         KzP/1ieNLqwnJ/fJqs7N8t9uwutQGzFhMY0T6iIn+sX4BeYcnKjol/hS9oSXFM0LwZ9A
         ctdVn86EypJr57Jn5UXEXsTVzv7cNttWPVqwCqmr3nqHUfESMP4jjexWPSHQsmIjVzNy
         /IuaKrEXiNUo3eOoxOCqEaSdudCvwSyy0EBjILK51MQtHua86swhGm4yYizVLt3mWHYE
         VnEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=MA2I4/E1SE76GaI2T+IWI215t9Na3eatCpHMlov7Qm8=;
        b=ttRw9dhU2n5KI04hiRA8Q2OsAD8KpqOm9UffwG2wEhmQGzSyg//Z/vhZgE6Cc7gmm6
         UMTl/qnyPxk4pwPiGn8yLED+woH6WftPyttDQo63mXmnVvS7dFAs9AfybrXv+Lp32Rmn
         9nA94M6COJR+aVYgxq7BjehxoyXh8bcQs7QSGU5hhyAbkYcSeIfKADfnwkhGyGS04OcW
         G2uCPS9QHR+NLMparxVbYwA7Z3TvSvfvdVo038Q+EHRy+iN0VXOKCxEJPZXdTKzm9Srl
         bXgFNcdulA3j42HlXjjVytc8XVco6aVwsvx0zMBZRUOWFrldOsdT4hnNQdpyc+OSj9rk
         gaLA==
X-Gm-Message-State: AOAM531lhy4w63g8SDOrPNk/W8CjmSUxHd3V0b9wmUp5dpQem8pRYjpL
	yzpkZ5CSgS/nOBP0kTEpo6MHsLtYWeDMvCwska267iuhOThsww==
X-Google-Smtp-Source: ABdhPJyl7JFrcdLKdARm92DcODXKZ89M0FIL9qntRAxg3r+FN5APFxOX0tb0J2Yhn9vcCF3RRbUtHJvwxS1d7agbti4=
X-Received: by 2002:a17:902:ec89:b0:14d:9b84:ffc2 with SMTP id
 x9-20020a170902ec8900b0014d9b84ffc2mr15565684plg.23.1645380575029; Sun, 20
 Feb 2022 10:09:35 -0800 (PST)
MIME-Version: 1.0
References: <df21ef7edddfef8074ba94514bf73d7a5d0d6046.1644527848.git.sean@starlabs.systems>
 <b6f866213287160e179f1a7343c7ba722c1e1932.1644527848.git.sean@starlabs.systems>
In-Reply-To: <b6f866213287160e179f1a7343c7ba722c1e1932.1644527848.git.sean@starlabs.systems>
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
Date: Sun, 20 Feb 2022 19:09:23 +0100
Message-ID: <CALNFmy0tWFg=6Y=-BCd+XffS7DK8_+UPO0Wncobskw7NGS7gsw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 10/18] BlSupportSmm: fix definition of SetSmrr()
To: devel@edk2.groups.io, sean@starlabs.systems
Cc: guo.dong@intel.com, Matt DeVillier <matt.devillier@gmail.com>
Content-Type: text/plain; charset="UTF-8"

Hi,
Can you please have a look at this patch?
The BlSupportSmm currently doesn't compile and this patch fixes the issue.
It would be very nice if you could add build tests for every option
defaulting to false to catch those issues in the future.

Regards,
Patrick Rudolph

On Thu, Feb 10, 2022 at 10:25 PM Sean Rhodes <sean@starlabs.systems> wrote:
>
> From: Matt DeVillier <matt.devillier@gmail.com>
>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Change-Id: Id5b077ad6c79717a9d97d4228145791ef062962c
> ---
>  UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> index dcc4d60bb2..0d16aec8ef 100644
> --- a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> +++ b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
> @@ -191,6 +191,7 @@ SmmFeatureLockOnS3 (
>    @param[in] ProcedureArgument  Pointer to SMRR_BASE_MASK structure.
>  **/
>  VOID
> +EFIAPI
>  SetSmrr (
>    IN VOID  *ProcedureArgument
>    )
> --
> 2.32.0
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86581): https://edk2.groups.io/g/devel/message/86581
> Mute This Topic: https://groups.io/mt/89056100/2917327
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [patrick.rudolph@9elements.com]
> ------------
>
>