From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178])
 by mx.groups.io with SMTP id smtpd.web08.35423.1614002664525624433
 for <devel@edk2.groups.io>;
 Mon, 22 Feb 2021 06:04:24 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@9elements.com header.s=google header.b=Fx98j2vH;
 spf=pass (domain: 9elements.com, ip: 209.85.167.178, mailfrom: patrick.rudolph@9elements.com)
Received: by mail-oi1-f178.google.com with SMTP id j1so2065034oiw.3
        for <devel@edk2.groups.io>; Mon, 22 Feb 2021 06:04:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=9elements.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=kj94xgnfGogKrPO2izDLbZV3tNrpPvzjTLz6/SxrV34=;
        b=Fx98j2vHxAGqQfLrfFDmeehmNJwV3uq2XiAcnn3ZTkOgzLDavQAQaKEf+LkrvWXZs7
         zkE2G1cU0HDBOIHQfqhgbRDDsH8TmYkB1sRL8Q0YRqvy4yF+YynP6mdQjJp426JNELX8
         lra/3uUtsjcdMtMGo3AogJUMnSFZCmn2Q4VKdep9DwdjwmHD/vSDRu0JSHEeP8kcvh4d
         geDCj5ORxuuce05qDHuKflchMVhRfvjHqcahJ3+CFxq50IBXBfWkfD2URiW2+19+VKYk
         rR50JBi8VuD4MXWn90AMAkTIoww9GHKp+bfbyabXBitt/rv9++PAMyo8m13bG/u8h280
         Bc8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=kj94xgnfGogKrPO2izDLbZV3tNrpPvzjTLz6/SxrV34=;
        b=SiD+JsWIphejsr3LV2MxaU9LTFxUDtbSdfhEj3N+vQeSYs3aHYHjKDnb0sfpwLHYIW
         j9Yq1R18BhIPiqEcBvMTFM2RooWhMy0/z8Xfp0cYv/AipMtovsUMNkZa4d+zpZBGoY00
         TcHY1lJ3N8/mKUotnzghOThDIAG80cTnN20Sc3A254ThaVwccxLrg17wM+0nPS/58xEB
         SAnnATaGbGyyemNiOMlklgLz0MVCfXVYylJYN32TxuJQlkLgeOCV+G8/3IOokudf7bLx
         UUCWDy081cGgdCnSmGnRXlpbKqhaM2CuXP9LlXbWrS4bWRfL1lGFhkjfcdoS16lXQUZI
         ZAOg==
X-Gm-Message-State: AOAM533yz7qcYakdAuPisVradv3251/DB5xaJSEKomzl7tF6KEeJLN7s
	icjFGJnPl4Yc2BXLSP7yJMe4E0ryL0R0npHcDFe2PN/D0GV2uA==
X-Google-Smtp-Source: ABdhPJxab0r1sjxtcS9NR4zb1NwH/xCO9e4RnoT1FThwLku8kmfrr72hUiAyxROBQ7yTgTesQD8TMVDfH1KJSUFoOZs=
X-Received: by 2002:a05:6808:140a:: with SMTP id w10mr15783064oiv.146.1614002663904;
 Mon, 22 Feb 2021 06:04:23 -0800 (PST)
MIME-Version: 1.0
References: <20210215051308.11796-1-guo.dong@intel.com> <DM6PR11MB279317A36E8DF94E49D92EA889849@DM6PR11MB2793.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB279317A36E8DF94E49D92EA889849@DM6PR11MB2793.namprd11.prod.outlook.com>
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
Date: Mon, 22 Feb 2021 15:04:12 +0100
Message-ID: <CALNFmy0utQfSqUZxCoih102zFCaPUEiorrFrumaQWeH=h-YiFw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA
To: devel@edk2.groups.io, "Ma, Maurice" <maurice.ma@intel.com>
Cc: "Dong, Guo" <guo.dong@intel.com>, "You, Benjamin" <benjamin.you@intel.com>
Content-Type: text/plain; charset="UTF-8"

This patch breaks booting on master.
In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted
to 32bits.

Regards,
Patrick

On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice <maurice.ma@intel.com> wrote:
>
> Reviewed-by:  Maurice Ma <maurice.ma@intel.com>
>
> Regards
> Maurice
>
> > -----Original Message-----
> > From: Dong, Guo <guo.dong@intel.com>
> > Sent: Sunday, February 14, 2021 21:13
> > To: devel@edk2.groups.io
> > Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> > <benjamin.you@intel.com>
> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove
> > 4GB memory WA
> >
> > Previous it would hang in CpuDxe if DXE drivers are dispatched above 4GB.
> > Now remove the work around since the fixed in CpuDxe are merged.
> >
> > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > ---
> >  UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > index 805f5448d9..c403b0a80a 100644
> > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> > @@ -40,11 +40,6 @@ MemInfoCallback (
> >               EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |
> >               EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE;
> >
> > -  if (Base >= BASE_4GB ) {
> > -    // Remove tested attribute to avoid DXE core to dispatch driver to
> > memory above 4GB
> > -    Attribue &= ~EFI_RESOURCE_ATTRIBUTE_TESTED;
> > -  }
> > -
> >    BuildResourceDescriptorHob (Type, Attribue,
> > (EFI_PHYSICAL_ADDRESS)Base, Size);
> >    DEBUG ((DEBUG_INFO , "buildhob: base = 0x%lx, size = 0x%lx, type =
> > 0x%x\n", Base, Size, Type));
> >
> > --
> > 2.16.2.windows.1
>
>
>
> 
>
>