public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
To: "Dong, Guo" <guo.dong@intel.com>
Cc: "You, Benjamin" <benjamin.you@intel.com>,
	"Ma, Maurice" <maurice.ma@intel.com>,
	 "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH V2 1/1] UefiPayloadPkg: Remove PEI phase from Payload
Date: Thu, 28 Jan 2021 08:40:29 +0100	[thread overview]
Message-ID: <CALNFmy19uX1RjDSi+MKS3frSW0-+m+7jzVYVo6tnpDZeEZ2DYw@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB36224A6E26D9FCCE7553EA9B9EBB9@BYAPR11MB3622.namprd11.prod.outlook.com>

Hi,
Modifying the bootloader and defining an interface could take a while
and requires to add code that's already present in EDK2.
Would it be possible to move the Tcg*Pei code to a Library, so that it
could be directly used by BlSupportDxe in order to set the PCDs?

Kind Regards,
Patrick Rudolph

On Wed, Jan 27, 2021 at 5:10 PM Dong, Guo <guo.dong@intel.com> wrote:
>
>
> Hi Patrick,
> Bootloader (coreboot or Slim Bootloader) is similar with EDKII PEI, so measured boot should
> work without PEI phase in UEFI payload.
> In general, bootloader need pass required information to UEFI payload.
> BlSupportDxe could get these information and set required PCDs.
>
> We need well define the interface with bootloader on how to support measured boot,
> Also including measured boot enable/disable, TPM log event, etc.
>
> Thanks,
> Guo
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick
>  > Rudolph
>  > Sent: Tuesday, January 26, 2021 8:21
>  > To: Dong, Guo <guo.dong@intel.com>
>  > Cc: You, Benjamin <benjamin.you@intel.com>; devel@edk2.groups.io; Ma,
>  > Maurice <maurice.ma@intel.com>
>  > Subject: Re: [edk2-devel] [PATCH V2 1/1] UefiPayloadPkg: Remove PEI phase
>  > from Payload
>  >
>  > Hi,
>  > I'm trying to rebase my TPM support patches for UefiPayloadPkg on top of
>  > master.
>  >
>  > The Tcg*Dxe needs the following PCDs set by their Tcg*Pei counterparts:
>  > * PcdTpm2HashMask
>  > * PcdTcg2HashAlgorithmBitmap
>  > * PcdTpmInstanceGuid
>  >
>  > As there's no PEI stage any more, how do you plan to support TPMs in
>  > UefiPayloadPkg?
>  >
>  > Kind Regards,
>  > Patrick Rudolph
>

  reply	other threads:[~2021-01-28  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  0:35 [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase from Payload Guo Dong
2020-11-16  0:35 ` [edk2-devel] [PATCH V2 1/1] " Guo Dong
2020-11-16 21:39   ` Ma, Maurice
2021-01-26 16:21     ` Patrick Rudolph
     [not found]       ` <DM6PR11MB27932D059A84A78B3CEB53E389BB9@DM6PR11MB2793.namprd11.prod.outlook.com>
2021-01-27 16:10         ` Guo Dong
2021-01-28  7:40           ` Patrick Rudolph [this message]
2021-01-28 22:34             ` Guo Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALNFmy19uX1RjDSi+MKS3frSW0-+m+7jzVYVo6tnpDZeEZ2DYw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox