From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47])
 by mx.groups.io with SMTP id smtpd.web09.21612.1611819640745947751
 for <devel@edk2.groups.io>;
 Wed, 27 Jan 2021 23:40:40 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@9elements.com header.s=google header.b=FLuhLQcI;
 spf=pass (domain: 9elements.com, ip: 209.85.210.47, mailfrom: patrick.rudolph@9elements.com)
Received: by mail-ot1-f47.google.com with SMTP id i30so4345516ota.6
        for <devel@edk2.groups.io>; Wed, 27 Jan 2021 23:40:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=9elements.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=V0g/7kXEZyncRuWsW3EI+vXgTRdLoyFND++1z0shL2A=;
        b=FLuhLQcIuJ/hdeQhE80j625Iiiu53KXJSwccox+3bhQM4JuwedcF6CqCgsWgUB4xn+
         RIxMX5IzUP3zZ87cYLyPFndh3Oo3i8tbP15INAf/lw1Am02cNXqW+TOmHr8iWbomqcta
         OtTmBRlAVdw9qYnoRi3P/Swd+94QjNzdZ8n5678mMkkbxpkO4mn3zW821L82zNc/tVAR
         EJcpQ2jzbcHJBxKDtFc+wzFr+80imOTfBG3jL6zqHGOPVBcfDzafiiAGqvqvooR8yDKj
         hirJuYfxdU76fKNoV2ComQVrCxOj4IXNHQXSkIUtWJj6n8IMKLnXuQjGpmJS7CfwWySV
         /xlw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=V0g/7kXEZyncRuWsW3EI+vXgTRdLoyFND++1z0shL2A=;
        b=QtjLLTGulcqfcnnpS/QWISAsqFgn4zywOk8UvmuYuUes0QNXKhRNVHPdG3mpJvv6ZT
         UeLDODikjUHDf3trlo5phXDh8dppEbYejcdClGx0bNmb2qH4klhY6aWeykDjA93othPt
         0Mw082gUd6D3TbkfXZjoLZ57KdGVRWdBgCmEUb/Iw9D7gAupkouCpo7IifvCYVyN5NSA
         cGhwUbzYXmXqD1NGK7CwnUqp+8L4TecEllu0PRqcx5L9wBKDzmuUMQ6auNH4OJ5Fm3r0
         cfCOhNK/27NslPXghO9dYt86A0FFa444ZiT4CrFPz64nJUW50UooF9u9YMFs/0a3Ixy+
         m5iA==
X-Gm-Message-State: AOAM532KiZryHnQS/WN9JP2bsL8aGIe8ueXYjjvBbr9hLiSjMguasH88
	U/0xhXb0z00DI1QkbsGWATd2Kez4JRTq7Qj3C04LZQ==
X-Google-Smtp-Source: ABdhPJydCxmCNfm8F3UHEntLkQf7YQ1UUb7ceXuSxtexZcJsgE6fzgpgm/uBhqYOrMHKyWMqS6U8Lt8GuMVmfev331I=
X-Received: by 2002:a9d:75d1:: with SMTP id c17mr10665798otl.78.1611819640086;
 Wed, 27 Jan 2021 23:40:40 -0800 (PST)
MIME-Version: 1.0
References: <cover.1605475852.git.guo.dong@intel.com> <95f8222410996f8bf34eac67f714df76d87d377d.1605475852.git.guo.dong@intel.com>
 <DM6PR11MB2793C732D05AC63150D51CCA89E30@DM6PR11MB2793.namprd11.prod.outlook.com>
 <CALNFmy3oK4VWLs6+zLmSFQpxN9wrV9tW2k6ppUQq4gewdYvvfw@mail.gmail.com>
 <DM6PR11MB27932D059A84A78B3CEB53E389BB9@DM6PR11MB2793.namprd11.prod.outlook.com>
 <BYAPR11MB36224A6E26D9FCCE7553EA9B9EBB9@BYAPR11MB3622.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB36224A6E26D9FCCE7553EA9B9EBB9@BYAPR11MB3622.namprd11.prod.outlook.com>
From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
Date: Thu, 28 Jan 2021 08:40:29 +0100
Message-ID: <CALNFmy19uX1RjDSi+MKS3frSW0-+m+7jzVYVo6tnpDZeEZ2DYw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH V2 1/1] UefiPayloadPkg: Remove PEI phase from Payload
To: "Dong, Guo" <guo.dong@intel.com>
Cc: "You, Benjamin" <benjamin.you@intel.com>, "Ma, Maurice" <maurice.ma@intel.com>, 
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

Hi,
Modifying the bootloader and defining an interface could take a while
and requires to add code that's already present in EDK2.
Would it be possible to move the Tcg*Pei code to a Library, so that it
could be directly used by BlSupportDxe in order to set the PCDs?

Kind Regards,
Patrick Rudolph

On Wed, Jan 27, 2021 at 5:10 PM Dong, Guo <guo.dong@intel.com> wrote:
>
>
> Hi Patrick,
> Bootloader (coreboot or Slim Bootloader) is similar with EDKII PEI, so measured boot should
> work without PEI phase in UEFI payload.
> In general, bootloader need pass required information to UEFI payload.
> BlSupportDxe could get these information and set required PCDs.
>
> We need well define the interface with bootloader on how to support measured boot,
> Also including measured boot enable/disable, TPM log event, etc.
>
> Thanks,
> Guo
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick
>  > Rudolph
>  > Sent: Tuesday, January 26, 2021 8:21
>  > To: Dong, Guo <guo.dong@intel.com>
>  > Cc: You, Benjamin <benjamin.you@intel.com>; devel@edk2.groups.io; Ma,
>  > Maurice <maurice.ma@intel.com>
>  > Subject: Re: [edk2-devel] [PATCH V2 1/1] UefiPayloadPkg: Remove PEI phase
>  > from Payload
>  >
>  > Hi,
>  > I'm trying to rebase my TPM support patches for UefiPayloadPkg on top of
>  > master.
>  >
>  > The Tcg*Dxe needs the following PCDs set by their Tcg*Pei counterparts:
>  > * PcdTpm2HashMask
>  > * PcdTcg2HashAlgorithmBitmap
>  > * PcdTpmInstanceGuid
>  >
>  > As there's no PEI stage any more, how do you plan to support TPMs in
>  > UefiPayloadPkg?
>  >
>  > Kind Regards,
>  > Patrick Rudolph
>