From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mx.groups.io with SMTP id smtpd.web08.8095.1623758471749711616 for ; Tue, 15 Jun 2021 05:01:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=ExmLfPAK; spf=pass (domain: 9elements.com, ip: 209.85.210.176, mailfrom: patrick.rudolph@9elements.com) Received: by mail-pf1-f176.google.com with SMTP id q25so13094653pfh.7 for ; Tue, 15 Jun 2021 05:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/NpR72lXDVmeiReLXtIfmsDUu13UGuzRtMS3UaYXQOs=; b=ExmLfPAKFcbbdQT6LRAThAD/mdXkis4P5DIbWtKoRjASE3S7ESwyeeIzTx50V07R6/ kRm7l4r8omTNwVJbYNz27/nJZGu3iiqWxFZ6tm2nx2tgy1yWKsHCdVrUDGNi9DDHTBNW nHZuvRVk31sECluS6sUQIPqvw7Akd8elQFfQXfKND80dKiY/qNPY9pL4i9Bu86hEs/1l KJ4PR++DpdZkRTlKC0Hd39F7weBJKiSap0Z32v7T0GTzg8fR+aBDSm1mqec6VR6VH85w 7aEQuhNcgGubMD4lDcFjAYMigd5x04zsMC/aeQOJLEhssmmGDW56NWxJOIEVBW/K5y07 kKag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/NpR72lXDVmeiReLXtIfmsDUu13UGuzRtMS3UaYXQOs=; b=dksn6tium97N6V02X22gfo3tuPhJD0VJX7fNu85JWyl3fmmwA75LENQrJ8ExuGo/ak XHjlCS4IFlfAgfDXTPmExNYntAkp9cui73yVG3sZc6Jum1dACr82aJs277pGEABSHSwc Yu5MsTuWrDNltiWLUNQ3mkMIjqtbsbulySFtVRzfC4xJGvhPmWeCEFMN/41ACYhIPY7w Vs/n0NCHsaH1b8jZxbiik1mp91N5GikITfg/dGS8MfWeQQVgNoUds/W781pextboW3O+ pzRUdQEYJ0g5Jl/+HG0yecnIQQoMtfdbaTsOsEMWuuMDCqJWKX+G1PYRdO6cnAztoKZm adYg== X-Gm-Message-State: AOAM532uNS/Acmk199p3MXUFygbmFGKOq92KC6LwCnx5AmrK3nSubkw6 OloNVvNcCtW80/Z5/bClzeldf2ghrQGSRfQMOzZHJaidJ6SAuQ== X-Google-Smtp-Source: ABdhPJyr0M8IzdylC57M21g7/1KxufnhB3saRaiZ6izJKSAhkkS6DafJhfSClJlhTte7zR+DPEhTdZZEb+7YW+s8BE8= X-Received: by 2002:a62:7ac9:0:b029:2ea:8eb:d5a0 with SMTP id v192-20020a627ac90000b02902ea08ebd5a0mr4041622pfc.26.1623758471104; Tue, 15 Jun 2021 05:01:11 -0700 (PDT) MIME-Version: 1.0 References: <20210610013318.1885-1-zhiguang.liu@intel.com> <00b701d75dd8$e6306790$b29136b0$@byosoft.com.cn> In-Reply-To: From: "Patrick Rudolph" Date: Tue, 15 Jun 2021 14:00:59 +0200 Message-ID: Subject: Re: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Universal Payload To: devel@edk2.groups.io, "Liu, Zhiguang" Cc: gaoliming Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Tested the patch series on Intel Coffee Lake Platform using latest coreboot master. Everything seems to work fine. Thanks Patrick On Thu, Jun 10, 2021 at 11:48 AM Zhiguang Liu wro= te: > > Liming, > > Bugzilla is created at https://bugzilla.tianocore.org/show_bug.cgi?id=3D= 3447 > > Thanks > Zhiguang > > > -----Original Message----- > > From: gaoliming > > Sent: Thursday, June 10, 2021 5:14 PM > > To: devel@edk2.groups.io; Liu, Zhiguang > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [Patch V4 0/9] Create multip= le Hobs for Universal > > Payload > > > > Zhiguang: > > Can you submit one BZ for this new feature? I will add it into edk2 = 202108 > > stable tag planning. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Zhiguang Liu > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8810=E6= =97=A5 9:33 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E4=B8=BB=E9=A2=98: [edk2-devel] [Patch V4 0/9] Create multiple Hobs= for Universal > > > Payload > > > > > > V1: > > > This patch set is based on Universal Payload on > > > https://universalpayload.github.io/documentation/payload- > > interfaces/index. > > > html > > > This patch set introduce one general header, three different hob typ= es > > > and how Universal Payload consume these hobs. > > > > > > V2: > > > Move all the header files and Guid define to MdeModulePkg Fix code b= ug > > > when parsing SmbiosDxe. > > > Enhance error handling in AcpiTableProtocol.c. > > > Add AcpiTableDxe.inf in UefiPayload.fdf > > > > > > V3: > > > Avoid duplicated code in SmBiosDxe.c > > > > > > V4: > > > Add link to spec in header files' file comments Avoid using PLD, > > > because it may be confusing > > > > > > All changes can be seen at > > > > > https://github.com/LiuZhiguang001/edk2/tree/UniversalPayloadHeaders_v4 > > > > > > Zhiguang Liu (9): > > > MdeModulePkg: Add Universal Payload general definition header file > > > MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob > > > UefiPayloadPkg: UefiPayload retrieve PCI root bridge from Guid Hob > > > MdeModulePkg: Add new structure for the Universal Payload SMBios > > Table > > > Info Hob > > > MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables > > > UefiPayloadPkg: Creat gPldSmbiosTableGuid Hob > > > MdeModulePkg: Add new structure for the Universal Payload ACPI Tab= le > > > Info Hob > > > MdeModulePkg/ACPI: Install ACPI table from HOB. > > > UefiPayloadPkg: Creat gPldAcpiTableGuid Hob > > > > > > MdeModulePkg/Include/UniversalPayload/AcpiTable.h | > > > 30 ++++++++++++++++++++++++++++++ > > > MdeModulePkg/Include/UniversalPayload/PciRootBridges.h | > > > 91 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > +++++++++++++++++++++++++++++ > > > MdeModulePkg/Include/UniversalPayload/SmbiosTable.h | > > > 30 ++++++++++++++++++++++++++++++ > > > MdeModulePkg/Include/UniversalPayload/UniversalPayload.h | > > > 35 +++++++++++++++++++++++++++++++++++ > > > MdeModulePkg/MdeModulePkg.dec > > > | 15 +++++++++++++++ > > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.c | > > > 92 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > +++--------------------------- > > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTable.h | > > > 38 +++++++++++++++++++++++++++++++++++++- > > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf | = 8 > > > +++++--- > > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 17= 1 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > ++++++++++++++++++++++++++++++++++++++++------- > > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | > > > 293 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > ++++++++++++++++++++++++++++++++++++++++++++- > > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h | > > > 65 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > ++- > > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf | > > > 5 ++++- > > > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c | > > > 28 +--------------------------- > > > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h | > > > 5 +---- > > > UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf | > > > 4 +--- > > > UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h | 4= 0 > > > ++++++++++++++++++++++++++++++++++++++-- > > > UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4= 7 > > > ++++++++++++++++++++++++++++++++++++++++++++--- > > > UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | = 8 > > > +++++++- > > > UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7= 3 > > > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > ++++ > > > ++++++++++- > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 2= 3 > > > ++++++++++++++++++++++- > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | = 5 > > > +++-- > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | = 4 > > > +++- > > > UefiPayloadPkg/UefiPayloadPkg.dsc | > > > 2 +- > > > UefiPayloadPkg/UefiPayloadPkg.fdf | > > > 4 ++++ > > > 24 files changed, 1029 insertions(+), 87 deletions(-) create mode > > > 100644 MdeModulePkg/Include/UniversalPayload/AcpiTable.h > > > create mode 100644 > > > MdeModulePkg/Include/UniversalPayload/PciRootBridges.h > > > create mode 100644 > > > MdeModulePkg/Include/UniversalPayload/SmbiosTable.h > > > create mode 100644 > > > MdeModulePkg/Include/UniversalPayload/UniversalPayload.h > > > > > > -- > > > 2.30.0.windows.2 > > > > > > > > > > > > > > > > > > > > > > >=20 > >