From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by mx.groups.io with SMTP id smtpd.web11.2046.1606897732743528602 for ; Wed, 02 Dec 2020 00:28:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=WraZQG0q; spf=pass (domain: 9elements.com, ip: 209.85.210.47, mailfrom: patrick.rudolph@9elements.com) Received: by mail-ot1-f47.google.com with SMTP id h19so936118otr.1 for ; Wed, 02 Dec 2020 00:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SVavjYnJl/ScW1a5+cG7TbGIFqLyElfhGrZQOAwVGVI=; b=WraZQG0qEnhLtcElAuO7HP71vT6IO4zoUNMjxyOQ84wDcj0IhkuQhnpI9qbO5LCyR8 RV2J4U6LylMVq5RSxJwRJQOzy8IpJUZfgpU+10cri9a/Dokbmr6HIAo5GhMsVy1KG375 AUJO0hjt9H40F+R/8HUihLLOP8mKq0isF8ceg8SQdxNzrKLpO41FNoxAfuuMdaL1TVjf EqCKwxxIiXMZyDdZljStrfhvoi60p8BpcLUUCwn+5AfxyQR8MfO08Ik4YAOFynUrJtfn g3pUBQKKy9wVdzTLJSIrm7bO8ZeTyK8oloDdhifPBkMHyHXUAaLWj/Tw2lo7OGPvCdHK s5cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SVavjYnJl/ScW1a5+cG7TbGIFqLyElfhGrZQOAwVGVI=; b=b15Bj3EPp4iAuMI6/9Xz5f9xm52AnWiLYqOGYDQjLrzSYwkjHMA24WPN60WcrncnPx WidwzGQDb9V4i4T6hz7vKBICZhS/SGcZ/APvgbY+1GFWySEdvxk6/o1n86YLRZgsBiH3 MOC7JbMtS3mZTA6ai8R9gb/Ju/Fwq6zFdLB+mcumgwDx08hF7slI584Ep42e/HGCfzGK LW/uvv02hfTL1pq9FiPt/xOnspD8Drr9u0rSkIYaKFy6cWXGzWGMdV247iRydJTpV+Aw c2uXaea0X8c41krFfxFrqeokGuo3QiriYl/DLrChqNqQ4h2f5gRmsCcTeURXKTXzbw7b 1czw== X-Gm-Message-State: AOAM531+9L8942oLeqent2M6IAsoLxK2hokXXhhrOWMAC+F98kuSNnfc Nxhje/0Mnc74znt5RbWVpNvZJeX2OitoZm9Ibac2b0mlpAC0OA== X-Google-Smtp-Source: ABdhPJyaNamWhPY8W7dyYBmOxDdBn4662DwJmUirNRUDyjOTSPiR7FPmKN8PWCRcVKNOPRnOPOytsOWDSoIegYUYqz0= X-Received: by 2002:a9d:3f49:: with SMTP id m67mr1077732otc.78.1606897731850; Wed, 02 Dec 2020 00:28:51 -0800 (PST) MIME-Version: 1.0 References: <1647D5DAE0E6DDAF.27572@groups.io> <005801d6bc7b$6b90f670$42b2e350$@byosoft.com.cn> In-Reply-To: From: "Patrick Rudolph" Date: Wed, 2 Dec 2020 09:28:40 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase from Payload To: devel@edk2.groups.io, "Dong, Guo" Cc: "gaoliming@byosoft.com.cn" , "Ma, Maurice" , "You, Benjamin" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, This is a gentle reminder to merge this change to get a broader feedback from the community using the UefiPayloadPkg. Kind regards, Patrick Rudolph B.Sc. Electrical Engineering System Firmware Developer Patrick Rudolph B.Sc. Electrical Engineering System Firmware Developer 9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, Germany Email: patrick.rudolph@9elements.com Phone: +49 234 68 94 188 Sitz der Gesellschaft: Bochum Handelsregister: Amtsgericht Bochum, HRB 17519 Gesch=C3=A4ftsf=C3=BChrung: Sebastian Deutsch, Eray Basar Datenschutzhinweise nach Art. 13 DSGVO Am Di., 17. Nov. 2020 um 20:47 Uhr schrieb Guo Dong : > > > Thanks Liming. If so it is OK to merge it after this stable tag. > > Thanks, > Guo > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of gaolimi= ng > > Sent: Monday, November 16, 2020 5:49 PM > > To: devel@edk2.groups.io; Dong, Guo > > Cc: Ma, Maurice ; You, Benjamin > > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH V2 0/1] UefiPayloadPk= g: Remove PEI phase > > from Payload > > > > Guo: > > This is a feature. So, please submit BZ for it. > > > > And, the first version patch is sent before soft feature freeze, and= got > > comments. > > Then, the second version patch is sent and got reviewed after soft f= eature > > freeze. > > > > Based on > > https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreez= e, > > this patch can't catch this stable tag. > > > > If you really want to catch this patch for this stable tag, please s= pecify > > your reason. > > I will collect the community feedback and decide whether delay this = stable > > tag. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67620+4905953+8761045@grou= ps.io > > > =E4=BB=A3=E8=A1=A8 Gu= o Dong > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=8817=E6= =97=A5 5:59 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Dong, Guo ; gaoliming > > > > > > =E6=8A=84=E9=80=81: Ma, Maurice ; You, Benjami= n > > > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: = Remove PEI phase > > > from Payload > > > > > > > > > Hi Liming, > > > > > > This patch is sent before the soft freeze and passed review. > > > I would like to merge this patch into edk2-stable202011 tomorrow if = there > > is > > > no additional feedback. > > > > > > And here is the PR and it passed all CI checks. > > > https://github.com/tianocore/edk2/pull/1127 > > > > > > Thanks, > > > Guo > > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of Guo > > > Dong > > > > Sent: Sunday, November 15, 2020 5:35 PM > > > > To: devel@edk2.groups.io > > > > Cc: Ma, Maurice ; You, Benjamin > > > > > > > > Subject: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI ph= ase > > > from > > > > Payload > > > > > > > > Hi All, > > > > > > > > This patch removed UEFI payload PEI phase to make UEFI payload sim= ple. > > > > It uses UefiPayloadEntry module to bridge bootloader and DXE phase= . > > > > > > > > Original DSC files UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc > > > > are replaced by a single DSC UefiPayloadPkg.dsc. Pure IA32 support > > > > is replaced by Pure X64 support. IA32 Entry point with X64 DXE pha= se > > > > is still supported. > > > > > > > > Changes in V2: > > > > Addressed all the review comments from Maurice. > > > > Fixed debug msg in UefiPayloadEntry. > > > > Updated the Handoff HOB to DXE core to include Payload FV. > > > > Synced the GHCB changes from DxeIpl to UefiPayloadEntry. > > > > > > > > V1: > > > > It is not necessary to have a PEI phase in the UEFI payload since = no > > > > specific PEI task is required. This patch adds a UefiPayloadEntry > > > > driver to get UEFI Payload required information from the bootloade= rs, > > > > convert them into a HOB list, load DXE core and transfer control t= o it. > > > > > > > > Here is the change details: > > > > 1) Removed PEI phase, including Peicore, BlSupportPei, SecCore, et= c. > > > > 2) Added UefiPayloadEntry driver. this is the only driver before D= XE > > core. > > > > 3) Added Pure X64 support, dropped Pure IA32 (Could add later if > > required) > > > > 64bit payload with 32bit entry point is still supported. > > > > 4) Use one DSC file UefiPayloadPkg.dsc to support X64 and IA32X64 = build. > > > > Removed UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc > > > > > > > > Tested with SBL and coreboot on QEMU. > > > > > > > > Refs: https://github.com/tianocore/edk2/pull/1127 > > > > > > > > CC: maurice.ma@intel.com > > > > CC: benjamin.you@intel.com > > > > Signed-off-by: Guo Dong > > > > > > > > Guo Dong (1): > > > > UefiPayloadPkg: Remove PEI phase from Payload > > > > > > > > UefiPayloadPkg/BlSupportPei/BlSupportPei.h | 39 - > > > > UefiPayloadPkg/BlSupportPei/BlSupportPei.inf | 73 -- > > > > UefiPayloadPkg/BuildAndIntegrationInstructions.txt | 32 +- > > > > UefiPayloadPkg/Include/Library/BlParseLib.h | 4 +- > > > > UefiPayloadPkg/Library/HobLib/Hob.c | 706 > > > ++++++++++++++++ > > > > UefiPayloadPkg/Library/HobLib/HobLib.inf | 39 + > > > > UefiPayloadPkg/SecCore/FindPeiCore.c | 193 ----- > > > > UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm | 78 -- > > > > UefiPayloadPkg/SecCore/Ia32/Stack.nasm | 72 -- > > > > UefiPayloadPkg/SecCore/SecCore.inf | 58 -- > > > > UefiPayloadPkg/SecCore/SecMain.c | 288 ------- > > > > UefiPayloadPkg/SecCore/SecMain.h | 131 --- > > > > UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 365 ++++++++ > > > > .../UefiPayloadEntry/Ia32/IdtVectorAsm.nasm | 71 ++ > > > > UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm | 46 + > > > > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 307 +++++++ > > > > UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c | 201 +++++ > > > > .../UefiPayloadEntry.c} | 451 ++++----= -- > > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 134 +++ > > > > .../UefiPayloadEntry/UefiPayloadEntry.inf | 93 ++ > > > > UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 107 +++ > > > > UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm | 47 ++ > > > > .../UefiPayloadEntry/X64/VirtualMemory.c | 939 > > > > +++++++++++++++++++++ > > > > .../UefiPayloadEntry/X64/VirtualMemory.h | 330 ++++++++ > > > > UefiPayloadPkg/UefiPayloadPkg.dec | 5 +- > > > > ...efiPayloadPkgIa32X64.dsc =3D> UefiPayloadPkg.dsc} | 57 +- > > > > UefiPayloadPkg/UefiPayloadPkg.fdf | 32 +- > > > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 585 > > > ------------- > > > > 28 files changed, 3576 insertions(+), 1907 deletions(-) > > > > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.h > > > > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.inf > > > > create mode 100644 UefiPayloadPkg/Library/HobLib/Hob.c > > > > create mode 100644 UefiPayloadPkg/Library/HobLib/HobLib.inf > > > > delete mode 100644 UefiPayloadPkg/SecCore/FindPeiCore.c > > > > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm > > > > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/Stack.nasm > > > > delete mode 100644 UefiPayloadPkg/SecCore/SecCore.inf > > > > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.c > > > > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.h > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c > > > > create mode 100644 > > > > UefiPayloadPkg/UefiPayloadEntry/Ia32/IdtVectorAsm.nasm > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm > > > > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c > > > > rename UefiPayloadPkg/{BlSupportPei/BlSupportPei.c =3D> > > > > UefiPayloadEntry/UefiPayloadEntry.c} (52%) > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c > > > > create mode 100644 > > > UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.h > > > > rename UefiPayloadPkg/{UefiPayloadPkgIa32X64.dsc =3D> > > > UefiPayloadPkg.dsc} > > > > (90%) > > > > delete mode 100644 UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > > > > > -- > > > > 2.16.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >