From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by mx.groups.io with SMTP id smtpd.web08.37081.1614008591640178913 for ; Mon, 22 Feb 2021 07:43:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=XtM8j2Mk; spf=pass (domain: 9elements.com, ip: 209.85.210.53, mailfrom: patrick.rudolph@9elements.com) Received: by mail-ot1-f53.google.com with SMTP id b8so12343984oti.7 for ; Mon, 22 Feb 2021 07:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fMsHy03tVwffa/azd1E0eFhkCNQ95Al62cDStuPq1W0=; b=XtM8j2MkgP1T8gIlXwYcyebsRdseMpeXJgQMBUXr24rNadxGLwB60z6Dcja/cBDXIt vEjSzi1ktYpeeqyXxI0dRgGwPsZarDXEsx2bIQ7ld9KufQtYNDqNsyb0tmlcb0BKaGs2 BWymk1jKri/aZIUI7myCUW9uQPKfLShOZPYL/3mvjPWlxeD8d09ozK3dPWc2eliUG/Do hCzy5Mbcadj6tO/LvTNBg5GoYDCPiDVsqwGRFdbZclcEvpcSr+W0djDl+zgz2Ehp7U9s fnX08Uy6sWJ3giqr29aoQ3W5dfMyl2X7ZKxLMO5wqiWKXnaQtvZdJvZWB3C0z+HvnMPC L0DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fMsHy03tVwffa/azd1E0eFhkCNQ95Al62cDStuPq1W0=; b=qfFqHEu7Sp/RvSQkhsP1a7VR9TCDS9OcYikdkLqr375FxBSI3DC5jLb+hfGHV+xOT7 0RLXzYicgGkJEABObGbl5Zt7BumfaIjy2mmFjAxcgL+Vc3kndn+oGYhnyzZSIO6Wf/kE ENn0AnUGPlnV/+KKinrORrjPVi/1IpTtP9R4Sy11062+Ep0H51Cu3ZAztoGzUz79B5sN cI8Vsx3T0ALn/Wgh2u0AsLUH5tskuhlgBDAJ4+d14ym14HDFnJEleEirjhFvWhTloBCe s4mH42ih41XAR3/+AfQ/14f4+V22b0xKjmTg/3uv0sGc9OL7wB/pKoFypZuH+m+VscoP KetA== X-Gm-Message-State: AOAM532zVZeC25M/XarxA4Z/yh7M+KTYsZOjjSuGT4e9K9hxFjLjsL4P k0SXnaAwQJpWczzccvjaZFzc1eIcBuyTCH/ndCogNA== X-Google-Smtp-Source: ABdhPJwPO8PU1b7PR0h4SR4KiIPSqm0eBi9SZcisrU1chof1QSXTLOSFBmr0k6SeHovtZiO85PGaEG5LLY5rJ5vdmTk= X-Received: by 2002:a9d:6c6:: with SMTP id 64mr8884545otx.78.1614008590997; Mon, 22 Feb 2021 07:43:10 -0800 (PST) MIME-Version: 1.0 References: <20210215051308.11796-1-guo.dong@intel.com> In-Reply-To: From: "Patrick Rudolph" Date: Mon, 22 Feb 2021 16:42:59 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA To: "Dong, Guo" Cc: "devel@edk2.groups.io" , "Ma, Maurice" , "You, Benjamin" Content-Type: text/plain; charset="UTF-8" Hi Guo, I tested on 078400ee15e7b250e4dfafd840c2e0c19835e16b and run it in QEMU. The problem seems to be here, as gdt is allocated > 4GiB: gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt; Regards, Patrick On Mon, Feb 22, 2021 at 3:59 PM Dong, Guo wrote: > > > Hi Patrick, > Please make sure you are using latest master when testing this patch. > That issue should be fix be this patch: > UefiCpuPkg/CpuDxe: Fix boot error (commit: ebfe2d3eb5ac7fd92d74011edb31303a181920c7) > And there is similar fix in another place as below: > UefiCpuPkg/MpInitLib: Fix a hang in above 4GB case (commit: edd74ad3ad79b855f76d9cf60a96c405cb3e863b) > > Thanks, > Guo > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Patrick > > Rudolph > > Sent: Monday, February 22, 2021 7:04 AM > > To: devel@edk2.groups.io; Ma, Maurice > > Cc: Dong, Guo ; You, Benjamin > > > > Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > 4GB memory WA > > > > This patch breaks booting on master. > > In CpuDxe.efi / InitGlobalDescriptorTable as the GDT pointer is casted > > to 32bits. > > > > Regards, > > Patrick > > > > On Fri, Feb 19, 2021 at 3:12 AM Ma, Maurice wrote: > > > > > > Reviewed-by: Maurice Ma > > > > > > Regards > > > Maurice > > > > > > > -----Original Message----- > > > > From: Dong, Guo > > > > Sent: Sunday, February 14, 2021 21:13 > > > > To: devel@edk2.groups.io > > > > Cc: Ma, Maurice ; You, Benjamin > > > > > > > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > > > > 4GB memory WA > > > > > > > > Previous it would hang in CpuDxe if DXE drivers are dispatched above 4GB. > > > > Now remove the work around since the fixed in CpuDxe are merged. > > > > > > > > Signed-off-by: Guo Dong > > > > --- > > > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 5 ----- > > > > 1 file changed, 5 deletions(-) > > > > > > > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > > > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > > > index 805f5448d9..c403b0a80a 100644 > > > > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > > > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > > > > @@ -40,11 +40,6 @@ MemInfoCallback ( > > > > EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | > > > > EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE; > > > > > > > > - if (Base >= BASE_4GB ) { > > > > - // Remove tested attribute to avoid DXE core to dispatch driver to > > > > memory above 4GB > > > > - Attribue &= ~EFI_RESOURCE_ATTRIBUTE_TESTED; > > > > - } > > > > - > > > > BuildResourceDescriptorHob (Type, Attribue, > > > > (EFI_PHYSICAL_ADDRESS)Base, Size); > > > > DEBUG ((DEBUG_INFO , "buildhob: base = 0x%lx, size = 0x%lx, type = > > > > 0x%x\n", Base, Size, Type)); > > > > > > > > -- > > > > 2.16.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > >