From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by mx.groups.io with SMTP id smtpd.web11.21187.1680169668102014298 for ; Thu, 30 Mar 2023 02:47:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=d+lck3dk; spf=pass (domain: 9elements.com, ip: 209.85.219.173, mailfrom: patrick.rudolph@9elements.com) Received: by mail-yb1-f173.google.com with SMTP id j7so22729731ybg.4 for ; Thu, 30 Mar 2023 02:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1680169667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s9zXLKyWQhGtV5w24LIDeT0ur//RXPThu4ATtHUffcc=; b=d+lck3dkLb5ETGpqRG5IdlucoXq6yJREMLOqHXp3s/moNP4g1iSm3cD1gOQxNVVykS PIMvkGX8l2Lj6M8+OqKHvrlzFXt33tuKfDyd2IQlIVVNDpSjKP4Vfsv9pvl/RMhxkETX HZ476FtGbI3ZZxBCdhRcocZZEuQsHAfUzvR4MN09drFqFL1wplV3/hgBdI0GPmkarVkG Dk3husayG9kDmo0kgrWy57//ZECG3yL8ZGPZymzIb5N+XHolt58vJE6c8/XVVS+NuJNL ipGooFxuqvBusMQTMJDyM4Ixcz6toRRXxrxcQo4ldjOIM7blfKf8GMTjAAgxF4sKwCnl xsgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680169667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s9zXLKyWQhGtV5w24LIDeT0ur//RXPThu4ATtHUffcc=; b=kdb+dfR6sY15sgkhHySTnDAflI97AP2OXkDUuHEqxCmBsHCa2lxTcu4p4fA65mlHbK 3aX5XMsD8hIkk76Koscya07iXjGkkUvQoA4foKKkYD3A6ANfNMj4tGpF9A2n4p5GA2kQ D0TD9Fh5sxusE9KfruHzIiEjd1uRaijngOeWV4mSbfTwVXSZjvCNLpdt27Mk2YqkjDZu Z6L3vGPCgH8Mt/scrdSihJqN6undlJnh4QjNAI9yLqnMLHoDZrHckOWXhlLjshRL6srK zKK6aUnR64V4j7esNHGtxKpzmbror3Hxylwdzz9sh4wfqQ9QyIVrj2xnW0KRqrKyrriK EZnw== X-Gm-Message-State: AAQBX9dH3/h8xwkMnqW/blA0biP4+uD5rhx8ytcaS5yVm1v4/7QW01Df /AMr5ueqX65y9csqJgvflOopcT1qTqTwfRz7TjQ/gg== X-Google-Smtp-Source: AKy350Ygf0d3y2ugVsmk6q3DC92UuD8A+AK+Mh19BDanezx9NTJBk/2xOM1BAogmnMtbG9QMS44+WaF1HeBgB3j77l0= X-Received: by 2002:a05:6902:72e:b0:b6c:f26c:e5ab with SMTP id l14-20020a056902072e00b00b6cf26ce5abmr15593907ybt.3.1680169667166; Thu, 30 Mar 2023 02:47:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Patrick Rudolph" Date: Thu, 30 Mar 2023 11:47:35 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32 To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: Lean Sheng Tan , devel@edk2.groups.io, gaoliming@byosoft.com.cn, rebecca@bsdio.com, "Feng, Bob C" , yuwei.chen@intel.com, gua.guo@intel.com, james.lu@intel.com, ardb@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Marvin, will send out a new patch series. Regards, Patrick Rudolph On Thu, Mar 30, 2023 at 10:05=E2=80=AFAM Marvin H=C3=A4user wrote: > > Hi Lean, > > I don=E2=80=99t think individual patches from a series are merged general= ly. Your 2/3 has open concerns from both Liming and myself. > > Best regards, > Marvin > > On 30. Mar 2023, at 09:31, Lean Sheng Tan wrote= : > > =EF=BB=BF > HI Liming, > If no further concern, would you mind to help get this patch merged? > Thanks! > > Best Regards, > Lean Sheng Tan > > > On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io wrote: >> >> Reviewed-by: Liming Gao >> >> > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Patrick >> > Rudolph >> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B43=E6=9C=8817=E6=97= =A5 22:06 >> > =E6=8A=84=E9=80=81: devel@edk2.groups.io; guo.dong@intel.com; gua.guo@= intel.com; >> > james.lu@intel.com; ray.ni@intel.com; mhaeuser@posteo.de; >> > ardb@kernel.org >> > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def:= Fix linking using >> > CLANGDWARF_IA32 >> > >> > The clang toolchain might default to fPIE/fPIC, which prevents >> > lld from linking the objects into a binary. >> > >> > Specify -fno-pie -fno-pic as done on GCC to fix linking. >> > >> > Test: >> > Building the Universal Payload using the command >> > 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually >> > works. >> > >> > Signed-off-by: Patrick Rudolph >> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4356 >> > --- >> > BaseTools/Conf/tools_def.template | 14 +++++++------- >> > 1 file changed, 7 insertions(+), 7 deletions(-) >> > >> > diff --git a/BaseTools/Conf/tools_def.template >> > b/BaseTools/Conf/tools_def.template >> > index 471eb67c0c..9b59bd75c3 100755 >> > --- a/BaseTools/Conf/tools_def.template >> > +++ b/BaseTools/Conf/tools_def.template >> > @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS >> > =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22 >> > *_CLANGDWARF_IA32_RC_PATH =3D >> > DEF(CLANGDWARF_IA32_PREFIX)llvm-rc >> > >> > >> > >> > *_CLANGDWARF_IA32_ASLCC_FLAGS =3D DEF(GCC_ASLCC_FLAGS) >> > -m32 -fno-lto DEF(CLANG38_IA32_TARGET) >> > >> > -*_CLANGDWARF_IA32_ASLDLINK_FLAGS =3D >> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=3Dlld >> > >> > +*_CLANGDWARF_IA32_ASLDLINK_FLAGS =3D >> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=3Dlld >> > -no-pie >> > >> > *_CLANGDWARF_IA32_ASM_FLAGS =3D DEF(GCC5_ASM_FLAGS) >> > -m32 -march=3Di386 DEF(CLANG38_IA32_TARGET) >> > >> > *_CLANGDWARF_IA32_RC_FLAGS =3D >> > DEF(GCC_IA32_RC_FLAGS) >> > >> > *_CLANGDWARF_IA32_OBJCOPY_FLAGS =3D >> > >> > @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS >> > =3D -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0x22 >> > *_CLANGDWARF_IA32_ASLPP_FLAGS =3D DEF(GCC_ASLPP_FLAGS) >> > DEF(CLANG38_IA32_TARGET) >> > >> > *_CLANGDWARF_IA32_VFRPP_FLAGS =3D DEF(GCC_VFRPP_FLAGS) >> > DEF(CLANG38_IA32_TARGET) >> > >> > >> > >> > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 >> > DEF(CLANG38_IA32_TARGET) -g -malign-double >> > >> > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=3Di5= 86 >> > DEF(CLANG38_IA32_TARGET) -g -malign-double >> > >> > DEBUG_CLANGDWARF_IA32_DLINK_FLAGS =3D >> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386 >> > -Wl,--oformat,elf32-i386 >> > >> > -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld >> > >> > +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld -no-pie >> > >> > >> > >> > -RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=3Di586 >> > DEF(CLANG38_IA32_TARGET) -malign-double >> > >> > +RELEASE_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=3Di5= 86 >> > DEF(CLANG38_IA32_TARGET) -malign-double >> > >> > RELEASE_CLANGDWARF_IA32_DLINK_FLAGS =3D >> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386 >> > -Wl,--oformat,elf32-i386 >> > >> > -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld >> > >> > +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=3Dlld -no-pie >> > >> > >> > >> > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=3Di586 >> > DEF(CLANG38_IA32_TARGET) -g -malign-double >> > >> > +NOOPT_CLANGDWARF_IA32_CC_FLAGS =3D >> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=3Di586 >> > DEF(CLANG38_IA32_TARGET) -g -malign-double >> > >> > NOOPT_CLANGDWARF_IA32_DLINK_FLAGS =3D >> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386 >> > -Wl,--oformat,elf32-i386 >> > >> > -NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=3Dlld >> > >> > +NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =3D >> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=3Dlld -no-pie >> > >> > >> > >> > ########################## >> > >> > # CLANGDWARF X64 definitions >> > >> > -- >> > 2.39.1 >> > >> > >> > >> > -=3D-=3D-=3D-=3D-=3D-=3D >> > Groups.io Links: You receive all messages sent to this group. >> > View/Reply Online (#101340): >> > https://edk2.groups.io/g/devel/message/101340 >> > Mute This Topic: https://groups.io/mt/97673648/4905953 >> > Group Owner: devel+owner@edk2.groups.io >> > Unsubscribe: https://edk2.groups.io/g/devel/unsub >> > [gaoliming@byosoft.com.cn] >> > -=3D-=3D-=3D-=3D-=3D-=3D >> > >> >> >> >> >> >>=20 >> >>