From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mx.groups.io with SMTP id smtpd.web12.5266.1610004023362130111 for ; Wed, 06 Jan 2021 23:20:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=ZJajt+rc; spf=pass (domain: 9elements.com, ip: 209.85.210.51, mailfrom: patrick.rudolph@9elements.com) Received: by mail-ot1-f51.google.com with SMTP id x13so5433630oto.8 for ; Wed, 06 Jan 2021 23:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3hAqwxVYQHzMj75zNSWEoRc+Mh+U/I4W+T1Ey9PvreY=; b=ZJajt+rcOfBPY/VcdhWakVIwGZ1QTjWyqhuezWrim5WJ0+stSEqtli33HJ1Yi/CPCX Iz1CSvW3Xkh3o4BKG3+CSXIfor4oI8rv62yR3zP7367eVm8zzYqyHKdvtTYbdb4dbYbJ aZyFQOu8DU+Qyd8XGsztHzAK5GapLH/jQ/4ylXoFxZv8d55Amye0CC6JBMEVx3iQM81n 8onp9fYEurjnvBdoeSvg5jjpxyxmZvyLSd/GUVl/KEiAXZ0oMUg/cbPoXAHtNChSiKs4 TnUEVkYCH2dlDBjsgZoUzGC3Ao7kI/HgGsWksjjL6t54leimiqefVs6v6hAo0FYnqt2c Vp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3hAqwxVYQHzMj75zNSWEoRc+Mh+U/I4W+T1Ey9PvreY=; b=bFRsaPo0+1JJ4ROz6n6cul5VBRFvpGBch/NKGSv2cjyuV3CaThQG388MQCfoo5FjaU 77utVGTiQ/GaRBEHwzw8UBxg6Ij4FwPVm7pivCMR3a7a2kYwaNCr+UC09Gx6Z2Sg5t5c Cb/boekqP2WCZe7qkhcrFApMQR+NhW2VaUE4FtKJXciTFqXS11cAdK1/NgljFQelwBUI q4nKtZwRto/HP0cURETb1rY5zroXqgeqTf2TSbmONxW09ec3jgwhdwtUZBOLaQClkdRD Q6bKRnFmcnrAC7FZ9BnGAoNt+S49oXghJvX+0UiAIDesOOvLkOnn/WF3z9P2YpC/+OfP iNOg== X-Gm-Message-State: AOAM533wAfOCoYWp56FdubvlvG3FXYqir5Nle9UVVYNuRxVwEE/B0quL dtcdInZDatSUhVjeCX8DezHsNxu1+WDHTZymKf69Nw== X-Google-Smtp-Source: ABdhPJzJDHlLm4kU9RIBoVUS++XjzXkB63/1SWUz2YtljKiaJG29Op2rWYkupQDIF3YvTZD9APTj3quG0dwG9X83ZQE= X-Received: by 2002:a05:6830:1e7a:: with SMTP id m26mr5880181otr.78.1610004022734; Wed, 06 Jan 2021 23:20:22 -0800 (PST) MIME-Version: 1.0 References: <20210106150830.11110-1-patrick.rudolph@9elements.com> <20210106150830.11110-2-patrick.rudolph@9elements.com> In-Reply-To: From: "Patrick Rudolph" Date: Thu, 7 Jan 2021 08:20:11 +0100 Message-ID: Subject: Re: [PATCH 1/2] UefiPayloadPkg: Enable boot logo To: "Dong, Guo" Cc: "devel@edk2.groups.io" , "Ma, Maurice" , "You, Benjamin" Content-Type: text/plain; charset="UTF-8" Hi Guo, Yes, the clear screen will remove the boot logo, if any, displayed by the bootloader. The EDK2 user that builds UefiPayloadPkg needs to add the bootloader logo as part of the build process to keep this boot logo displayed. It might be possible to keep the bootloader's boot logo by adding an ACPI BGRT parser in the BlSupportDxe. Regards, Patrick Rudolph On Wed, Jan 6, 2021 at 11:30 PM Dong, Guo wrote: > > > Hi Patrick, > > I didn't look at the impl details. If the logo is shown from the bootloader, how it would be impacted in payload phase? > I saw you have clearscreen in this patch. Does it only move the logo to center of the screen? > > Thanks, > Guo > > > -----Original Message----- > > From: Patrick Rudolph > > Sent: Wednesday, January 6, 2021 8:08 AM > > To: devel@edk2.groups.io > > Cc: Ma, Maurice ; Dong, Guo ; > > You, Benjamin > > Subject: [PATCH 1/2] UefiPayloadPkg: Enable boot logo > > > > From: Tim Crawford > > > > Signed-off-by: Patrick Rudolph > > --- > > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > | 3 +++ > > > > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > > | 1 + > > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ > > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > > 4 files changed, 8 insertions(+) > > > > diff --git > > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > index c5c6af0abc..2df2d5a02d 100644 > > --- > > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > +++ > > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > > @@ -216,6 +216,9 @@ PlatformBootManagerAfterConsole ( > > Black.Blue = Black.Green = Black.Red = Black.Reserved = 0; > > > > White.Blue = White.Green = White.Red = White.Reserved = 0xFF; > > > > > > > > + gST->ConOut->ClearScreen (gST->ConOut); > > > > + BootLogoEnableLogo (); > > > > + > > > > EfiBootManagerConnectAll (); > > > > EfiBootManagerRefreshAllBootOption (); > > > > > > > > diff --git > > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > > nf > > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > > nf > > index 1f5a0bcad0..beba973a70 100644 > > --- > > a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > > nf > > +++ > > b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i > > nf > > @@ -39,6 +39,7 @@ > > UefiRuntimeServicesTableLib > > > > UefiLib > > > > UefiBootManagerLib > > > > + BootLogoLib > > > > PcdLib > > > > DxeServicesLib > > > > MemoryAllocationLib > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > > b/UefiPayloadPkg/UefiPayloadPkg.dsc > > index ae62a9c4d6..1a084c479e 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > > @@ -169,6 +169,7 @@ > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > > > > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/ > > DxeSecurityManagementLib.inf > > > > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM > > anagerLib.inf > > > > + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > > > > > > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customiz > > edDisplayLib.inf > > > > > > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBlt > > Lib.inf > > > > > > > > @@ -389,6 +390,7 @@ > > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > > > > UefiCpuPkg/CpuDxe/CpuDxe.inf > > > > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > > > + MdeModulePkg/Logo/LogoDxe.inf > > > > MdeModulePkg/Application/UiApp/UiApp.inf { > > > > > > > > > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > > b/UefiPayloadPkg/UefiPayloadPkg.fdf > > index a97ace7395..98d3fdea4a 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > > @@ -112,6 +112,8 @@ INF > > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > > INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf > > > > > > > > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > > > +INF MdeModulePkg/Logo/LogoDxe.inf > > > > + > > > > # > > > > # PCI Support > > > > # > > > > -- > > 2.26.2 >