From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by mx.groups.io with SMTP id smtpd.web10.6162.1613652208339177423 for ; Thu, 18 Feb 2021 04:43:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=hLA3PSlV; spf=pass (domain: 9elements.com, ip: 209.85.210.49, mailfrom: patrick.rudolph@9elements.com) Received: by mail-ot1-f49.google.com with SMTP id c16so1749086otp.0 for ; Thu, 18 Feb 2021 04:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wPw4JydX6H9fHMfyy9/GEr6JXmC5n9qHIVlGRpmi2XE=; b=hLA3PSlVRu6Pb2SmZ8nJSFIOerUzpmhS0ca8lLaC1f1eF/YQSRAd/NM/DSj3bb9a+H 6kbS63rW0rkMDKN9GCEf4yv6xcAktEouD+2xWnQZNX+NOShGEPJ1WgzIt+ZdJNkIEwuD EJJQSqYFYfV98l4YzpjSf03sbFgNNPx6HFWhBPbf2Mz73q1v65IhVLP2MP8v7hRJuuyl 1n6ua8h2JBz6kthLNE255LShMsdfKrkWFXpSVxFIl7O9jJcKoLEEMb2gZRLNhon7T+ep tZyPxfcEqkct5EipiFEOdNEAuC7pgAspglRoLxNeFn6IPrkWfcU05tfhiwlGzbNfgY4h ie5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wPw4JydX6H9fHMfyy9/GEr6JXmC5n9qHIVlGRpmi2XE=; b=FYIZMp+Av+K40biZo34x1HXCuFpyLXubwwR6uUk+cwLOMXfNiV8iq3/riAy1yf5hAn GQHeZOp0ri2vii0CiT+QPDEnVXmSZZcappQnU7AH9o4doznOX0HQcedRhrYu50Xmhp63 BPR7rT/y5fFqKRDFc1gVv6sB8TobgX8m6LlitLO+rf6+zbyWwMnjgApmXcxADsnt3GMm yC1103HroG4mYgsKzIaZXDX5W47YqC64BawAtmTThIxg8hRkngrrhlvqsznFPdIBZTv5 GCVmt0A/DtE7ZjrL2gsZ2qJuhs04j7qu5qND/D2yzdBHXL0271B6byP2kP0SRKY99JZf g/nA== X-Gm-Message-State: AOAM530ilL53r+2idu//d6NQp+SQ7tTdQwXzMrkRADlG/og7EMVEjgjj uGsWyoObJ5P8osQtxonzSFo5jh7DV5JxEoiBvhWcqQ== X-Google-Smtp-Source: ABdhPJwXx4RngK4/R02WhOifkwC9oHlL6q+kaFrqX9I7z9WMsp+NaCwzrRue28VtsMZpXX8azLGFAYMAXpjU1gsSmUI= X-Received: by 2002:a9d:618a:: with SMTP id g10mr2231570otk.34.1613652207710; Thu, 18 Feb 2021 04:43:27 -0800 (PST) MIME-Version: 1.0 References: <20210217101032.2822164-1-patrick.rudolph@9elements.com> <000c01d705a6$a0366b70$e0a34250$@byosoft.com.cn> In-Reply-To: <000c01d705a6$a0366b70$e0a34250$@byosoft.com.cn> From: "Patrick Rudolph" Date: Thu, 18 Feb 2021 13:43:16 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen To: gaoliming Cc: devel@edk2.groups.io, tcrawford@system76.com, "Wang, Jian J" , "Wu, Hao A" , zhichao.gao@intel.com, "Ni, Ray" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Please find the issue created here: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3226 On Thu, Feb 18, 2021 at 4:32 AM gaoliming wrote: > > Patrick: > I am OK for this extension to meet with Microsoft recommendation. This > change is a new feature. Can you submit one BZ > (https://bugzilla.tianocore.org/) for it? > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71716+4905953+8761045@groups.= io > > =E4=BB=A3=E8=A1=A8 Patri= ck > > Rudolph > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8817=E6=97= =A5 18:11 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: tcrawford@system76.com; jian.j.wang@intel.com; > > hao.a.wu@intel.com; zhichao.gao@intel.com; ray.ni@intel.com > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogo= Lib: Center > > logo 38.2% from top of screen > > > > From: Tim Crawford > > > > Use Microsoft's recommended positioning [1] for the boot logo. > > > > > We recommend that the logo is placed with its center at 38.2% from th= e > > > screen's top edge. This positioning is based on the golden ratio's > > > visual aesthetics and matches the Windows 10 design proportions. > > > > [1]: > > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-= s > > creen-components#position-the-logo-during-post > > > > Based on Tim Crawford initial commit. > > > > Signed-off-by: Patrick Rudolph > > --- > > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- > > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4 ++++ > > MdeModulePkg/Logo/Logo.c | 2 +- > > 3 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h > > b/MdeModulePkg/Include/Protocol/PlatformLogo.h > > index 55c9e08696..21a4c79e1d 100644 > > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h > > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h > > @@ -29,7 +29,8 @@ typedef enum { > > EdkiiPlatformLogoDisplayAttributeCenterBottom, > > > > EdkiiPlatformLogoDisplayAttributeLeftBottom, > > > > EdkiiPlatformLogoDisplayAttributeCenterLeft, > > > > - EdkiiPlatformLogoDisplayAttributeCenter > > > > + EdkiiPlatformLogoDisplayAttributeCenter, > > > > + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended > > > > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; > > > > > > > > /** > > > > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > index 134660f28d..d40c65b59f 100644 > > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > > @@ -173,6 +173,10 @@ BootLogoEnableLogo ( > > DestX =3D 0; > > > > DestY =3D (SizeOfY - Image.Height) / 2; > > > > break; > > > > + case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended: > > > > + DestX =3D (SizeOfX - Image.Width) / 2; > > > > + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; > > > > + break; > > > > case EdkiiPlatformLogoDisplayAttributeCenter: > > > > DestX =3D (SizeOfX - Image.Width) / 2; > > > > DestY =3D (SizeOfY - Image.Height) / 2; > > > > diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > > index c647253ecd..131a1b456a 100644 > > --- a/MdeModulePkg/Logo/Logo.c > > +++ b/MdeModulePkg/Logo/Logo.c > > @@ -26,7 +26,7 @@ EFI_HII_HANDLE mHiiHandle; > > LOGO_ENTRY mLogos[] =3D { > > > > { > > > > IMAGE_TOKEN (IMG_LOGO), > > > > - EdkiiPlatformLogoDisplayAttributeCenter, > > > > + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended, > > > > 0, > > > > 0 > > > > } > > > > -- > > 2.26.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#71716): https://edk2.groups.io/g/devel/message/7171= 6 > > Mute This Topic: https://groups.io/mt/80700289/4905953 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [gaoliming@byosoft.com.cn] > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > >