From: "Patrick Rudolph" <patrick.rudolph@9elements.com>
To: sean@starlabs.systems
Cc: Ray <ray.ni@intel.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PlatformGopPolicy
Date: Mon, 28 Feb 2022 09:08:03 +0100 [thread overview]
Message-ID: <CALNFmy3BSAM2OBP=mu+ty_R8wkx339GFrKLATj4qV1WvvE2bvw@mail.gmail.com> (raw)
In-Reply-To: <11011.1645998382884236997@groups.io>
Hi Sean,
1. This patch only works with the Intel binary EFI Option ROM (GOP
driver) that's not part of this repository, as already mentioned.
2. The name USE_PLATFORM_GOP is miss-leading, I'd prefer something
with BINARY and INTEL in it's name.
That it needs the PLATFORM_GOP protocol is just a side effect.
3. Also it looks like this is platform specific code, which should be
part of edk2-platforms.
4. You should be able to use the VBT in DRAM. There's a pointer in the
ASLS register on PCI device 00:02.0.
Regards,
Patrick Rudolph
On Sun, Feb 27, 2022 at 10:46 PM Sean Rhodes <sean@starlabs.systems> wrote:
>
> Sorry - missed this reply.
>
> It should be passed in from coreboot - https://review.coreboot.org/c/coreboot/+/61798
>
> Thanks
>
> Sean
>
prev parent reply other threads:[~2022-02-28 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 22:24 [PATCH] UefiPayloadPkg: Add PlatformGopPolicy Sean Rhodes
2022-02-14 21:59 ` [edk2-devel] " Guo Dong
2022-02-16 6:47 ` Ni, Ray
2022-02-27 21:46 ` Sean Rhodes
2022-02-28 8:08 ` Patrick Rudolph [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALNFmy3BSAM2OBP=mu+ty_R8wkx339GFrKLATj4qV1WvvE2bvw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox