From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mx.groups.io with SMTP id smtpd.web10.17632.1646035695274162488 for ; Mon, 28 Feb 2022 00:08:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=V9wDVIjz; spf=pass (domain: 9elements.com, ip: 209.85.215.180, mailfrom: patrick.rudolph@9elements.com) Received: by mail-pg1-f180.google.com with SMTP id t14so7813252pgr.3 for ; Mon, 28 Feb 2022 00:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BaAYTCyD2u4qJcd3H0rnsHHIvYl52mlHokrm1CogXno=; b=V9wDVIjzjrsMXki3R+pPD2dBmK9DAgswdsZBUJFdhzOJNiwKI8pmlgfX89t6iI++Yl mDz7xUnFUDTJYV38Qj2Jr/HFTHNtzpSdZKSIpWxJ7Kuki4kMDYO4MQ2PA6PB0mV7tNH2 +IMoUCRGbfQ9Ny0N7FnDC6kPSvoOTeSqlrNUUcb6fFeBwpPHm3wFSUphgNBWcRlTImj0 LrrMQHP0GcpGgWjUOyN2nTAAKrMZfotHiEtqhel48nI2UH41WuPWyunoetALYnd7z6Bw HvZmCxoE8olJs7ejVNG+j7cGHpplBEoIbpBdB2KyNgE26gTv/lBCYSlLzFY/0kpLJpKx nrkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BaAYTCyD2u4qJcd3H0rnsHHIvYl52mlHokrm1CogXno=; b=dAEpAKJAjnbvaQu6D6ZEu40xiyxLGZHEJBrqxjW6jln4lL51nWZWRvS/0kxMcqbCPl 85mWRe8wgk4iFaKVU3jzpdklCGG/8Z4DoiD6GJleDDjs9Jav2+DcerUqdKOWf/lhNRM9 PBiKOw+8eRvFF1SKYAhxiqmtbXkb3Od4bLfVi+uyJlcNy94P46q5dSW33pAPVb8bhetK +6TorSJ5t8aFzVPslO7mGjJzH8ZT4kvNuE1xchf0ulc/JJkfZ8NsL4RyKrdH8iyfCG4M kP/FoKa+LtDPCNVQ3L1CvBQJyhLhA+I2xYrHYkc9PjLGGwnz8gac3qP6u5xwTw999xuq Bw3w== X-Gm-Message-State: AOAM5304YTSjIT5qRuPK7RIA9sophVds8elwbmImpaucAy/38/jECWcH lZ/4A0lI1DcbGPZ9ayCoqh9uuKWR4T0/HJVgcszcWw== X-Google-Smtp-Source: ABdhPJzI4kj/3cSm9EgJ9LBQLpeeOznXcO0u5k9t5sm+Hb1dc7w9A/RoZelHcAsqe9sHnlwf5Q6ai0sDwr1TxeJjc6c= X-Received: by 2002:a05:6a00:2341:b0:4e1:5aa4:9aff with SMTP id j1-20020a056a00234100b004e15aa49affmr20549173pfj.8.1646035694797; Mon, 28 Feb 2022 00:08:14 -0800 (PST) MIME-Version: 1.0 References: <11011.1645998382884236997@groups.io> In-Reply-To: <11011.1645998382884236997@groups.io> From: "Patrick Rudolph" Date: Mon, 28 Feb 2022 09:08:03 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PlatformGopPolicy To: sean@starlabs.systems Cc: Ray , devel@edk2.groups.io Content-Type: text/plain; charset="UTF-8" Hi Sean, 1. This patch only works with the Intel binary EFI Option ROM (GOP driver) that's not part of this repository, as already mentioned. 2. The name USE_PLATFORM_GOP is miss-leading, I'd prefer something with BINARY and INTEL in it's name. That it needs the PLATFORM_GOP protocol is just a side effect. 3. Also it looks like this is platform specific code, which should be part of edk2-platforms. 4. You should be able to use the VBT in DRAM. There's a pointer in the ASLS register on PCI device 00:02.0. Regards, Patrick Rudolph On Sun, Feb 27, 2022 at 10:46 PM Sean Rhodes wrote: > > Sorry - missed this reply. > > It should be passed in from coreboot - https://review.coreboot.org/c/coreboot/+/61798 > > Thanks > > Sean >