From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by mx.groups.io with SMTP id smtpd.web11.7273.1612347954517886563 for ; Wed, 03 Feb 2021 02:25:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=CPUVCSEv; spf=pass (domain: 9elements.com, ip: 209.85.167.176, mailfrom: patrick.rudolph@9elements.com) Received: by mail-oi1-f176.google.com with SMTP id k25so26198309oik.13 for ; Wed, 03 Feb 2021 02:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mLOGKGh9WETeX1UW7UeCl3WLadpOOY6pxZhkQY2AO2E=; b=CPUVCSEvx9viwdEg9RNfH7t6wU3CtaXq7fXwfQPGxlI+UcEv7O+zIVqhLLySj7pXFb JWNqIImCEpQ8vo0OWH0aLOzkwi4EBEBPtU4e914DQyLfC0Xuw495b8N4yH+U2OzjhYCv Rs7aCjojk5MtHSdtEP8xtVzOOT5Hf8AAIZyu7plSkZYkMNDLgKc3xpr+8IhYZw5ks7xi I/PB2urXIfrBzL8cW3KvG2/cnYoW+ygz4XDSgsVs82FipzwWWgzLP9k1Bfp8lGS21imZ Yg8H/s8HbqLlQ6B/+0qUsI/h/+SWle2P7TVyYwwZvlr1AzLCqYFq4SRV+ITJSx9dg2gN S94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mLOGKGh9WETeX1UW7UeCl3WLadpOOY6pxZhkQY2AO2E=; b=Rgb88IheKTlS+FEDdhlIT3g+2vXMd2DIayY4UrTTNxwKKrEYa8hfwRYWK/XkYyHbY8 0o2bTTPlnyRu/9yDvsS3ijWiqfKELDKNRs+ATS7W4g0DC0/wW637c4oUH91k8swL2Iq4 F0QffxVx26zIaAGoZSYyIXcitc47z7Q/gQomcxwPpCjZ/RK6MNDyu/5jSuRWcwOCeF56 uCcAg84H7W/O7RzsXTXTcX1WUpECBwbnQMLeCInoF8qIT2aUheYW80gEve3wi6wMHcN8 OH4/R0tdTNBgpPU11u4CXUiIun2CHywdCsLfbtN0o4xkoGSES1dHp6FTfqumInKZQdIJ Z6IQ== X-Gm-Message-State: AOAM531jqa8uOIn9iNOWEIx5uCAZ8sJeK5XQ3kupRmGDGOMI/IA2irCm KCn2nfIpoFkVL9shwq636ml5flxS4FWpAlpcHOWUhA== X-Google-Smtp-Source: ABdhPJx32l7zXyOH6Ofc/5kGaNhC0VzwuKmcxOod/CPWHRlXjX0kWV/xYQfFfcDo5vpgp1Pyra6dJDEylklZ1k8On9c= X-Received: by 2002:aca:5315:: with SMTP id h21mr1566961oib.58.1612347953846; Wed, 03 Feb 2021 02:25:53 -0800 (PST) MIME-Version: 1.0 References: <20210202083352.581971-1-patrick.rudolph@9elements.com> In-Reply-To: From: "Patrick Rudolph" Date: Wed, 3 Feb 2021 11:25:42 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connect console after EndOfDxe To: "Wang, Sunny (HPS SW)" Cc: "devel@edk2.groups.io" , "aiden.park@intel.com" , "benjamin.you@intel.com" , "philipp.deppenwiese@9elements.com" , "maurice.ma@intel.com" , "guo.dong@intel.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sunny, none of the other packages are doing this before EndOfDxe. And there's no point in having trusted console as earlier as possible, as nothing is displayed in PlatformBootManagerBeforeConsole(). Please explain your use case. I don't see one here. Kind Regards, Patrick Rudolph On Wed, Feb 3, 2021 at 10:32 AM Wang, Sunny (HPS SW) w= rote: > > Hi Patrick, > > I'm not familiar with UefiPayloadPkg. However, since we may want to enab= le the trusted console as earlier as possible, you may still need to keep t= he PlatformConsoleInit() call at the beginning of PlatformBootManagerBefore= Console() to support the platform that has trusted/on-board Consoles. > > Regards, > Sunny Wang > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Patrick R= udolph > Sent: Tuesday, February 2, 2021 4:34 PM > To: devel@edk2.groups.io > Cc: aiden.park@intel.com; benjamin.you@intel.com; philipp.deppenwiese@9e= lements.com; maurice.ma@intel.com; guo.dong@intel.com > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/PlatformBootManager: Connec= t console after EndOfDxe > > Currently the console is connected before EndOfDxe causing OptionsROMs t= o be loaded, but their drivers aren't used and thus no GOP is installed. > > To make use of 3rdparty OptionROMs connect the console after EndOfDxe. > > Tested on Intel CFL board using Nvidia Quadro GPU. > > Signed-off-by: Patrick Rudolph > --- > UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 4= ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootM= anager.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage= r.c > index c5c6af0abc..7fa3a048b7 100644 > --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.= c > +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. > +++ c > @@ -157,8 +157,6 @@ PlatformBootManagerBeforeConsole ( > EFI_INPUT_KEY Down; > EFI_BOOT_MANAGER_LOAD_OPTION BootOption; > > - PlatformConsoleInit (); > - > // > // Register ENTER as CONTINUE key > // > @@ -192,6 +190,8 @@ PlatformBootManagerBeforeConsole ( > // Dispatch deferred images after EndOfDxe event and ReadyToLock inst= allation. > // > EfiBootManagerDispatchDeferredImages (); > + > + PlatformConsoleInit (); > } > > /** > -- > 2.26.2 > > > >=20 > >