From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: canonical.com, ip: 91.189.89.112, mailfrom: dann.frazier@canonical.com) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by groups.io with SMTP; Fri, 27 Sep 2019 07:02:58 -0700 Received: from mail-ot1-f69.google.com ([209.85.210.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iDqpk-00044W-3O for devel@edk2.groups.io; Fri, 27 Sep 2019 14:02:56 +0000 Received: by mail-ot1-f69.google.com with SMTP id i8so1392181otc.19 for ; Fri, 27 Sep 2019 07:02:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z+Iy+HDHf5nu9+gWrTTSc+pJCK9sO/uSFQt+/PJ0tt8=; b=W6HlgH6XUSRs3CmCyV3rRmvUzbLMDx2Gd64rqndpAPuJXt+nWhvA9TFSn6DO6NGij4 /B5RiPreREhO0oRYqNW9u6JqwWCj6bTn+wSf6Qs3Kl10+CaZhre5NUyuk51q0ORFkzLg 75y36kY0saHhI9rxivp5WufYBc44UWJdAG/+QoK7K2YRoU7Pe9sXiW0N6LRzYiEln6+6 ZG1en8xElpThzl05AbpyruPgFnFkUwZCmKzaaSL1WMuFkTeA+qKkuT+pA8Ojlz9n0UIh At1pfgq5r41CE2nGZMR/l6bXHIYodyHBlHr2OXhXM4zwWJS4yW57+pvAo5fUBO7W10Vp ZOiA== X-Gm-Message-State: APjAAAU2Ufwaz+vN/qEZmgjMzteGHLOMMddT4Leustxxl9rpsqw9WgxW 9ajceh4Yefjy82BI3XcCHOwdjVlX1AQ46qiOZTcCS95AcCVrolPzjxIAgINu8aEWqPYLUlT3K0I KeixxSMnygzBqyfiLGGLNJd7sdLjJJKOsnfOESIDv2GHFz/o= X-Received: by 2002:a05:6808:7cd:: with SMTP id f13mr7298311oij.6.1569592974883; Fri, 27 Sep 2019 07:02:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqztOkFGy0zcMZn0hVKDkD3Sz0I2zRAoPxT5xF67YJ6Nrky6yN4/5TAzFt704KnWVqfQ7hVkzB7rK+lR/nGcgzg= X-Received: by 2002:a05:6808:7cd:: with SMTP id f13mr7298280oij.6.1569592974533; Fri, 27 Sep 2019 07:02:54 -0700 (PDT) MIME-Version: 1.0 References: <20190927113523.25424-1-bob.c.feng@intel.com> In-Reply-To: <20190927113523.25424-1-bob.c.feng@intel.com> From: "dann frazier" Date: Fri, 27 Sep 2019 08:02:43 -0600 Message-ID: Subject: Re: [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst To: "Feng, Bob C" Cc: devel@edk2.groups.io, Liming Gao Content-Type: text/plain; charset="UTF-8" On Fri, Sep 27, 2019 at 5:35 AM Feng, Bob C wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2216 > > This patch is going to fix the lib order in static_library_files.lst. > This issue is introduced by commit 673d09a2dd. > Before 673d09a2dd, build tool apply build rule for the module's library > firstly and then apply build rule for module itself. Now, build tool > apply build rule for module self and then for its library. That behavior > impact the lib order in static_library_files.lst. > > This patch is to call module's LibraryAutoGenList function > explicitly, where the applying build rule action for > library is triggered. > > Cc: Liming Gao > Cc: dann frazier > Signed-off-by: Bob Feng Thanks Bob! Confirmed fixes my issue. Tested-by: dann frazier -dann > --- > BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > index fad5bab0f24d..f0812b6887be 100755 > --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py > @@ -1841,11 +1841,11 @@ class ModuleAutoGen(AutoGen): > LibraryAutoGen.CreateCodeFile() > > # CanSkip uses timestamps to determine build skipping > if self.CanSkip(): > return > - > + self.LibraryAutoGenList > AutoGenList = [] > IgoredAutoGenList = [] > > for File in self.AutoGenFileList: > if GenC.Generate(File.Path, self.AutoGenFileList[File], File.IsBinary): > -- > 2.20.1.windows.1 >