From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web10.3973.1670376293332674931 for ; Tue, 06 Dec 2022 17:24:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@canonical.com header.s=20210705 header.b=djTgmGHW; spf=pass (domain: canonical.com, ip: 185.125.188.122, mailfrom: dann.frazier@canonical.com) Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 03A5944344 for ; Wed, 7 Dec 2022 01:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1670376292; bh=HQhqMjEYKkkcXSpU3HbsjTZ0BNDe9D20JA+OLuQIp10=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=djTgmGHWzjvtvF4v6UwOMhIzC3HocipSGABn2HEpWXJvn1flipte1SyTlWRlErfeL vp2j6dBeLZ0qskmadchUOpoMFCJxTl/jmEtrbAE6jc/LYjg5rmxT25Vsw4OYSvGypX fSyuK3XdzCkEQhynXDs0ufYQN6avJhjelgFrkYk5EqUCU9ZsHM1mIENReKdBQqMmLN NT7xV1X68TOrrgRD8xDv/2MGPI7DrR5iv7LQwy+UNicyq1CudTLTsBIY7qFpGDD1JZ soXjFAlo0U/vURNxr3yBg+vIoX2RCBhpJeUnd6spkXlhXQZgkx91AyeBc2IuUAkytC e1HLg/+ctLvYQ== Received: by mail-il1-f199.google.com with SMTP id i11-20020a056e02152b00b00303642498daso5446134ilu.5 for ; Tue, 06 Dec 2022 17:24:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQhqMjEYKkkcXSpU3HbsjTZ0BNDe9D20JA+OLuQIp10=; b=dTIIIxcfaINCCUrWL4E9RdcahVx3FwoNYpvGXkGFSggpbfbabtwVlfucaRGF9Ez53r 0vbd6I2pbaBGfhmJKQ+9pmjTXgz6D23CaagX01HEIG5bo47TWaKe3OAhWF9yh6VIL5uh QKCNdIVaVrVqsgx2MH+PRk7NMNWvE6hiqwa8faOQnU41vJiSzVcCDKlUSNytSj4clWTP Pe9GiYd3QS479WZ43jSVH2Usbtui4yFN9UxQ2wb9ARm+r7s0qOrKWyi1kG2QLHLgH9e3 JZ14rlY6eiQzF4Ea8MBNHRppvXFV732nw+3G1JIZsmPurlDrWlcuA87oGClcz7vjGJCo Aaow== X-Gm-Message-State: ANoB5pm5K5e9QOi7H9aRBXUIiq285IxE5U7LrKcLXBiULuv3PkMwtEWp fpFEZQDya/wUBCSN4Ujw46bvIVJPW3DSmJ7Iqd7c+bII59oi3SXUTyrMkiRm+uHNtZIl+2Uh6D8 TjDHCF9QdrOl9/EmYBeQQWiKolgGDPm6shCHODqkFbyxqSj4= X-Received: by 2002:a05:6602:8c7:b0:6d9:f871:7b20 with SMTP id h7-20020a05660208c700b006d9f8717b20mr32793317ioz.152.1670376289921; Tue, 06 Dec 2022 17:24:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf6q2Gzfut0l7tOdER/LhIk1vqRXIQRKrvVsVMKLRp48UNdc8FvXcgZLsObY1o3tn+9pocOH7zUL5Fc8/MmJUDQ= X-Received: by 2002:a05:6602:8c7:b0:6d9:f871:7b20 with SMTP id h7-20020a05660208c700b006d9f8717b20mr32793302ioz.152.1670376289644; Tue, 06 Dec 2022 17:24:49 -0800 (PST) MIME-Version: 1.0 References: <039201d909d7$2681f510$7385df30$@byosoft.com.cn> In-Reply-To: <039201d909d7$2681f510$7385df30$@byosoft.com.cn> From: "dann frazier" Date: Tue, 6 Dec 2022 18:24:38 -0700 Message-ID: Subject: Re: [edk2-devel] feature flag change notifications To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: "Kinney, Michael D" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liming, Thank you, that is appreciated. Going forward I'll let you know if I trip over any not already documented. -dann On Tue, Dec 6, 2022 at 5:59 PM gaoliming via groups.io wrote: > > Dann: > I base on new features to collect the incompatible changes, and add the= m into the updated notes. > > If you find any missing, please send the mail to me. > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B412=E6=9C=886=E6=97= =A5 9:22 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; dann.frazier@canonic= al.com; Gao, Liming > > > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] feature flag change notifications > > > > Hi Dann, > > > > These are reasonable requests. > > > > Adding Liming Gao who is currently responsible for the edk2 releases. > > > > Let's start with release notes and see if some of these can be added > > to the release documentation and add to the edk2 release process > > to clearly note these type of changes in future release notes. > > > > As far as #error and #warn. Those are possible, but we would need > > to do some analysis for the types of changes that would require > > that behavior. Your examples are useful as a starting point. > > > > Once concern is how many of those #error/#warn conditions will > > build up over time and then a process to remove them after an > > expiration period. > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of dann > > frazier > > > Sent: Monday, December 5, 2022 4:10 PM > > > To: devel@edk2.groups.io > > > Subject: [edk2-devel] feature flag change notifications > > > > > > Hi, > > > I maintain the edk2 packages in the Debian and Ubuntu > > > distributions. A few times over the years I've had users report > > > regressions that turned out to be due to upstream build flag > > > changes. I wonder if it would be possible for upstream to communicate > > > such changes - either via release notes or, where possible, as > > > build-time checks - to us downstream projects. Here are the examples = I > > > recall: > > > > > > > commit 4de8d61bcec02a13ceed84f92b0cf3ea58adf9c5 > > > > Author: Gerd Hoffmann > > > > Date: Wed Dec 15 12:39:20 2021 +0100 > > > > > > > > OvmfPkg: rework TPM configuration > > > > > > > > > > For this I needed to change -DTPM_ENABLE=3DTRUE to > > -DTPM2_ENABLE=3DTRUE. I > > > feel like a build-time check would've been a good way to communicate > > > this one, e.g.: > > > > > > #ifdef TPM_ENABLE > > > #error TPM_ENABLE has been renamed to TPM2_ENABLE > > > #endif > > > > > > > commit 1631bb26ae991e530d3c96fe3161ea15144b358e > > > > Author: Gary Lin > > > > Date: Mon Jun 10 14:55:09 2019 +0800 > > > > > > > > OvmfPkg/README: Update the network build flags > > > > > > > > The following network build flags changed due to the inclusion = of > > > > NetworkPkg/Network.fdf.inc. > > > > > > > Similar to the above, I needed to deal with this by setting > > > -DNETWORK_HTTP_BOOT_ENABLE=3DTRUE instead of > > -DHTTP_BOOT_ENABLE=3DTRUE. It > > > seems like maybe an #error on the removed #define could've helped > > > here as well. > > > > > > And finally: > > > > > > > commit 57783adfb579da32b1eeda77b2bec028a5e0b7b3 > > > > Author: Michael D Kinney > > > > Date: Tue Jul 26 12:40:00 2022 -0700 > > > > > > > > OvmfPkg: Change default to disable MptScsi and PvScsi > > > > > > With this types of change, it would be useful just to know this is > > > coming and why so I can decide to either notify users of the change > > > and/or override the default to avoid the regression. Would it be > > > possible to describe such changes in the release notes at > > > https://github.com/tianocore/edk2/releases - and, if not urgent, > > > perhaps #warn of deprecation in the source for one stable release > > > cycle? > > > > > > -dann > > > > > > > > > > > > > > > > > >=20 > >