From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mx.groups.io with SMTP id smtpd.web11.5113.1572548124724428359 for ; Thu, 31 Oct 2019 11:55:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=SPF record not found (domain: canonical.com, ip: 91.189.89.112, mailfrom: dann.frazier@canonical.com) Received: from mail-ot1-f69.google.com ([209.85.210.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iQFbO-0007ZU-Rx for devel@edk2.groups.io; Thu, 31 Oct 2019 18:55:22 +0000 Received: by mail-ot1-f69.google.com with SMTP id 9so4134905otc.21 for ; Thu, 31 Oct 2019 11:55:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LKSyapd3jA3IiBQyFhrdZhS81rqcYs0ZG5ddsiqFHZs=; b=c2qRzKRN6+yOXajwKkZFDK4qCBuczwpoQ0PLx/e0zJ3TOTEYgsSOhC23EBQOwRPpVC OTyKo8dThIHZv+3Kz/RjAJAyfdvghE9W+EhchLmyZD4OLC5F2ocnGLuKdToafBVxhvLg /TzB4KgS7hG2BuWqBHmc2y/rB3rw89oaPUd3x36ad/Vye44Xr4yOSSnVFeoVEoTZjbuf Mrwn2jRFEr0T8jjj9VkfmDiKcNRg1RyvkfWfTsqx+UwJr5t08i1cL43dK66wFkyYSdXD Aqlk0mPwsq2pA5Qkz0tPbZg0pcnfdrBUHnLqh9aDZXpWss+cZcOuWWuNd1oQ7AYW8++A IqoA== X-Gm-Message-State: APjAAAX/hFyaoUzCBNfN8yFU2xqh1twIZ+YEZAaE/2+PIoFAV+qaWLHb fOkZ7Ptb0sqMOVx76LAHenIaxffWiF0ub8RRJCMTrO/8Ze7MxRgRjEY0ZWvQa2BQYZj07miKTwi ULyAuFoPEREbI1DSK7zPRSjjsKFgFfY/2cDkSdsS9S7oySuk= X-Received: by 2002:aca:c6c6:: with SMTP id w189mr995779oif.124.1572548121667; Thu, 31 Oct 2019 11:55:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOR4MYaXyChMj0b/Nnft8aGsuckOlUqN22LGvndAEewTe7uY4r1L1Txh7la9xb3rRQ64f485OC59Qt/P0i3gY= X-Received: by 2002:aca:c6c6:: with SMTP id w189mr995744oif.124.1572548121191; Thu, 31 Oct 2019 11:55:21 -0700 (PDT) MIME-Version: 1.0 References: <2b268378-d9be-adb5-f139-a0ca8dab4329@redhat.com> <20191031121642.GA16820@bivouac.eciton.net> In-Reply-To: <20191031121642.GA16820@bivouac.eciton.net> From: "dann frazier" Date: Thu, 31 Oct 2019 12:55:10 -0600 Message-ID: Subject: Re: [edk2-devel] How /sys/firmware/fdt getting created To: Leif Lindholm Cc: Laszlo Ersek , devel@edk2.groups.io, prabhakar.pkin@gmail.com, Ard Biesheuvel , naresh.bhat@linaro.org Content-Type: text/plain; charset="UTF-8" On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm wrote: > > On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > > +Leif, comment at bottom > > Thanks Laszlo. +Dann, -kexec. > > > On 10/30/19 09:16, Prabhakar Kushwaha wrote: > > >> So if you want to add these properties, you should add them there. > > >> > > >> Can you explain why doing this is necessary? > > > > > > I am trying to test kexec -p (kdump feature) on CentOS-release > > > 7.7.1908 and Ubuntu-18.04 distributions. > > > > > > "kexec -p" command show error on Ubuntu. While no error on CentOS > > > > > > CentOS: > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initramfs-`uname > > > -r`.img --reuse-cmdline > > > $ ==> No error > > > > > > Ubuntu > > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initrd.img-`uname > > > -r` --reuse-cmdline > > > $ kexec: elfcorehdr doesn't fit cells-size. > > > $ kexec: setup_2nd_dtb failed. > > > $ kexec: load failed. > > > $ Cannot load /boot/vmlinuz-5.4.0-rc4+ > > > > > > Note: Both CentOS and Ubuntu has Linux-5.4-rc4 tag. > > > > > > When i debugged further reason for Ubuntu error is due to > > > address-cells and size-cells as "1" > > > log from kexec tool :- > > > load_crashdump_segments: elfcorehdr 0x7f7cbfc000-0x7f7cbff7ff > > > read_1st_dtb: found name =dtb_sys /sys/firmware/fdt > > > get_cells_size: #address-cells:1 #size-cells:1 > > > > > > On CentOS both values are "2". > > > log from kexec tool :- > > > load_crashdump_segments: elfcorehdr 0xbf98bf0000-0xbf98bf33ff > > > read_1st_dtb: found nmae=dtb_sys /sys/firmware/fdt > > > get_cells_size: #address-cells:2 #size-cells:2 > > > > > > Note: Kexec tool read values from /sys/firmware/fdt. > > > > > > I am trying to figure out why 2 distributions showing different values. > > > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=347210a5d5ce655b95315f320faa515afb723c11 > > > > Ubuntu probably ships a grub version that lacks this commit. > > Yes, it came after the 18.04 release. > Dann: given that 18.04 is LTS, would it be reasonable to cherry-pick > this grub patch? I would consider the behaviour without it to be a > bug. Leif, Likely - I'll run some tests and get back to you... -dann > / > Leif > > > (The commit was first released as part of upstream grub-2.04. I have no > > idea what version of grub is shipped in the CentOS distro you mention > > above -- it could be based upon upstream 2.04, or the upstream patch may > > have been backported to CentOS.) > > > > Thanks > > Laszlo > >