From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82D16941D97 for ; Tue, 28 Jan 2025 22:07:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nkA8SPkjAXaGxVtnNwRg1Cmx4g+0YJjWgsa5G3/H5DA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1738102022; v=1; x=1738361221; b=FGeDAp2LGNu2uYlsODL6bc7Uui9sH0WCYedo8PZ61meRyoGzBpZMZyirDZgmOrjrQcUoQkex 2qZLtasmVpa1rpaFDnoDO08HhBF3lcB0uGYyHKkKFpD25lqRfPvYoVFxDxXWuvkaHXvRK1vvuRu XuObbuWkee9TAbFB/qHv8et6c70wOWAZmYOcplJqsgY8tMb/47z/Sm1lW5c8cH9BNvfHQW4cYYM HTELScPRJHxqQJWiX70eR4zeesCaK8AjkHPbH0Yi3q16aUDBLb/DiCt1OZdBGE5zYp06PLawFwg yDc8gPHJ7D6QRYf3MXSmI9KpTLR8VW6mFiPIJQ1cUDmsw== X-Received: by 127.0.0.2 with SMTP id mbPqYY7687511xvSSpQaCRmZ; Tue, 28 Jan 2025 14:07:01 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.36435.1737524197415685242 for ; Tue, 21 Jan 2025 21:36:37 -0800 X-Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-s8xTJc6wO6ODnLDHUdy7Xw-1; Wed, 22 Jan 2025 00:36:34 -0500 X-MC-Unique: s8xTJc6wO6ODnLDHUdy7Xw-1 X-Mimecast-MFC-AGG-ID: s8xTJc6wO6ODnLDHUdy7Xw X-Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-851a991cf8bso30670539f.0 for ; Tue, 21 Jan 2025 21:36:34 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUQMburQdyelEsFTbwIdlqrvdg9j6Cllp1C4y41ezzcoqdhU8LYsCLOoKfH4ahCajAqZ6X1/g==@edk2.groups.io X-Gm-Message-State: tLZO3ab8sT3ull2zxXb4u2Six7686176AA= X-Gm-Gg: ASbGncvJtJ+0noQzuRqRq350nBmktBV/I7zDDkAlniU2txwvrZ8ORFY9AInHV3IGumx AnUfEqD/T4nGvPtfbodjfUDiugY2iMnvjJrGK4IQj7CKFGCe1Qhpc X-Received: by 2002:a05:6e02:b28:b0:3cd:e9a0:3c3d with SMTP id e9e14a558f8ab-3cf7479d52amr170082735ab.2.1737524193748; Tue, 21 Jan 2025 21:36:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1NteIeOEFSZQJMQta9H79qVzAVNQuPvHhvy/+a48GnvWI55kw2kVLGryRVDAv7Jiw553w+jC1f5oh5mpxImA= X-Received: by 2002:a05:6e02:b28:b0:3cd:e9a0:3c3d with SMTP id e9e14a558f8ab-3cf7479d52amr170082645ab.2.1737524193462; Tue, 21 Jan 2025 21:36:33 -0800 (PST) MIME-Version: 1.0 References: <20250108215957.3437660-1-usamaarif642@gmail.com> <20250108215957.3437660-2-usamaarif642@gmail.com> <8613563a-ee7c-4271-b1f0-4d1ac365ad3a@gmail.com> <138f28ec-341e-4c48-a14b-4371a8198de8@gmail.com> <029cff22-f2e0-4796-9c27-1df056e08f8f@gmail.com> In-Reply-To: From: "Dave Young via groups.io" Date: Wed, 22 Jan 2025 13:36:40 +0800 X-Gm-Features: AbW1kvasSuob105uOOtVQhAqqYFk9t9t0n8BzZ024DbzitZW85su35TvVCpG4fY Message-ID: Subject: Re: [edk2-devel] [RFC 1/2] efi/memattr: Use desc_size instead of total size to check for corruption To: Usama Arif Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, devel@edk2.groups.io, kexec@lists.infradead.org, hannes@cmpxchg.org, x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org, gourry@gourry.net, kernel-team@meta.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dcL8A08_Elm-HLStRy6wmZlgIjK3bMuIUK3NtGu_6UU_1737524194 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 28 Jan 2025 14:07:00 -0800 Resent-From: dyoung@redhat.com Reply-To: devel@edk2.groups.io,dyoung@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=FGeDAp2L; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, On Mon, 20 Jan 2025 at 19:48, Usama Arif wrote: > > > > On 20/01/2025 11:29, Ard Biesheuvel wrote: > > On Mon, 20 Jan 2025 at 11:50, Usama Arif wrote: > >> > >> > >> > >> On 20/01/2025 10:32, Ard Biesheuvel wrote: > >>> On Mon, 20 Jan 2025 at 11:27, Usama Arif wrote: > >>>> > >>>> > >>> ... > >>>> Hi Ard, > >>>> > >>>> Just wanted to check how should we proceed forward? Should we try and fix the warning > >>>> and corruption during kexec as done in this series or not initialize memory attributes > >>>> table at all in kexec boot? I would prefer fixing the issues as in this series. > >>>> > >>> > >>> I would prefer kexec boot on x86 to disregard the memory attributes > >>> table entirely. > >> > >> Would you like Dave to send something like > >> https://lore.kernel.org/all/CALu+AoS8tb=HgaybDw5OG4A1QbOXHvuidpu0ynmz-nE1nBqzTA@mail.gmail.com/ > >> on the mailing list (wrapped in ifdef CONFIG_X86_64) > >> > > > > I prefer this approach. and no need for the ifdef, this is x86 > > specific code, and the memory attributes table is already ignored > > entirely on 32-bit x86 iirc > > ah yes, I ignored the file name when reviewing it and just focused on the function :) > > Will wait for Dave to send it. Ok, I will add reported-by from you and suggested-by from Ard. But I can not test the efi mem attr, I'd prefer to have your test results first. Could you confirm that? Thanks Dave -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121056): https://edk2.groups.io/g/devel/message/121056 Mute This Topic: https://groups.io/mt/110517813/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-