From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B97A740032 for ; Wed, 15 Jan 2025 18:53:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WI7hTPHUFSYmDerVB6sVM5cYuV274qCTNf7HiQ0YwJc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1736967186; v=1; x=1737226385; b=fP4fB5ni+XVE1GE9UroCLbLYAiZVWqHanDWFNtgOr86kzYxp13ISN3M2Zd6VcY8t9lbcAtOg GVcwG2gY7bkj+17FZyAzYeotgIcrokp+MzGMuzdcsvnNLHbUshhjw1XojHRjPi14jWgNYuvfK9W 09JoMiDooDofbrCgbivD6OYSiZmIrRpSbwM0Y+YD+3JoBBSLNOFRMr7prRuCp9G2FOX61L/gpcn JKHSImdFSz7X9tWT1NeKdu9eJ1viOOCbynvbdFPDucloFPDLW8+H9skIqVDbo5xstgp0wCji1k0 F/MaJCiPodj6dfC5OkVymW4vi+JDAbAoQW2oFXDfL5WaA== X-Received: by 127.0.0.2 with SMTP id 9brmYY7687511xc1VCEW4ikJ; Wed, 15 Jan 2025 10:53:05 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.15937.1736507891874065325 for ; Fri, 10 Jan 2025 03:18:12 -0800 X-Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-sa4SUPzqPrGYZ-WQQyDG2g-1; Fri, 10 Jan 2025 06:18:08 -0500 X-MC-Unique: sa4SUPzqPrGYZ-WQQyDG2g-1 X-Mimecast-MFC-AGG-ID: sa4SUPzqPrGYZ-WQQyDG2g X-Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-3cdd61a97easo14118785ab.2 for ; Fri, 10 Jan 2025 03:18:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUOwRd8FhQcU9gzyzn7xatB/wi3thSnKuyU8lr9f4wL614BQn6Rdu3Bpch7fdxGQfaHemC0CA==@edk2.groups.io X-Gm-Message-State: sdzqKDPEsv6IQBKhbv4nHcfjx7686176AA= X-Gm-Gg: ASbGnctvgKVvoCANJNjHQ0zBX49VB7ZB4q/W7TWXyeRwwHUSeEjAx1K3F/5rGeD/s4r 4iiU4p7CTNomRzxKBrcTG6hYQ/WaO1ro2obFhflc= X-Received: by 2002:a05:6e02:3dc2:b0:3a7:8208:b847 with SMTP id e9e14a558f8ab-3ce3aa74516mr73500275ab.22.1736507887823; Fri, 10 Jan 2025 03:18:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGA7dAfrgLzkJ12E7/vbM/rmrd89W2Jgnoku0ZUGP83tR/OARctRAqpmJ70EkI7oznqyYN3kZfUJQheZWG8tPY= X-Received: by 2002:a05:6e02:3dc2:b0:3a7:8208:b847 with SMTP id e9e14a558f8ab-3ce3aa74516mr73500125ab.22.1736507887562; Fri, 10 Jan 2025 03:18:07 -0800 (PST) MIME-Version: 1.0 References: <20250108215957.3437660-1-usamaarif642@gmail.com> <20250108215957.3437660-3-usamaarif642@gmail.com> <4ed67e5b-c2ea-4dc3-b4c5-f8f112b0cd40@gmail.com> In-Reply-To: <4ed67e5b-c2ea-4dc3-b4c5-f8f112b0cd40@gmail.com> From: "Dave Young via groups.io" Date: Fri, 10 Jan 2025 19:18:12 +0800 X-Gm-Features: AbW1kvY3NgOP3VeQdRDz6rjTWoDkxnlxQ8g34ZJbAqB_EjoQkm5bJ2aQPEFf6e8 Message-ID: Subject: Re: [edk2-devel] [RFC 2/2] efi/memattr: add efi_mem_attr_table as a reserved region in 820_table_firmware To: Usama Arif Cc: linux-efi@vger.kernel.org, devel@edk2.groups.io, kexec@lists.infradead.org, ardb@kernel.org, hannes@cmpxchg.org, x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org, gourry@gourry.net, kernel-team@meta.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xpq1apZK3fDji0pLrFTGdkcQddqJgWb4NKK54eJqPmg_1736507888 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 Jan 2025 10:52:52 -0800 Resent-From: dyoung@redhat.com Reply-To: devel@edk2.groups.io,dyoung@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=fP4fB5ni; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 10 Jan 2025 at 19:12, Usama Arif wrote: > > > > On 10/01/2025 02:50, Dave Young wrote: > > Hi Usama, > > > > On Thu, 9 Jan 2025 at 06:00, Usama Arif wrote: > >> > >> When this area is not reserved, it comes up as usable in > >> /sys/firmware/memmap. This means that kexec, which uses that memmap > >> to find usable memory regions, can select the region where > >> efi_mem_attr_table is and overwrite it and relocate_kernel. > > > > Is the attr table BOOT SERVICE DATA? If so, does efi_mem_reserve() > > work for you? > > Just refer to esrt.c. > > > > Hi Dave, > > Its a bit difficult to reproduce the problem and therefore test the fix, but > we are seeing it a lot in production. Ard proposed the same thing in > https://lore.kernel.org/all/6b4780a5-ada0-405e-9f0a-4d2186177f29@gmail.com/ > but as I mentioned there, I dont think that efi_mem_reserve would help, > as efi_mem_reserve changes e820_table, while kexec looks at > /sys/firmware/memmap which uses e820_table_firmware. I sent a question to pm people, if the sysfs memmap comes from e820_table then it will be fine. Let's see: https://lore.kernel.org/all/CALu+AoS-nk4u=9UYP7BLS=diOxjJRf+vfv7KHXG=uXozoYazsw@mail.gmail.com/ > > Thanks, > Usama > > > Thanks > > Dave > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121009): https://edk2.groups.io/g/devel/message/121009 Mute This Topic: https://groups.io/mt/110518541/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-