From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C88A740034 for ; Wed, 15 Jan 2025 18:53:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wcimq5tHNAbmGOUcPmX02/RZCFg5nU+PjLJCJiI0W+o=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240830; t=1736967187; v=1; x=1737226386; b=KZLJCjizBwoDgR0uUujgW4QZLv4DUzFhxyWVgMJ0SFeBnh9YSZdF6tV/rTo1aAnMsle1Jjzp NK9eMZTAXR9OKHuyaPRYjYCmLfLCmanN7kyfTequ6VZ3e72ER96gIDjL3KLu++RBg0GU7jy11CP GtzuaQeCB1ZJLEr3SuE0CvyLEg2a8z5G6wK9qRuyDVY/o7O5Yb0SX5t9Pohbv7NV7Ex2ndgtYfJ OMCRbJbtEM2lTOuIU8TYUGAzosBOwUOZWu9oA2gB1ZjS0SJkg8C6ROWet1XXcICPZmbxYVoW13k dXnnEC6n9PZ3ct20itdLkQK9WBqAS5K6pOpzGzFA0JAeg== X-Received: by 127.0.0.2 with SMTP id ZsnfYY7687511x1gKBUkRw2m; Wed, 15 Jan 2025 10:53:06 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.15964.1736508041903719052 for ; Fri, 10 Jan 2025 03:20:42 -0800 X-Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-I_gybRbyOTeSr93n0uLl5A-1; Fri, 10 Jan 2025 06:20:37 -0500 X-MC-Unique: I_gybRbyOTeSr93n0uLl5A-1 X-Mimecast-MFC-AGG-ID: I_gybRbyOTeSr93n0uLl5A X-Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-3ce3a416d71so27225105ab.3 for ; Fri, 10 Jan 2025 03:20:36 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW7mA8/kZRs+/3xwOX37NfAfImJ2PzL4uLXefC2cd+nKmUo10y8rCmgKYq2M66m83Y1J/uHcw==@edk2.groups.io X-Gm-Message-State: RijiMkFx71Hj5DtJrchVtgF7x7686176AA= X-Gm-Gg: ASbGncveLAHbTdlGEhJDFgDetfjucM4ZfayEVHKR9YyMbPRv0w5JVWR92QiKoashhR9 J0yKiXTEWeSDe07qWRsHiy6V4/9i6cpBIpxys2v8= X-Received: by 2002:a05:6e02:19c6:b0:3a7:81a4:a54d with SMTP id e9e14a558f8ab-3ce3aa7c305mr88727865ab.20.1736508036322; Fri, 10 Jan 2025 03:20:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/ZGZxn93BTZUgwgl5385CpZFhIe8wtltjq3xgYCHF4KnVPQrulNtY+5TAzkMXX76hdNVwHy/TuoHO3lYD9qo= X-Received: by 2002:a05:6e02:19c6:b0:3a7:81a4:a54d with SMTP id e9e14a558f8ab-3ce3aa7c305mr88727725ab.20.1736508036092; Fri, 10 Jan 2025 03:20:36 -0800 (PST) MIME-Version: 1.0 References: <20250108215957.3437660-1-usamaarif642@gmail.com> <20250108215957.3437660-3-usamaarif642@gmail.com> <4ed67e5b-c2ea-4dc3-b4c5-f8f112b0cd40@gmail.com> In-Reply-To: From: "Dave Young via groups.io" Date: Fri, 10 Jan 2025 19:20:41 +0800 X-Gm-Features: AbW1kvbbbsAFGnLq07CQCS7hEathkhH1cwo6Bz0H1Eer0IQxRMwEsY9rVx_lHSM Message-ID: Subject: Re: [edk2-devel] [RFC 2/2] efi/memattr: add efi_mem_attr_table as a reserved region in 820_table_firmware To: Usama Arif Cc: linux-efi@vger.kernel.org, devel@edk2.groups.io, kexec@lists.infradead.org, ardb@kernel.org, hannes@cmpxchg.org, x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org, gourry@gourry.net, kernel-team@meta.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ElKsjZstw1qgCOgCAfDPn-qnwoDrs5OzD-QwZAs7IZA_1736508036 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 Jan 2025 10:52:52 -0800 Resent-From: dyoung@redhat.com Reply-To: devel@edk2.groups.io,dyoung@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=KZLJCjiz; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 10 Jan 2025 at 19:18, Dave Young wrote: > > On Fri, 10 Jan 2025 at 19:12, Usama Arif wrote: > > > > > > > > On 10/01/2025 02:50, Dave Young wrote: > > > Hi Usama, > > > > > > On Thu, 9 Jan 2025 at 06:00, Usama Arif wrote: > > >> > > >> When this area is not reserved, it comes up as usable in > > >> /sys/firmware/memmap. This means that kexec, which uses that memmap > > >> to find usable memory regions, can select the region where > > >> efi_mem_attr_table is and overwrite it and relocate_kernel. > > > > > > Is the attr table BOOT SERVICE DATA? If so, does efi_mem_reserve() > > > work for you? > > > Just refer to esrt.c. > > > > > > > Hi Dave, > > > > Its a bit difficult to reproduce the problem and therefore test the fix, but > > we are seeing it a lot in production. Ard proposed the same thing in > > https://lore.kernel.org/all/6b4780a5-ada0-405e-9f0a-4d2186177f29@gmail.com/ > > but as I mentioned there, I dont think that efi_mem_reserve would help, > > as efi_mem_reserve changes e820_table, while kexec looks at > > /sys/firmware/memmap which uses e820_table_firmware. > > I sent a question to pm people, if the sysfs memmap comes from > e820_table then it will be fine. Let's see: s/e820_table/e820_table_kexec > https://lore.kernel.org/all/CALu+AoS-nk4u=9UYP7BLS=diOxjJRf+vfv7KHXG=uXozoYazsw@mail.gmail.com/ > > > > > Thanks, > > Usama > > > > > Thanks > > > Dave > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121010): https://edk2.groups.io/g/devel/message/121010 Mute This Topic: https://groups.io/mt/110518541/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-