Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU

["Getnat Ejigu" <getnatejigu@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]

Okay, will do.

Thanks,
-Getnat

On Thu, Apr 29, 2021 at 11:33 PM Bret Barkelew <Bret.Barkelew@microsoft.com>
wrote:

> This change should also be made in:
>
>
> UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLibDebugLib.c
>
> UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLib.c
> (for the prototype)
>
>
>
> - Bret
>
>
>
> *From: *Getnat Ejigu <getnatejigu@gmail.com>
> *Sent: *Thursday, April 29, 2021 10:43 AM
> *To: *devel@edk2.groups.io
> *Cc: *Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> *Subject: *[EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit
> test hangs when running in OVMF/QEMU
>
>
>
> Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU
> environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI
> to ReportPrint() function that use VA_ARGS.
>
> Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
>  UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git
> a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> index cfb0c5972bd1..db5402d6a210 100644
> ---
> a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> +++
> b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
> @@ -12,6 +12,7 @@
>  #include <Library/DebugLib.h>
>
>
>
>  VOID
>
> +EFIAPI
>
>  ReportPrint (
>
>    IN CONST CHAR8  *Format,
>
>    ...
>
> --
> 2.25.1
>
>
>

[-- Attachment #2: Type: text/html, Size: 3473 bytes --]