From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by mx.groups.io with SMTP id smtpd.web12.13954.1619799151051028466 for ; Fri, 30 Apr 2021 09:12:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kN2BAw8i; spf=pass (domain: gmail.com, ip: 209.85.208.176, mailfrom: getnatejigu@gmail.com) Received: by mail-lj1-f176.google.com with SMTP id s25so881163lji.0 for ; Fri, 30 Apr 2021 09:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tuYY0NT/P/4ht+jw6F9pjVwlRE8IMnsbbKFO1pC7UJg=; b=kN2BAw8ivDxm3v7CzSir5uN7MmeMAMJ17STyGR1f4FuLE+/faDV83TUZvu8idqdweO jcIbVW9/HNHZu9556BG1oiuyxC2/1KtQartphXD7OPEBo4ElEVd71iOi1YZ98b9jpULr v78AzPyKA/RoUhq56Wq0RgCB6k6q53gcb9MZIChk8WyZqjpzyOTqOP9fjwUo3nQh/Ff3 FpH0PEl3YOMt7FlkfnsMiS0irIuf4e11rsqBZf2PZAvryshdDHGeH9kMiYDIJs4a7qeZ iGHzT++xxYxAOmN2CDUCSI7PU60XGVaQODqQ0zBgGO2tBYAmJQvpNxh8WL6KITl4h9BL 0fTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tuYY0NT/P/4ht+jw6F9pjVwlRE8IMnsbbKFO1pC7UJg=; b=frfrVh68an251Y+9wJEW1MP+e1pA8P6w6Db0KF6Ov1To+9mD5afAmH/hGTQg/TtM2q AlQkXODZXw2DMIN8EvU82w30xV3z1ElmtwgD20K4rt/utqkKX/EG1IGkyqYlAknvPI7H kBR+yshcZb5pXV29HzIaex1h+OYCbQfzR+N1GHfNqJSKexGZF42pLgWNupX6DozC1yGA s40jiUwd15DduwISULaZ0u7SgtTYtwlVC/Xh4PwfP0C+bcifRnTxqcz8Kts0eUDxhFUZ 81WC95s0WfURxU1xmNojoE+xBhmK8IWWNhSR1vbaAD1pZ6Fwrzz5Gsw3cfM6WdPqPl9G rI8A== X-Gm-Message-State: AOAM53114deoAU51Xz+wczyjEDxh/zOr8OAl0B4kQI0X0nKDoEXQwvSQ hH/H3ACOQq/lsmyxv6eTHO1UrTHiMt2ug9jIY9U= X-Google-Smtp-Source: ABdhPJwlteyz7521m8n0O58v6sXKownnGL634jwnN+aA+lWpXe3R3WRDbjJhFwX5hoHBV98fKupvD4Kus+u/ZqjjGbs= X-Received: by 2002:a2e:9707:: with SMTP id r7mr4475610lji.181.1619799149387; Fri, 30 Apr 2021 09:12:29 -0700 (PDT) MIME-Version: 1.0 References: <20210429174330.649415-1-getnatejigu@gmail.com> <20210429174330.649415-2-getnatejigu@gmail.com> In-Reply-To: From: "Getnat Ejigu" Date: Fri, 30 Apr 2021 12:12:18 -0400 Message-ID: Subject: Re: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU To: Bret Barkelew Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , Sean Brogan Content-Type: multipart/alternative; boundary="000000000000e8247705c132e0e7" --000000000000e8247705c132e0e7 Content-Type: text/plain; charset="UTF-8" Okay, will do. Thanks, -Getnat On Thu, Apr 29, 2021 at 11:33 PM Bret Barkelew wrote: > This change should also be made in: > > > UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLibDebugLib.c > > UnitTestFrameworkPkg\Library\UnitTestResultReportLib\UnitTestResultReportLib.c > (for the prototype) > > > > - Bret > > > > *From: *Getnat Ejigu > *Sent: *Thursday, April 29, 2021 10:43 AM > *To: *devel@edk2.groups.io > *Cc: *Kinney, Michael D ; Sean Brogan > ; Bret Barkelew > *Subject: *[EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit > test hangs when running in OVMF/QEMU > > > > Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU > environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI > to ReportPrint() function that use VA_ARGS. > > Signed-off-by: Getnat Ejigu > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Bret Barkelew > --- > UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > index cfb0c5972bd1..db5402d6a210 100644 > --- > a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > +++ > b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c > @@ -12,6 +12,7 @@ > #include > > > > VOID > > +EFIAPI > > ReportPrint ( > > IN CONST CHAR8 *Format, > > ... > > -- > 2.25.1 > > > --000000000000e8247705c132e0e7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay, will do.

Thanks,
-Getna= t

On Thu, Apr 29, 2021 at 11:33 PM Bret Barkelew <Bret.Barkelew@microsoft.com> wrote:

This change should also be made in:

UnitTestFrameworkPkg\Library\UnitTestResultReportLib= \UnitTestResultReportLibDebugLib.c

UnitTestFrameworkPkg\Library\UnitTestResultReportLib= \UnitTestResultReportLib.c (for the prototype)

=C2=A0

- Bret

=C2=A0

From: Getnat Ejigu
Sent: Thursday, April 29, 2021 10:43 AM
To: devel@= edk2.groups.io
Cc: = Kinney, Michael D; Sean Brogan; Bret Barkelew
Subject: [EXTERNAL] [PATCH v1 1/1] UnitTestFrameworkPkg: Sample unit= test hangs when running in OVMF/QEMU

=C2=A0

Sample unit tests in Un= itTestFrameworkPkg hangs when running in OVMF/QEMU
environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS.

Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
=C2=A0UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestR= esultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportL= ib/UnitTestResultReportLibConOut.c
index cfb0c5972bd1..db5402d6a210 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultRe= portLibConOut.c
@@ -12,6 +12,7 @@
=C2=A0#include <Library/DebugLib.h>

=C2=A0

=C2=A0VOID

+EFIAPI

=C2=A0ReportPrint (

=C2=A0=C2=A0 IN CONST CHAR8=C2=A0 *Format,

=C2=A0=C2=A0 ...

--
2.25.1

=C2=A0

--000000000000e8247705c132e0e7--