public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lean Sheng Tan via groups.io" <sheng.tan=9elements.com@groups.io>
To: "Witt, Sebastian" <sebastian.witt@siemens.com>
Cc: "Guo, Gua" <gua.guo@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "Rhodes, Sean" <sean@starlabs.systems>,
	"Lu, James" <james.lu@intel.com>,
	 "Dong, Guo" <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB
Date: Mon, 10 Jun 2024 17:28:24 +0200	[thread overview]
Message-ID: <CAMWxwJ0YQLrLPeCo28idDuODgbOMbuGs20aSNXQEpb1n-5O6Cw@mail.gmail.com> (raw)
In-Reply-To: <AM8PR10MB430679DC7C2BEF64144502129BFA2@AM8PR10MB4306.EURPRD10.PROD.OUTLOOK.COM>


[-- Attachment #1.1: Type: text/plain, Size: 3950 bytes --]

Hi Gua/ Dong Guo,
Do you know how to proceed?
https://github.com/tianocore/edk2/pull/5732
Does the patch submitter have to actively rebase its patch?

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng.tan@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>


On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian <sebastian.witt@siemens.com>
wrote:

> Done here: https://github.com/tianocore/edk2/pull/5732
>
>
>
> Regards,
>
> Sebastian
>
>
>
> *From:* Guo, Gua <gua.guo@intel.com>
> *Sent:* Wednesday, 5 June 2024 16:22
> *To:* Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io;
> Witt, Sebastian (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com>;
> Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>;
> Dong, Guo <guo.dong@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for
> payload size > 16MB
>
>
>
> Please send PR also.
> ------------------------------
>
> *From:* Lean Sheng Tan <sheng.tan@9elements.com>
> *Sent:* Wednesday, June 5, 2024 10:18:27 PM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian <
> sebastian.witt@siemens.com>; Guo, Gua <gua.guo@intel.com>; Rhodes, Sean
> <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <
> guo.dong@intel.com>
> *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for
> payload size > 16MB
>
>
>
> + edk2 payload maintainers
>
>
> Best Regards,
>
> *Lean Sheng Tan*
>
>
> [image: Image removed by sender.]
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
>
> Email: sheng.tan@9elements.com
>
> Phone: *+49 234 68 94 188 <+492346894188>*
>
> Mobile: *+49 176 76 113842 <+4917676113842>*
>
>
>
> Registered office: Bochum
>
> Commercial register: Amtsgericht Bochum, HRB 17519
>
> Management: Sebastian German, Eray Bazaar
>
>
> Data protection information according to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
>
>
>
> On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io
> <sebastian.witt=siemens.com@groups.io> wrote:
>
>
> Fix calculation of first section in FileFindSection for FILE2 headers in
> UefiPayloadEntry module.
>
> Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com>
> ---
>  UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
> b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
> index 898d610951..9cb6edefcf 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
> @@ -211,13 +211,14 @@ FileFindSection (
>
>    if (IS_FFS_FILE2 (FileHeader)) {
>      FileSize = FFS_FILE2_SIZE (FileHeader);
> +    Section = (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2
> *)FileHeader) + 1);
>    } else {
>      FileSize = FFS_FILE_SIZE (FileHeader);
> +    Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
>    }
>
>    FileSize -= sizeof (EFI_FFS_FILE_HEADER);
>
> -  Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
>    Index   = 0;
>    while (Index < FileSize) {
>      if (Section->Type == SectionType) {
> --
> 2.39.2
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119536): https://edk2.groups.io/g/devel/message/119536
Mute This Topic: https://groups.io/mt/106471262/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 13113 bytes --]

[-- Attachment #2: ~WRD0002.jpg --]
[-- Type: image/jpeg, Size: 823 bytes --]

  reply	other threads:[~2024-06-10 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-03 15:51 [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB Witt, Sebastian via groups.io
2024-06-05 14:18 ` Lean Sheng Tan
2024-06-05 14:22   ` Guo, Gua
2024-06-05 23:08     ` Guo Dong
2024-06-06 13:38     ` Witt, Sebastian via groups.io
2024-06-10 15:28       ` Lean Sheng Tan via groups.io [this message]
2024-06-10 15:31         ` Guo, Gua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMWxwJ0YQLrLPeCo28idDuODgbOMbuGs20aSNXQEpb1n-5O6Cw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox