From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E4A3B780091 for ; Mon, 10 Jun 2024 15:29:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sNCrHVLCEwm5ofa7SL+pHlgRxW5KtHyZ3rY656PMaCM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1718033345; v=1; b=ZwqjBnGWFSmCV+bYTki2v/jfM7qj2AndKQ3203K3oaYsWo3AF6gCLwSa+j62ICykqAq2RiF0 rzGukOZjnCR4GfdkKl0x5hPSA4oFjTYJZ0n5SdSj7FyH+4ypbzNYC3z86IbSaUc65TEstDOfaT6 +pidDq1TUV1NOGoKmByeFEJJju4oiDms27Ga0+yrTpM7N8/DTgxz5A9Nk46bTi5h7t/yCbPoH3Z AlZX0e19FUhKH5SIO1IQsX1WZ/VqWBRh9RjT60JAnftpeDtna1TbAr0tpB5DMnRj3K+15YYrr74 ygQ42OAjBjVFpED9HDfYPZ/my3nuHcMHh2E11T5/hbzxQ== X-Received: by 127.0.0.2 with SMTP id DmC0YY7687511xJULlWHZwOH; Mon, 10 Jun 2024 08:29:04 -0700 X-Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mx.groups.io with SMTP id smtpd.web11.22483.1718033343102097926 for ; Mon, 10 Jun 2024 08:29:03 -0700 X-Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57c73a3b3d7so2169666a12.1 for ; Mon, 10 Jun 2024 08:29:02 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX8W8r2qYQq4YHwZ6vq5sjx6Pv1uV72UAiPd/iw09J77ACEF/HyeWiHhtAeqMzp4d4q58afw8RdGynierpREPDA+CSCNQ== X-Gm-Message-State: Y9cpFlCAOv2EejIhxRQnMVUHx7686176AA= X-Google-Smtp-Source: AGHT+IFasO6nmC5A8Ksmna8ZwEes6mUH7zGpYicNTml26gwcxeBB7PSCcGsRJ3pWNiBXq52eX7c9WHCL9IjOOoXKeuI= X-Received: by 2002:a50:9983:0:b0:57c:4db6:c0fc with SMTP id 4fb4d7f45d1cf-57c5089065amr6105596a12.10.1718033341310; Mon, 10 Jun 2024 08:29:01 -0700 (PDT) MIME-Version: 1.0 References: <81470919d07dd3968c96f378340a032778cedb34.camel@siemens.com> In-Reply-To: From: "Lean Sheng Tan via groups.io" Date: Mon, 10 Jun 2024 17:28:24 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for payload size > 16MB To: "Witt, Sebastian" Cc: "Guo, Gua" , "devel@edk2.groups.io" , "Rhodes, Sean" , "Lu, James" , "Dong, Guo" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 10 Jun 2024 08:29:03 -0700 Resent-From: sheng.tan@9elements.com Reply-To: devel@edk2.groups.io,sheng.tan@9elements.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/related; boundary="000000000000059c72061a8acfa2" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ZwqjBnGW; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --000000000000059c72061a8acfa2 Content-Type: multipart/alternative; boundary="000000000000059c6c061a8acfa1" --000000000000059c6c061a8acfa1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gua/ Dong Guo, Do you know how to proceed? https://github.com/tianocore/edk2/pull/5732 Does the patch submitter have to actively rebase its patch? Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian wrote: > Done here: https://github.com/tianocore/edk2/pull/5732 > > > > Regards, > > Sebastian > > > > *From:* Guo, Gua > *Sent:* Wednesday, 5 June 2024 16:22 > *To:* Tan, Lean Sheng ; devel@edk2.groups.io; > Witt, Sebastian (DI FA CTR IPC PRC2) ; > Rhodes, Sean ; Lu, James ; > Dong, Guo > *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for > payload size > 16MB > > > > Please send PR also. > ------------------------------ > > *From:* Lean Sheng Tan > *Sent:* Wednesday, June 5, 2024 10:18:27 PM > *To:* devel@edk2.groups.io ; Witt, Sebastian < > sebastian.witt@siemens.com>; Guo, Gua ; Rhodes, Sean > ; Lu, James ; Dong, Guo < > guo.dong@intel.com> > *Subject:* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore for > payload size > 16MB > > > > + edk2 payload maintainers > > > Best Regards, > > *Lean Sheng Tan* > > > [image: Image removed by sender.] > > 9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, Germany > > Email: sheng.tan@9elements.com > > Phone: *+49 234 68 94 188 <+492346894188>* > > Mobile: *+49 176 76 113842 <+4917676113842>* > > > > Registered office: Bochum > > Commercial register: Amtsgericht Bochum, HRB 17519 > > Management: Sebastian German, Eray Bazaar > > > Data protection information according to Art. 13 GDPR > > > > > > > On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io > wrote: > > > Fix calculation of first section in FileFindSection for FILE2 headers in > UefiPayloadEntry module. > > Signed-of-by: Sebastian Witt > --- > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > index 898d610951..9cb6edefcf 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > +++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > @@ -211,13 +211,14 @@ FileFindSection ( > > if (IS_FFS_FILE2 (FileHeader)) { > FileSize =3D FFS_FILE2_SIZE (FileHeader); > + Section =3D (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEADER2 > *)FileHeader) + 1); > } else { > FileSize =3D FFS_FILE_SIZE (FileHeader); > + Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > } > > FileSize -=3D sizeof (EFI_FFS_FILE_HEADER); > > - Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > Index =3D 0; > while (Index < FileSize) { > if (Section->Type =3D=3D SectionType) { > -- > 2.39.2 > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119536): https://edk2.groups.io/g/devel/message/119536 Mute This Topic: https://groups.io/mt/106471262/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --000000000000059c6c061a8acfa1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gua/ Dong Guo,
Does the patch submitter have to actively= rebase its patch?

Best Regards,
Lean Shen= g Tan



9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, German= y
Email:=C2= =A0sheng.tan@9elements.com
<= font color=3D"#000000">Phone:=C2=A0+49 234 68 94 188
Mobile:=C2=A0+49 176 76 113842

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Ba= zaar


On Thu, 6 Jun 2024 at 15:38, Witt, Sebastian <sebastian.witt@siemens.com> wrote:

Done h= ere: h= ttps://github.com/tianocore/edk2/pull/5732

=C2=A0

Regard= s,

Sebast= ian

=C2=A0

From: Guo, Gua <gua.guo@intel.com>
Sent: Wednesday, 5 June 2024 16:22
To: Tan, Lean Sheng <sheng.tan@9elements.com>; devel@edk2.groups.io; Witt, Sebastian = (DI FA CTR IPC PRC2) <sebastian.witt@siemens.com>; Rhodes, Sean <sean@sta= rlabs.systems>; Lu, James <james.lu@intel.com>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore fo= r payload size > 16MB

=C2=A0

Please send PR also.

From: Lean Sheng Tan <sheng.tan@9elements.com&g= t;
Sent: Wednesday, June 5, 2024 10:18:27 PM
To: devel@= edk2.groups.io <devel@edk2.groups.io>; Witt, Sebastian <sebastian.witt@siemens.com= >; Guo, Gua <g= ua.guo@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, J= ames <james.lu@i= ntel.com>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix LoadDxeCore fo= r payload size > 16MB

=C2=A0

+ edk2 payload maintainers=C2=A0


Best Regards,

Lean Sheng Tan


3D"Ima=

9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Boc= hum, Germany

Email:=C2=A0sheng.tan@9= elements.com

Phone:=C2=A0= +49 234 68 94 188

Mobile:=C2=A0+49 176 76 113842

=C2=A0

Registered= office: Bochum

Commercial= register: Amtsgericht Bochum, HRB 17519

Management= : Sebastian German, Eray Bazaar

=C2=A0

=C2=A0

On Mon, 3 Jun 2024 at 23:20, Witt, Sebastian via groups.io <sebastian.witt=3Dsiemens.com@groups.io> wrote:


Fix calculation of first section in FileFindSection for FILE2 headers in Ue= fiPayloadEntry module.

Signed-of-by: Sebastian Witt <sebastian.witt@siemens.com>
---
=C2=A0UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 3 ++-
=C2=A01 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c b/UefiPayloadPkg= /UefiPayloadEntry/LoadDxeCore.c
index 898d610951..9cb6edefcf 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c
@@ -211,13 +211,14 @@ FileFindSection (

=C2=A0 =C2=A0if (IS_FFS_FILE2 (FileHeader)) {
=C2=A0 =C2=A0 =C2=A0FileSize =3D FFS_FILE2_SIZE (FileHeader);
+=C2=A0 =C2=A0 Section =3D (EFI_COMMON_SECTION_HEADER *)(((EFI_FFS_FILE_HEA= DER2 *)FileHeader) + 1);
=C2=A0 =C2=A0} else {
=C2=A0 =C2=A0 =C2=A0FileSize =3D FFS_FILE_SIZE (FileHeader);
+=C2=A0 =C2=A0 Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); =C2=A0 =C2=A0}

=C2=A0 =C2=A0FileSize -=3D sizeof (EFI_FFS_FILE_HEADER);

-=C2=A0 Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
=C2=A0 =C2=A0Index=C2=A0 =C2=A0=3D 0;
=C2=A0 =C2=A0while (Index < FileSize) {
=C2=A0 =C2=A0 =C2=A0if (Section->Type =3D=3D SectionType) {
--
2.39.2





_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119536) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--000000000000059c6c061a8acfa1-- --000000000000059c72061a8acfa2 Content-Type: image/jpeg; name="~WRD0002.jpg" Content-Disposition: inline; filename="~WRD0002.jpg" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: ii_19002c2fb36beff1c801 /9j/4AAQSkZJRgABAQEAYABgAAD/2wBDAAgGBgcGBQgHBwcJCQgKDBQNDAsLDBkSEw8UHRofHh0a HBwgJC4nICIsIxwcKDcpLDAxNDQ0Hyc5PTgyPC4zNDL/2wBDAQkJCQwLDBgNDRgyIRwhMjIyMjIy MjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjL/wAARCABkAGQDASIA AhEBAxEB/8QAHwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUFBAQA AAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkKFhcYGRolJicoKSo0NTY3 ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWm p6ipqrKztLW2t7i5usLDxMXGx8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEA AwEBAQEBAQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAECAxEEBSEx BhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRomJygpKjU2Nzg5OkNERUZHSElK U1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3 uLm6wsPExcbHyMnK0tPU1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD3+iii gAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKA CiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAK KKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAooooAKKKKACiiigAoo ooAKKKKACiiigAooooAKKKKACiiigD//2Q== --000000000000059c72061a8acfa2--