[edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Patrick Rudolph]

Add package that are required to build PlatformPayloadFeaturePkg.

Test:
Running python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index e36e5d6e..9dcd1da6 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
@@ -33,6 +33,9 @@
 
 [Packages]
   MinPlatformPkg/MinPlatformPkg.dec
+  MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
+  UefiPayloadPkg/UefiPayloadPkg.dec
 
 ################################################################################
 #
-- 
2.39.1

[edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Patrick Rudolph]

- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv

Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4358
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
index 2fbb8215..51aa8de5 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
@@ -38,7 +38,7 @@ def BuildUniversalPayload(Args, MacroList):
     # Find universal UEFI payload build build script
     #
     Edk2PayloadBuildScript = os.path.normpath("UefiPayloadPkg/UniversalPayloadBuild.py")
-    for package_path in os.environ['PACKAGES_PATH'].split(';'):
+    for package_path in os.environ['PACKAGES_PATH'].split(os.pathsep):
         if os.path.exists (os.path.join (package_path, Edk2PayloadBuildScript)):
             Edk2PayloadBuildScript = os.path.join (package_path, Edk2PayloadBuildScript)
             break
@@ -49,7 +49,7 @@ def BuildUniversalPayload(Args, MacroList):
     BuildDir               = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/UefiPayloadPkgX64"))
     PlatformFvReportPath   = os.path.join(BuildDir, "PlatformPayloadReport.txt")
     UniversalUefiPld       = os.path.join(BuildDir, 'UniversalPayload.elf')
-    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PlatformPayload.Fv"))
+    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PLATFORMPAYLOAD.Fv"))
 
     if "CLANG_BIN" in os.environ:
         LlvmObjcopyPath = os.path.join(os.environ["CLANG_BIN"], "llvm-objcopy")
-- 
2.39.1

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Sheng Lean Tan]

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Can anyone help to review this? Thanks :)

[-- Attachment #2: Type: text/html, Size: 76 bytes --]

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Sheng Lean Tan]

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Can anyone help to review this? Thanks :)

[-- Attachment #2: Type: text/html, Size: 343 bytes --]

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Sheng Lean Tan]

[-- Attachment #1: Type: text/plain, Size: 29 bytes --]

Another reminder, thanks.

>

[-- Attachment #2: Type: text/html, Size: 239 bytes --]

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Sheng Lean Tan]

[-- Attachment #1: Type: text/plain, Size: 32 bytes --]

> Another reminder, thanks.
>
>

[-- Attachment #2: Type: text/html, Size: 253 bytes --]

Re: [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Isaac Oram]

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

In the future, please CC maintainers from https://github.com/iworam/edk2-platforms/blob/master/Maintainers.txt in the commit messages.


-----Original Message-----
From: Patrick Rudolph <patrick.rudolph@9elements.com> 
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv

Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4358
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
index 2fbb8215..51aa8de5 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
@@ -38,7 +38,7 @@ def BuildUniversalPayload(Args, MacroList):
     # Find universal UEFI payload build build script

     #

     Edk2PayloadBuildScript = os.path.normpath("UefiPayloadPkg/UniversalPayloadBuild.py")

-    for package_path in os.environ['PACKAGES_PATH'].split(';'):

+    for package_path in os.environ['PACKAGES_PATH'].split(os.pathsep):

         if os.path.exists (os.path.join (package_path, Edk2PayloadBuildScript)):

             Edk2PayloadBuildScript = os.path.join (package_path, Edk2PayloadBuildScript)

             break

@@ -49,7 +49,7 @@ def BuildUniversalPayload(Args, MacroList):
     BuildDir               = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/UefiPayloadPkgX64"))

     PlatformFvReportPath   = os.path.join(BuildDir, "PlatformPayloadReport.txt")

     UniversalUefiPld       = os.path.join(BuildDir, 'UniversalPayload.elf')

-    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PlatformPayload.Fv"))

+    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PLATFORMPAYLOAD.Fv"))

 

     if "CLANG_BIN" in os.environ:

         LlvmObjcopyPath = os.path.join(os.environ["CLANG_BIN"], "llvm-objcopy")

-- 
2.39.1

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Isaac Oram]

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick Rudolph
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

Add package that are required to build PlatformPayloadFeaturePkg.

Test:
Running python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index e36e5d6e..9dcd1da6 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg
+++ .dsc
@@ -33,6 +33,9 @@
  [Packages]   MinPlatformPkg/MinPlatformPkg.dec+  MdePkg/MdePkg.dec+  MdeModulePkg/MdeModulePkg.dec+  UefiPayloadPkg/UefiPayloadPkg.dec  ################################################################################ #-- 
2.39.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101414): https://edk2.groups.io/g/devel/message/101414
Mute This Topic: https://groups.io/mt/97727097/1492418
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=-=-=-=-=-=

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Isaac Oram]

Pushed as 8efa4f42b5..d7466862b7

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 12:33 PM
To: Rudolph, Patrick <patrick.rudolph@9elements.com>
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

In the future, please CC maintainers from https://github.com/iworam/edk2-platforms/blob/master/Maintainers.txt in the commit messages.


-----Original Message-----
From: Patrick Rudolph <patrick.rudolph@9elements.com> 
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv

Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4358
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
index 2fbb8215..51aa8de5 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
@@ -38,7 +38,7 @@ def BuildUniversalPayload(Args, MacroList):
     # Find universal UEFI payload build build script

     #

     Edk2PayloadBuildScript = os.path.normpath("UefiPayloadPkg/UniversalPayloadBuild.py")

-    for package_path in os.environ['PACKAGES_PATH'].split(';'):

+    for package_path in os.environ['PACKAGES_PATH'].split(os.pathsep):

         if os.path.exists (os.path.join (package_path, Edk2PayloadBuildScript)):

             Edk2PayloadBuildScript = os.path.join (package_path, Edk2PayloadBuildScript)

             break

@@ -49,7 +49,7 @@ def BuildUniversalPayload(Args, MacroList):
     BuildDir               = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/UefiPayloadPkgX64"))

     PlatformFvReportPath   = os.path.join(BuildDir, "PlatformPayloadReport.txt")

     UniversalUefiPld       = os.path.join(BuildDir, 'UniversalPayload.elf')

-    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PlatformPayload.Fv"))

+    PlatformFv             = os.path.join(os.environ['WORKSPACE'], os.path.normpath("Build/PlatformPayloadFeaturePkg"), f"{BuildTarget}_{ToolChain}", os.path.normpath("FV/PLATFORMPAYLOAD.Fv"))

 

     if "CLANG_BIN" in os.environ:

         LlvmObjcopyPath = os.path.join(os.environ["CLANG_BIN"], "llvm-objcopy")

-- 
2.39.1

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Isaac Oram]

Pushed as 8efa4f42b5..d7466862b7

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Tuesday, March 21, 2023 1:09 PM
To: devel@edk2.groups.io; Rudolph, Patrick <patrick.rudolph@9elements.com>
Cc: quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Guo <guo.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Patrick Rudolph
Sent: Monday, March 20, 2023 1:53 AM
Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com; Kinney, Michael D <michael.d.kinney@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

Add package that are required to build PlatformPayloadFeaturePkg.

Test:
Running python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
 Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index e36e5d6e..9dcd1da6 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg
+++ .dsc
@@ -33,6 +33,9 @@
  [Packages]   MinPlatformPkg/MinPlatformPkg.dec+  MdePkg/MdePkg.dec+  MdeModulePkg/MdeModulePkg.dec+  UefiPayloadPkg/UefiPayloadPkg.dec  ################################################################################ #-- 
2.39.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101414): https://edk2.groups.io/g/devel/message/101414
Mute This Topic: https://groups.io/mt/97727097/1492418
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=-=-=-=-=-=