From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mx.groups.io with SMTP id smtpd.web09.6225.1652788736047693400 for ; Tue, 17 May 2022 04:58:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=b9SiApZE; spf=pass (domain: 9elements.com, ip: 209.85.208.169, mailfrom: sheng.tan@9elements.com) Received: by mail-lj1-f169.google.com with SMTP id h8so802484ljb.6 for ; Tue, 17 May 2022 04:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uZU4nW7k+wM15Ss2NszLl1dPEyNPSvrK/OnUmHuh0kc=; b=b9SiApZEACkLHhaUUWkhR3x1JpRkvWZ6l46Zr4Mf4FlJjQFUrC32Bk7JndO68PtO53 /5apy1LBDl0RHdiaidVKhvtHQq79Hrn2vwH4S4J1as39WL3jiTI4Z/9T7MC4YFQEFJPJ JNd7i+8+SRNbC2ed9B0UCb765394yvDt677seNgX9G+vTLUKPtt/QoHU0b0xy5CpsCuk 8/Pgeigy3sTX7avN9no35u1uFNRckTl4DvmR8zmwT5YsSISDiG4foIU5R7VAmby0VdtY EREFsqS5MhpFolf4T9uW/P6+aLWtZHf3DBRnhI3dM6ScwWlAldmGW/k49QlAV1NCwpk0 JmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uZU4nW7k+wM15Ss2NszLl1dPEyNPSvrK/OnUmHuh0kc=; b=gjRmrnHs0P11G9dukfkXtQFRgyMI5hhJ1VeOS0rl7Jiidq3GapSgWZ5Joc7tPZO9NN iN+72XQBrd3ZYDXHaKEuAxAOaLiTgWR9j2NkmLWNJTo9+jfMwMBmY5n93/b/zHthR0kO SjiqBB+XZG/XJGnfSrLR7NelTdbnvrAwkSz52sDKod7xYdNGXg8A8JxFORyxeCt0hsOr pMU06wWfI2qrWPcCR1OVGmdL4SufM6MB8l1T6RIlumS5ZC/+hXxBdBpBgOIyqRJowrYZ N2wJS12eVFCp/b1T3tBQMm0OACHk2CQ02Q+SRMwPwjy3RbdDgjLlx2yAFpDwFiDk9Aas QVuw== X-Gm-Message-State: AOAM530z6PSZVl9LOsM0tB/jhuTFDRGEPSbddV/7RZ8OInA92lxRoWRX 0cqqcLGgZztXwHtLVBiX7eCDCP0wRiqDyQW5cjrPcsSLKS4= X-Google-Smtp-Source: ABdhPJwDRp3v2RYtxSLIyIcPw4fbAc0hZYrxWfWHKflLdmxDWGVymw0Iy3FtA2QHhy4SHrt3/ylldBILLWb8mVcQ5gY= X-Received: by 2002:a05:651c:205e:b0:250:796a:e074 with SMTP id t30-20020a05651c205e00b00250796ae074mr13991251ljo.41.1652788733568; Tue, 17 May 2022 04:58:53 -0700 (PDT) MIME-Version: 1.0 References: <2106.1652684379544394027@groups.io> In-Reply-To: From: "Sheng Lean Tan" Date: Tue, 17 May 2022 13:58:17 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: "Zeng, Star" , "Gao, Liming" , "Rhodes, Sean" Content-Type: multipart/alternative; boundary="0000000000005a772905df33ddae" --0000000000005a772905df33ddae Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Star & Liming, Any update on this? Much appreciated. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, Germany Email: sheng.tan@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial register: Amtsgericht Bochum, HRB 17519 Management: Sebastian German, Eray Bazaar Data protection information according to Art. 13 GDPR On Mon, 16 May 2022 at 11:03, Wu, Hao A wrote: > Sorry Star and Liming, > > > > For the below patch (removing the alignment check for WorkSpace & > SpareArea): > > https://edk2.groups.io/g/devel/message/89742 > > > > Do you think it will impact the FTW service on flash device? Thanks in > advance. > > > > Best Regards, > > Hao Wu > > > > *From:* devel@edk2.groups.io * On Behalf Of *Sean > Rhodes > *Sent:* Monday, May 16, 2022 3:54 PM > *To:* Wu, Hao A > *Cc:* devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: > Don't check for address alignment > > > > The bug discovered was with coreboot, and the PCD values are derived from > the block size of its SMMStore (NvStorage) region. The discussion on the > patch can be found here: https://review.coreboot.org/c/coreboot/+/62990 > > > > Hacking the PCDs could work,, but why would we want to keep an incorrect > check? > > > > Thanks! > > > > > > On Mon, 16 May 2022 at 08:36, Wu, Hao A wrote: > > Sorry for not being clear on what I mean. > > Is it possible to change the platform PCD values and keep these block siz= e > alignment requirements. > > > > Best Regards, > > Hao Wu > > > > *From:* devel@edk2.groups.io *On Behalf Of *Sean > Rhodes > *Sent:* Monday, May 16, 2022 3:00 PM > *To:* Wu; Wu, Hao A ; devel@edk2.groups.io > *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: > Don't check for address alignment > > > > Hi Hao > > Yes, it does conflict - I will update the patch to fix these comments :) > > Thank you > >=20 > > --0000000000005a772905df33ddae Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Star & Liming,
Any update on this?
Mu= ch appreciated.

<= div>Best Regards,
Lea= n Sheng Tan



9elements GmbH, Kortumstra=C3=9Fe 19-21, 44787 Bochum, = Germany
Email= :=C2=A0sheng.tan@9elements.com
<= font>Phone:=C2=A0+49 234 68 94 188<= /div>
Mobile:=C2=A0+49 176 76 113842
=

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Er= ay Bazaar

<= /div>

On Mon, 16 May 2022 at 11:03, Wu, Hao A <hao.a.wu@intel.com> wrote:

Sorry Star and Liming,

=C2=A0

For the below patch (removing the alignment check fo= r WorkSpace & SpareArea):

https://edk2.groups.io/g/devel/message/89742<= /u>

=C2=A0

Do you think it will impact the FTW service on flash= device? Thanks in advance.

=C2=A0

Best Regards,

Hao Wu

=C2=A0

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, May 16, 2022 3:54 PM
To: Wu, Hao A <hao.a.wu@intel.com>
Cc: devel@= edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe= : Don't check for address alignment

=C2=A0

The bug discovered was with coreboot, and the PCD values are de= rived from the block size of its SMMStore (NvStorage) region. The discussio= n on the patch can be found here: https://review.coreboot.org/c/coreboot/+/62990

=C2=A0

Hacking the PCDs could work,, but why would we want to keep an = incorrect check?

=C2=A0

Thanks!

=C2=A0

=C2=A0

On Mon, 16 May 2022 at 08:36, Wu, Hao A <hao.a.wu@intel.com>= wrote:

Sorry for not being clear on what I mean.<= /u>

Is it possible to change the platform PCD values and= keep these block size alignment requirements.

=C2=A0

Best Regards,

Hao Wu

=C2=A0

From: devel@edk2.groups= .io <devel= @edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, May 16, 2022 3:00 PM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups= .io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe= : Don't check for address alignment

=C2=A0

Hi Hao

Yes, it does conflict - I will update the patch to fix these comments :)
Thank you

=20

--0000000000005a772905df33ddae--