From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mx.groups.io with SMTP id smtpd.web10.7450.1682514672304428794 for ; Wed, 26 Apr 2023 06:11:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@9elements.com header.s=google header.b=XqOzSeac; spf=pass (domain: 9elements.com, ip: 209.85.208.46, mailfrom: sheng.tan@9elements.com) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-504eccc8fc8so10355890a12.2 for ; Wed, 26 Apr 2023 06:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1682514670; x=1685106670; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rn0n7FLchv6dxMq1ZR+DNSltRSzI1Ed1sBamp4ELLUY=; b=XqOzSeacftd6QuGVo4F6uQHwBqk1pDMXc65m4DkZD8f3g93vU1nn/161DZqQJfKDST tZ37TcGJ3Eug+6pzInq+XML9oj2F8y7sDQnkYxs/NLkBXrn+DPjGJ+vbxcpvOjKkHNKE SDryutwfI452AF+DysptTVwJvkYUBiTy3aCIat6MrqtsBrKDmXyYMSguyhEgAphSs9qH xdVA77AoAOgzvoZ/w8Vt+wpFF9/kUZiv7EkssKsMAtk1lxC52czeCwL7EK9mz6/mabHl UyypyDV8OnUW9trMx8PVhI/IC7QW1i+5lIfVks+CiunXnBly2Xe6YRdY3aUnx5tqiHCy JTOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682514670; x=1685106670; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rn0n7FLchv6dxMq1ZR+DNSltRSzI1Ed1sBamp4ELLUY=; b=ThrT5WHDbei6BrmC+0l4ITTgYIcKdARF8gHljhso7f5KOg0c7+K5WdsuV5Yt8oG7Fz 8Wp1RXWCVn2L4Bu4Puk24M1g6awYEKO3GEi0GDJDrol5rWrbKbCmIOJzV6gZSiXTIyxr 3r7F35s+vW7sK8lj+3vfqO0M7+99AZnu7cPoeeLHIgDYJuDmujQn1fN04q+1YYEKCTNo VH5IJvAbNQD3WJxAqecnp/v6VJ2UvgDhzayRsVutwi1U8iyqKhBABKM8iCT35NjyLDOW yJldiH62RYtOllT5YIdqhIPbHuTJbqzHDsclZU4h1EcjTLfWxx0KDTn2lnK/ZfTgFBDl ujng== X-Gm-Message-State: AAQBX9dgwtgcOr6RQRRZq8JDPJQjF64tPSyrh0iZJ53tgjNKsJX4/QQn G+KmwhMQiaM6bPYXcHeONXqSf+SvWKVXoYaXroiZhwm1/sDf8r9VPDUn4X27 X-Google-Smtp-Source: AKy350b3a2GaMgddI73h5dP0vXVE4kyxc2pyiWAgm1qMS5ck4Ob3WZrp/ZOLAnYVcTjswM7KE7ftCY4VohVYxFJXfyE= X-Received: by 2002:aa7:df17:0:b0:506:a657:a62b with SMTP id c23-20020aa7df17000000b00506a657a62bmr18513693edy.23.1682514670273; Wed, 26 Apr 2023 06:11:10 -0700 (PDT) MIME-Version: 1.0 References: <7edb8c7baae2fc58034a62f50f5f4000fb5bd102.1682442501.git.benjamin.doron00@gmail.com> In-Reply-To: From: "Sheng Lean Tan" Date: Wed, 26 Apr 2023 15:10:34 +0200 Message-ID: Subject: Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support To: devel@edk2.groups.io, gua.guo@intel.com Cc: "Rhodes, Sean" , Benjamin Doron , "Dong, Guo" , "Ni, Ray" , "Lu, James" Content-Type: multipart/alternative; boundary="000000000000405a8105fa3cf93e" --000000000000405a8105fa3cf93e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Gua, Thanks for the review. Do you have a proposal or small example on how you want to separate into another FV? Thanks, Sheng On Wed, 26 Apr 2023 at 14:55, Guo, Gua wrote: > Do we separate these Security Driver into separate FV ? > > > > I really don=E2=80=99t want to see gather everything into uefi_fv. > > Separate it into a lot of fv, we can easy to plug in and plug out. > > > > Thanks, > > Gua > > > > *From:* devel@edk2.groups.io * On Behalf Of *Sean > Rhodes > *Sent:* Wednesday, April 26, 2023 8:33 PM > *To:* Benjamin Doron > *Cc:* devel@edk2.groups.io; Dong, Guo ; Ni, Ray < > ray.ni@intel.com>; Lu, James ; Guo, Gua < > gua.guo@intel.com> > *Subject:* Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG > support > > > > Reviewed-by: Sean Rhodes > > > > On Tue, 25 Apr 2023 at 18:09, Benjamin Doron > wrote: > > From: Benjamin Doron > > Uses CPU RDRAND support and installs the EfiRngProtocol. > The protocol may be used by iPXE or the Linux kernel to gather entropy. > > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Signed-off-by: Benjamin Doron > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 1e803ba01567..486af2396731 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -634,6 +634,9 @@ > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > UefiCpuPkg/CpuDxe/CpuDxe.inf > +!if $(CPU_RNG_ENABLE) =3D=3D TRUE > + SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > +!endif > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > !if $(BOOTSPLASH_IMAGE) > MdeModulePkg/Logo/LogoDxe.inf > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index f8c2aa8c4a02..53add65a6a40 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -157,6 +157,9 @@ INF CryptoPkg/Driver/CryptoDxe.inf > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > INF UefiCpuPkg/CpuDxe/CpuDxe.inf > +!if $(CPU_RNG_ENABLE) =3D=3D TRUE > +INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf > +!endif > > INF RuleOverride =3D UI MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf > -- > 2.39.2 > >=20 > > --000000000000405a8105fa3cf93e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gua,=C2=A0
Thanks for the review.=C2=A0Do you have a= proposal or small example on how you want to separate=C2=A0into another FV= ?

Thanks,
Sheng



On Wed, 26 Apr 2023 at 14:55, Guo,= Gua <gua.guo@intel.com> wro= te:

Do we separate these Security Driver into sepa= rate FV ?

=C2=A0

I really don=E2=80=99t want to see gather ever= ything into uefi_fv.

Separate it into a lot of fv, we can easy to p= lug in and plug out.

=C2=A0

Thanks,

Gua

=C2=A0

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Wednesday, April 26, 2023 8:33 PM
To: Benjamin Doron <benjamin.doron00@gmail.com>
Cc: devel@= edk2.groups.io; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <<= a href=3D"mailto:james.lu@intel.com" target=3D"_blank">james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG s= upport

=C2=A0

Reviewed-by: Sean Rhodes <sean@starlabs.systems>=

=C2=A0

On Tue, 25 Apr 2023 at 18:09, Benjamin Doron <benjamin.doron= 00@gmail.com> wrote:

From: Benjamin Doron &l= t;benjami= n.doron@9elements.com>

Uses CPU RDRAND support and installs the EfiRngProtocol.
The protocol may be used by iPXE or the Linux kernel to gather entropy.

Cc: Guo Dong <gu= o.dong@intel.com>
Cc: Ray Ni <ray.ni= @intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: James Lu <ja= mes.lu@intel.com>
Cc: Gua Guo <gua.= guo@intel.com>
Signed-off-by: Benjamin Doron <benjamin.doron@9elements.com>
---
=C2=A0UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++
=C2=A0UefiPayloadPkg/UefiPayloadPkg.fdf | 3 +++
=C2=A02 files changed, 6 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc
index 1e803ba01567..486af2396731 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -634,6 +634,9 @@
=C2=A0 =C2=A0MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
=C2=A0!endif
=C2=A0 =C2=A0UefiCpuPkg/CpuDxe/CpuDxe.inf
+!if $(CPU_RNG_ENABLE) =3D=3D TRUE
+=C2=A0 SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
+!endif
=C2=A0 =C2=A0MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
=C2=A0!if $(BOOTSPLASH_IMAGE)
=C2=A0 =C2=A0MdeModulePkg/Logo/LogoDxe.inf
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload= Pkg.fdf
index f8c2aa8c4a02..53add65a6a40 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -157,6 +157,9 @@ INF CryptoPkg/Driver/CryptoDxe.inf
=C2=A0INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
=C2=A0!endif
=C2=A0INF UefiCpuPkg/CpuDxe/CpuDxe.inf
+!if $(CPU_RNG_ENABLE) =3D=3D TRUE
+INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
+!endif

=C2=A0INF RuleOverride =3D UI MdeModulePkg/Application/UiApp/UiApp.inf
=C2=A0INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.in= f
--
2.39.2

--000000000000405a8105fa3cf93e--