From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mx.groups.io with SMTP id smtpd.web11.163443.1680798824611588228 for ; Thu, 06 Apr 2023 09:33:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@9elements.com header.s=google header.b=VBij6TgC; spf=pass (domain: 9elements.com, ip: 209.85.218.42, mailfrom: sheng.tan@9elements.com) Received: by mail-ej1-f42.google.com with SMTP id qb20so2800046ejc.6 for ; Thu, 06 Apr 2023 09:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1680798823; x=1683390823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=azCi6+Yf4kUiGQEcLVCcuDiuVrrQEqrDhuEZrxkJBAI=; b=VBij6TgCDnESHQnyzLkzzQsptrbp/Z8Ycrhi1OvF2/f9tM+BN6KiNTUZFjD5Xi/Itf SbsacLY4vvgRk8ccxzRL9cCG51ieYmemx5di3d8nHfpzq0/SkvT3Ejq1ouXf8geRz9FE 7RaobFZ74vHNxiumlASV/wgkpvttngRjq9nT9qwcvxq51c6PHwVkh1RZWphJB+eBXsYK 3r5ztpdF43AeRBhIDa8vwJaxa5vmg50m6jzA3PZtIyOltzI6xwMxWLVf7lzNAUC/jXCF corK55Eh2AmRRhdoj1KK6jLWzaJSt8O+P5E/I+28+nHjxI9bF6CfMudSbZdRK6SdpH1b Ckcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680798823; x=1683390823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=azCi6+Yf4kUiGQEcLVCcuDiuVrrQEqrDhuEZrxkJBAI=; b=xDl/xVnw2waQGnS7S78hnKwbTQbdIcfPRaf1nIMg9OxCytFq5BSwAEvg2pyjEAOgQb egfHOkVHKtpzuzyhRE0cJgn7dpptrlX8unRGVQHBYhcffOYiqcB6GmOyTlBxHl5+/ErO U1Uf/IDI1C6RXgsGwi1bCsopnRlJMaQKspuvlB1VEAkEuTR2Z2fKUEiAF+z4U5C9e7Dy I8d2lMWRklw82u9zgGwpl6KKWhYogYCOiJxDJF0R8EJWksZ00fy+W+vfoafiFW0P2sOv hyWTQpUtKLxvRhHCNVyIBTWLGcyvk+nuJgjia9DTY9uzSBnQWqExr1Gc2zmlA7g/XNi2 CxfA== X-Gm-Message-State: AAQBX9dGbjI9wKUElJwtKy0FeJEQR7L18DhAYba/6Z9WoFWgjEsvgOoB 4dZS2qqI2rzbjq5ht3d0N5CDEAXvpuKYkqYwvsneHZPyctQIycwhLo8mJQ== X-Google-Smtp-Source: AKy350bjAmMSh9q7u0ADXpjXYQz2BEPPuaOxBy7MB8cxDmI97/+vhurTUcIuR+vA9BhCNDHCfJFDtG60Go4ml/PG+I0= X-Received: by 2002:a17:906:3393:b0:933:7658:8b44 with SMTP id v19-20020a170906339300b0093376588b44mr3476577eja.15.1680798822538; Thu, 06 Apr 2023 09:33:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Sheng Lean Tan" Date: Thu, 6 Apr 2023 18:33:06 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library. To: devel@edk2.groups.io, andrei.warkentin@intel.com Cc: "Lin, Benny" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Sean Brogan , Michael Kubacki Content-Type: multipart/alternative; boundary="000000000000c1bd9d05f8ad78e4" --000000000000c1bd9d05f8ad78e4 Content-Type: text/plain; charset="UTF-8" Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah it seems like a valid concern here as Mik mentioned on edk2-libc, and it seems to fits edk2 long term interest on this. Can we file this as an issue in Bugzilla for tracking or something? Since this will take some time to work on this as it involves a bigger discussion, personally I think we could get this FDT patch in first meanwhile, and also remove the FDT from Embedded Pkg as next step, per discussion with Leif? What do you think? On Sat, 1 Apr 2023 at 03:30, Andrei Warkentin wrote: > How does this relate to the existing EmbeddedPkg/Library/FdtLib code? Is > there a specific plan to move away from this in existing components? > > I did look in the BZ (https://bugzilla.tianocore.org/show_bug.cgi?id=4392) > but this doesn't seem to acknowledge that there is existing Fdt support in > EmbeddedPkg. > > A > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Benny > > Lin > > Sent: Thursday, March 30, 2023 11:52 AM > > To: devel@edk2.groups.io > > Cc: Lin, Benny ; Kinney, Michael D > > ; Gao, Liming ; > > Liu, Zhiguang ; Sean Brogan > > ; Michael Kubacki > > > > Subject: [edk2-devel] [PATCH 0/2] Support FDT library. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392 > > Add FDT support in EDK2 by submodule 3rd party libfdt > > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Sean Brogan > > Cc: Michael Kubacki > > Signed-off-by: Benny Lin > > > > Benny Lin (2): > > MdePkg: Support FDT library. > > .pytool: Support FDT library. > > > > .gitmodules | 3 + > > .pytool/CISettings.py | 2 + > > MdePkg/Include/Library/FdtLib.h | 300 ++++++++++++++++++++++ > > MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 62 +++++ > > MdePkg/Library/BaseFdtLib/BaseFdtLib.uni | 14 + > > MdePkg/Library/BaseFdtLib/FdtLib.c | 284 ++++++++++++++++++++ > > MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 102 ++++++++ > > MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 138 ++++++++++ > > MdePkg/Library/BaseFdtLib/libfdt | 1 + > > MdePkg/Library/BaseFdtLib/limits.h | 10 + > > MdePkg/Library/BaseFdtLib/stdbool.h | 10 + > > MdePkg/Library/BaseFdtLib/stddef.h | 10 + > > MdePkg/Library/BaseFdtLib/stdint.h | 10 + > > MdePkg/Library/BaseFdtLib/stdlib.h | 10 + > > MdePkg/Library/BaseFdtLib/string.h | 10 + > > MdePkg/MdePkg.ci.yaml | 17 +- > > MdePkg/MdePkg.dec | 4 + > > MdePkg/MdePkg.dsc | 2 + > > ReadMe.rst | 1 + > > 19 files changed, 988 insertions(+), 2 deletions(-) create mode 100644 > > MdePkg/Include/Library/FdtLib.h create mode 100644 > > MdePkg/Library/BaseFdtLib/BaseFdtLib.inf > > create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.uni > > create mode 100644 MdePkg/Library/BaseFdtLib/FdtLib.c > > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtSupport.h > > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > > create mode 160000 MdePkg/Library/BaseFdtLib/libfdt create mode 100644 > > MdePkg/Library/BaseFdtLib/limits.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdbool.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stddef.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdint.h > > create mode 100644 MdePkg/Library/BaseFdtLib/stdlib.h > > create mode 100644 MdePkg/Library/BaseFdtLib/string.h > > > > -- > > 2.39.1.windows.1 > > > > > > > > > > > > > > > > > --000000000000c1bd9d05f8ad78e4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah = it seems like a valid concern here as Mik mentioned on=C2=A0edk2-libc, and = it seems to fits edk2 long term interest on this.
Can we file this as a= n issue in Bugzilla for tracking or something? Since this will take some ti= me to work on this as it involves=C2=A0a bigger discussion, personally I th= ink we could get this FDT patch in first meanwhile, and also remove the FDT= from Embedded Pkg as next step, per discussion with Leif?
What d= o you think?


On Sat, 1 Apr 2023 at 03:30, Andr= ei Warkentin <andrei.warke= ntin@intel.com> wrote:
How does this relate to the existing EmbeddedPkg/Library/FdtL= ib code? Is there a specific plan to move away from this in existing compon= ents?

I did look in the BZ (https://bugzilla.tianocor= e.org/show_bug.cgi?id=3D4392) but this doesn't seem to acknowledge = that there is existing Fdt support in EmbeddedPkg.

A

> -----Original Message-----
> From: devel@= edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benny
> Lin
> Sent: Thursday, March 30, 2023 11:52 AM
> To: devel@ed= k2.groups.io
> Cc: Lin, Benny <benny.lin@intel.com>; Kinney, Michael D
> <mi= chael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Sean Brogan
> <sea= n.brogan@microsoft.com>; Michael Kubacki
> <= mikuback@linux.microsoft.com>
> Subject: [edk2-devel] [PATCH 0/2] Support FDT library.
>
> REF: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D4392
> Add FDT support in EDK2 by submodule 3rd party libfdt
> (https://github.com/devicetree-org/p= ylibfdt/tree/main/libfdt)
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Benny Lin <benny.lin@intel.com>
>
> Benny Lin (2):
>=C2=A0 =C2=A0MdePkg: Support FDT library.
>=C2=A0 =C2=A0.pytool: Support FDT library.
>
>=C2=A0 .gitmodules=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A03 = +
>=C2=A0 .pytool/CISettings.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +
>=C2=A0 MdePkg/Include/Library/FdtLib.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0| 300 ++++++++++++++++++++++
>=C2=A0 MdePkg/Library/BaseFdtLib/BaseFdtLib.inf=C2=A0 |=C2=A0 62 +++++<= br> > MdePkg/Library/BaseFdtLib/BaseFdtLib.uni=C2=A0 |=C2=A0 14 +
>=C2=A0 MdePkg/Library/BaseFdtLib/FdtLib.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | = 284 ++++++++++++++++++++
>=C2=A0 MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 102 ++++++++
> MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 138 ++++++++++
>=C2=A0 MdePkg/Library/BaseFdtLib/libfdt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 =C2=A01 +
>=C2=A0 MdePkg/Library/BaseFdtLib/limits.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 +
>=C2=A0 MdePkg/Library/BaseFdtLib/stdbool.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 10 +
>=C2=A0 MdePkg/Library/BaseFdtLib/stddef.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 +
>=C2=A0 MdePkg/Library/BaseFdtLib/stdint.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 +
>=C2=A0 MdePkg/Library/BaseFdtLib/stdlib.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 +
>=C2=A0 MdePkg/Library/BaseFdtLib/string.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 +
>=C2=A0 MdePkg/MdePkg.ci.yaml=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 17 +-
>=C2=A0 MdePkg/MdePkg.dec=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 +
>=C2=A0 MdePkg/MdePkg.dsc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +
>=C2=A0 ReadMe.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01= +
>=C2=A0 19 files changed, 988 insertions(+), 2 deletions(-)=C2=A0 create= mode 100644
> MdePkg/Include/Library/FdtLib.h=C2=A0 create mode 100644
> MdePkg/Library/BaseFdtLib/BaseFdtLib.inf
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.uni
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/FdtLib.c
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtSupport.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtWrapper.c
>=C2=A0 create mode 160000 MdePkg/Library/BaseFdtLib/libfdt=C2=A0 create= mode 100644
> MdePkg/Library/BaseFdtLib/limits.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/stdbool.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/stddef.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/stdint.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/stdlib.h
>=C2=A0 create mode 100644 MdePkg/Library/BaseFdtLib/string.h
>
> --
> 2.39.1.windows.1
>
>
>
>
>






--000000000000c1bd9d05f8ad78e4--