From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.2515.1660573088203042830 for ; Mon, 15 Aug 2022 07:18:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RLKrg9Oq; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C7B3B80ED6 for ; Mon, 15 Aug 2022 14:18:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E158CC433D7 for ; Mon, 15 Aug 2022 14:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660573084; bh=n3Rboc91qFxv0o2fWfw17HieraVyAD7CSJFgmoDlSPU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RLKrg9OqW19dP0DCWRrqOVM/UhulqlNu7raJGgM8QXMNpPMtPnOLqExOIpfO96iTO +gKxFspAjB3Kp6exIwcwNn6cdCedC2arKsvg2XcwhujVSyrbMWNNEDwTxOwKgjhed9 rA03BT7ITTjtV3p9yk/6zS1H/aVX44M4LB1fSpao9n7B7Knze9g00xlCvm8EbbE2N4 5ns+TvZP7kpFX84Qk2NoYHWhhlDLrhe2ACgUhAgfxTs3V246vYh3Wo4Wxt6LySYy51 k9X+39PXyaVVUyh63hdGVSxaIHDZQTasG4hETgf6sVaeaaerTk+FA5P7qn4PFBYfF0 Bimy8JU4DCLUA== Received: by mail-wr1-f54.google.com with SMTP id z16so9214418wrh.12 for ; Mon, 15 Aug 2022 07:18:04 -0700 (PDT) X-Gm-Message-State: ACgBeo1NZ13yIPrI4ZhQfbBg/3oR+d112jXNKg8za2u3uD77a49P3E5X weFEJeppBfovjt9tghG994rtXb6i3qzDXW7y70M= X-Google-Smtp-Source: AA6agR7y0biMdMuQSHawAMyH/EYvLA3vbcnM22kEGgv1oBPiMtM/SYFZDeLZ4tVDngSaC3CZMQFSPbCnF9yDId9Nov0= X-Received: by 2002:a05:6000:1883:b0:205:c0cb:33c6 with SMTP id a3-20020a056000188300b00205c0cb33c6mr9425101wri.39.1660573083150; Mon, 15 Aug 2022 07:18:03 -0700 (PDT) MIME-Version: 1.0 References: <20220815140956.31184-1-sami.mujawar@arm.com> In-Reply-To: <20220815140956.31184-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Mon, 15 Aug 2022 16:17:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM: FVP: Fix build break when Secure Boot is enabled To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: ardb+tianocore@kernel.org, thomas.abraham@arm.com, Akanksha.Jain2@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com Content-Type: text/plain; charset="UTF-8" On Mon, 15 Aug 2022 at 16:10, Sami Mujawar wrote: > > The edk2 patch at: > "6eb407947592 SecurityPkg: SecureBootVariableLib: Added > newly supported interfaces" introduced a new dependency > of PlatformPKProtectionLib to SecureBootVariableLib. > > This causes the FVP model platform builds to fail when > Secure Boot is enabled (i.e. SECURE_BOOT_ENABLE = TRUE). > > Therefore, add PlatformPKProtectionLib library instance > to Platform\ARM\VExpressPkg\ArmVExpress.dsc.inc to fix > the build. > > Cc: Ard Biesheuvel > Cc: Thomas Abraham > > Signed-off-by: Sami Mujawar Thanks for the fix Reviewed-by: Ard Biesheuvel Pushed as 01e3a8877180..9675047d7245 > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index e637f8933f792753213740f838e16e7180dd9469..17e4a3fd13d7517fd5e357e2cfc8aadd96dcdeea 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -143,6 +143,7 @@ [LibraryClasses.common] > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf > + PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf > > # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > >